Non-zero preemption count on voluntary preemptive kernel

2016-11-26 Thread Alexander Lochmann
Hi folks! I'm sorry to bother you, guys, but neither the mailing list 'kpreempt-t...@lists.sourceforge.net' nor Robert's address 'r...@tech9.net' exist anymore. If I have to address someone else, pls let me know. We're currently investigating the locking of data structures in the Linux Kernel

Re: [PATCH 0/7] security: apparmor: apparmorfs.c Checkpatch mods

2016-11-26 Thread Joel Fernandes
On Nov 26, 2016 1:28 PM, "Bjørn Mork" wrote: > > Greg KH writes: > > On Sat, Nov 26, 2016 at 01:02:14PM -0500, Walt Feasel wrote: > > > >> So kernelnewbies is not to be used to learn about how to fix > >> checkpatch type warning? > > > > Maybe, but really, if you

Re: [PATCH 0/7] security: apparmor: apparmorfs.c Checkpatch mods

2016-11-26 Thread Bjørn Mork
Greg KH writes: > On Sat, Nov 26, 2016 at 01:02:14PM -0500, Walt Feasel wrote: > >> So kernelnewbies is not to be used to learn about how to fix >> checkpatch type warning? > > Maybe, but really, if you have a well-formed patch, just send it to the > correct maintainers, it's up

Re: [PATCH 0/7] security: apparmor: apparmorfs.c Checkpatch mods

2016-11-26 Thread Greg KH
On Sat, Nov 26, 2016 at 01:02:14PM -0500, Walt Feasel wrote: > On Sat, Nov 26, 2016 at 06:19:22PM +0100, Greg KH wrote: > > On Sat, Nov 26, 2016 at 11:56:17AM -0500, Walt Feasel wrote: > > > On Sat, Nov 26, 2016 at 12:05:50PM +0100, Greg KH wrote: > > > > On Sat, Nov 26, 2016 at 03:43:18AM -0500,

Re: [TEST PATCH] staging: speakup: speakup_acntpc.c Consider octal permissions

2016-11-26 Thread Greg KH
On Sat, Nov 26, 2016 at 01:11:23PM -0500, Walt Feasel wrote: > On Sat, Nov 26, 2016 at 06:18:40PM +0100, Greg KH wrote: > > On Sat, Nov 26, 2016 at 12:10:28PM -0500, Walt Feasel wrote: > > > On Sat, Nov 26, 2016 at 12:05:13PM +0100, Greg KH wrote: > > > > On Mon, Nov 21, 2016 at 10:03:00PM -0500,

Re: an advise how to start

2016-11-26 Thread limor yavetz
 hi rami, thanks allot. thats exactly what i was looking for. May i had that i have read some of your articles and presentation and from your network internals book and enjoyed every minute .Many thanks,Limor Sent from Yahoo Mail on Android On Sat, Nov 26, 2016 at 21:18, Rami

Re: an advise how to start

2016-11-26 Thread Rami Rosen
Hi Limor, Regarding your question about bugs: The Linux kernel has a Bugzilla: You can browse it by a subsystem. https://bugzilla.kernel.org/describecomponents.cgi Regards, Rami Rosen http://ramirose.wixsite.com/ramirosen Hi all, i am a senior c,c++ engineer which is used to complex MT systems

Re: [TEST PATCH] staging: speakup: speakup_acntpc.c Consider octal permissions

2016-11-26 Thread Walt Feasel
On Sat, Nov 26, 2016 at 06:18:40PM +0100, Greg KH wrote: > On Sat, Nov 26, 2016 at 12:10:28PM -0500, Walt Feasel wrote: > > On Sat, Nov 26, 2016 at 12:05:13PM +0100, Greg KH wrote: > > > On Mon, Nov 21, 2016 at 10:03:00PM -0500, Walt Feasel wrote: > > > > Make suggested checkpatch modifications

Re: [PATCH 0/7] security: apparmor: apparmorfs.c Checkpatch mods

2016-11-26 Thread Walt Feasel
On Sat, Nov 26, 2016 at 06:19:22PM +0100, Greg KH wrote: > On Sat, Nov 26, 2016 at 11:56:17AM -0500, Walt Feasel wrote: > > On Sat, Nov 26, 2016 at 12:05:50PM +0100, Greg KH wrote: > > > On Sat, Nov 26, 2016 at 03:43:18AM -0500, Walt Feasel wrote: > > > > Make checkpatch modifications to include:

Re: an advise how to start

2016-11-26 Thread Dave Stevens
On Sat, 26 Nov 2016 10:22:00 + (UTC) limor yavetz wrote: > Hi all, i am a senior c,c++ engineer which is used to complex MT > systems both in user space and in layer 4. i have read some books on > the kernel, wondered around kernel code and understood parts of it >

Re: [PATCH 0/7] security: apparmor: apparmorfs.c Checkpatch mods

2016-11-26 Thread Greg KH
On Sat, Nov 26, 2016 at 11:56:17AM -0500, Walt Feasel wrote: > On Sat, Nov 26, 2016 at 12:05:50PM +0100, Greg KH wrote: > > On Sat, Nov 26, 2016 at 03:43:18AM -0500, Walt Feasel wrote: > > > Make checkpatch modifications to include: > > > > > > Multiple blank lines > > > Blank line after

Re: [TEST PATCH] staging: speakup: speakup_acntpc.c Consider octal permissions

2016-11-26 Thread Greg KH
On Sat, Nov 26, 2016 at 12:10:28PM -0500, Walt Feasel wrote: > On Sat, Nov 26, 2016 at 12:05:13PM +0100, Greg KH wrote: > > On Mon, Nov 21, 2016 at 10:03:00PM -0500, Walt Feasel wrote: > > > Make suggested checkpatch modifications for > > > WARNING: Symbolic permissions 'S_IWUSR | S_IRUGO' are not

Re: [TEST PATCH] staging: speakup: speakup_acntpc.c Consider octal permissions

2016-11-26 Thread Walt Feasel
On Sat, Nov 26, 2016 at 12:05:13PM +0100, Greg KH wrote: > On Mon, Nov 21, 2016 at 10:03:00PM -0500, Walt Feasel wrote: > > Make suggested checkpatch modifications for > > WARNING: Symbolic permissions 'S_IWUSR | S_IRUGO' are not preferred. > > Consider using octal permissions '0644'. > > WARNING:

Re: [TEST PATCH] staging: emxx_udc: emxx_udc.c Avoid CamelCase

2016-11-26 Thread Walt Feasel
On Sat, Nov 26, 2016 at 12:04:46PM +0100, Greg KH wrote: > On Tue, Nov 22, 2016 at 12:27:48AM -0500, Walt Feasel wrote: > > Make suggested checkpatch modification for > > CHECK: Avoid CamelCase > > > > Signed-off-by: Walt Feasel > > --- > > So here is another example of

Re: [PATCH 0/7] security: apparmor: apparmorfs.c Checkpatch mods

2016-11-26 Thread Walt Feasel
On Sat, Nov 26, 2016 at 12:05:50PM +0100, Greg KH wrote: > On Sat, Nov 26, 2016 at 03:43:18AM -0500, Walt Feasel wrote: > > Make checkpatch modifications to include: > > > > Multiple blank lines > > Blank line after declarations > > Space after cast > > WARN_ON vs BUG_ON > > Align parenthesis > >

Re: [PATCH 0/7] security: apparmor: apparmorfs.c Checkpatch mods

2016-11-26 Thread Greg KH
On Sat, Nov 26, 2016 at 03:43:18AM -0500, Walt Feasel wrote: > Make checkpatch modifications to include: > > Multiple blank lines > Blank line after declarations > Space after cast > WARN_ON vs BUG_ON > Align parenthesis > Comparison to NULL > Line continuations > > Walt Feasel (7): >

Re: [TEST PATCH] staging: speakup: speakup_acntpc.c Consider octal permissions

2016-11-26 Thread Greg KH
On Mon, Nov 21, 2016 at 10:03:00PM -0500, Walt Feasel wrote: > Make suggested checkpatch modifications for > WARNING: Symbolic permissions 'S_IWUSR | S_IRUGO' are not preferred. > Consider using octal permissions '0644'. > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. > Consider using

Re: [TEST PATCH] staging: emxx_udc: emxx_udc.c Avoid CamelCase

2016-11-26 Thread Greg KH
On Tue, Nov 22, 2016 at 12:27:48AM -0500, Walt Feasel wrote: > Make suggested checkpatch modification for > CHECK: Avoid CamelCase > > Signed-off-by: Walt Feasel > --- > So here is another example of warnings I have been avoiding. > I have taken every string I found not in

an advise how to start

2016-11-26 Thread limor yavetz
Hi all, i am a senior c,c++ engineer which is used to complex MT systems both in user space and in layer 4. i have read some books on the kernel, wondered around kernel code and understood parts of it subsystems. i am really enthutiastic about writing something within the kernel but i dont know

[TEST PATCH] staging: emxx_udc: emxx_udc.c Avoid CamelCase

2016-11-26 Thread Walt Feasel
Make suggested checkpatch modification for CHECK: Avoid CamelCase Signed-off-by: Walt Feasel --- So here is another example of warnings I have been avoiding. I have taken every string I found not in quotations or all capitals and made them all lowercase. There were far more

[PATCH 0/7] security: apparmor: apparmorfs.c Checkpatch mods

2016-11-26 Thread Walt Feasel
Make checkpatch modifications to include: Multiple blank lines Blank line after declarations Space after cast WARN_ON vs BUG_ON Align parenthesis Comparison to NULL Line continuations Walt Feasel (7): security: apparmor: apparmorfs.c Multiple blank lines security: apparmor: apparmorfs.c

[PATCH 7/7] security: apparmor: apparmorfs.c Line continuations

2016-11-26 Thread Walt Feasel
Make style modifications for: WARNING: Avoid unnecessary line continuations Signed-off-by: Walt Feasel --- Swaps continuation for over 80 but on same line security/apparmor/apparmorfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 3/7] security: apparmor: apparmorfs.c Space after cast

2016-11-26 Thread Walt Feasel
Make style modifications for: CHECK: No space is necessary after a cast Signed-off-by: Walt Feasel --- security/apparmor/apparmorfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/apparmor/apparmorfs.c b/security/apparmor/apparmorfs.c index

[PATCH 6/7] security: apparmor: apparmorfs.c Comparison to NULL

2016-11-26 Thread Walt Feasel
Make style modifications for: CHECK: Comparison to NULL could be written "!data" Signed-off-by: Walt Feasel --- My first patch of this type checking if this would be correct security/apparmor/apparmorfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 4/7] security: apparmor: apparmorfs.c WARN_ON vs BUG_ON

2016-11-26 Thread Walt Feasel
Make style modifications for: CHECK: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() Signed-off-by: Walt Feasel --- Not sure if correct use. Seems if copy_size > alloc_size it is corrected by writing partial data and return an

[PATCH 2/7] security: apparmor: apparmorfs.c Blank line after declarations

2016-11-26 Thread Walt Feasel
Make style modifications for: WARNING: Missing a blank line after declarations Signed-off-by: Walt Feasel --- security/apparmor/apparmorfs.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/security/apparmor/apparmorfs.c b/security/apparmor/apparmorfs.c

[PATCH 1/7] security: apparmor: apparmorfs.c Multiple blank lines

2016-11-26 Thread Walt Feasel
Make style modifications for: CHECK: Please don't use multiple blank lines Signed-off-by: Walt Feasel --- security/apparmor/apparmorfs.c | 4 1 file changed, 4 deletions(-) diff --git a/security/apparmor/apparmorfs.c b/security/apparmor/apparmorfs.c index