Re: unified-diff format

On 3 February 2017 at 13:25, srishti sharma wrote: > okay , Thanks for your reply > > On Sat, Feb 4, 2017 at 2:53 AM, Jim Davis wrote: >> On Fri, Feb 3, 2017 at 2:15 PM, srishti sharma wrote: >>> I ran perl scripts/checkpatch.pl

Re: driver todo's

I got this warning for a structure to be defined as constant , I have fixed it by adding const , now this variable is not being used in this file , so I was wondering if I should fix such warnings ? What if this variable is used in some other file and the developer didn't want it to be constant

Re: driver todo's

On Sat, Feb 04, 2017 at 03:36:02AM +0530, srishti sharma wrote: > when driver has checkpatch cleanups in it's todo , does that also > including fixing warnings , should one try to fix them ? Why wouldn't you do so? ___ Kernelnewbies mailing list

Staging Driver TODO's

If the todo's mention checkpatch cleanups , does it mean the warnings also need to be fixed ? Should one try to fix them OR only the errors ? Regards ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org

Re: should include/uapi include header files *unused* in kernel space?

On Sun, Jan 22, 2017 at 6:18 AM, Robert P. J. Day wrote: > > was perusing the UAPI content in the kernel source, prepping for a > course i'm teaching tomorrow, and just noticed there is a header file: > > $ find . -name mtd-user.h > ./include/uapi/mtd/mtd-user.h > $

Re: unified-diff format

okay , Thanks for your reply On Sat, Feb 4, 2017 at 2:53 AM, Jim Davis wrote: > On Fri, Feb 3, 2017 at 2:15 PM, srishti sharma wrote: >> I ran perl scripts/checkpatch.pl -f drivers/staging/comedi/* | less >> for the file comedi_buf.o there is one

Re: unified-diff format

On Fri, Feb 3, 2017 at 2:15 PM, srishti sharma wrote: > I ran perl scripts/checkpatch.pl -f drivers/staging/comedi/* | less > for the file comedi_buf.o there is one error , it says > ERROR: Does not appear to be a unified-diff format patch If it's an *.o file then perhaps

Re: unified-diff format

I ran perl scripts/checkpatch.pl -f drivers/staging/comedi/* | less for the file comedi_buf.o there is one error , it says ERROR: Does not appear to be a unified-diff format patch On Sat, Feb 4, 2017 at 2:43 AM, Jim Davis wrote: > On Fri, Feb 3, 2017 at 2:08 PM, srishti

Re: unified-diff format

On Fri, Feb 3, 2017 at 2:08 PM, srishti sharma wrote: > What do I need to know to fix this error ? > > On Sat, Feb 4, 2017 at 2:33 AM, srishti sharma wrote: >> What is unified-diff format , where can I read up on it ? I see this >> after running

Re: unified-diff format

What do I need to know to fix this error ? On Sat, Feb 4, 2017 at 2:33 AM, srishti sharma wrote: > What is unified-diff format , where can I read up on it ? I see this > after running checkpatch.pl . ___ Kernelnewbies mailing

unified-diff format

What is unified-diff format , where can I read up on it ? I see this after running checkpatch.pl . ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Query regarding emxx_udc

On Fri, Feb 03, 2017 at 11:17:55AM +, Amit Kumar wrote: > On Fri, Feb 03, 2017 at 01:34:11PM +0530, Deeksha varshney wrote: > > In the checkpatch.pl for the file drivers/staging /emxx_udc/emxx_udc.c > > there are checks for Camel case naming . How should I send patches for > > them? I mean

Re: Query regarding emxx_udc

On Fri, Feb 03, 2017 at 01:34:11PM +0530, Deeksha varshney wrote: > In the checkpatch.pl for the file drivers/staging /emxx_udc/emxx_udc.c > there are checks for Camel case naming . How should I send patches for > them? I mean there are Epn_ type variables should I correct them all in one > patch

Query regarding emxx_udc

In the checkpatch.pl for the file drivers/staging /emxx_udc/emxx_udc.c there are checks for Camel case naming . How should I send patches for them? I mean there are Epn_ type variables should I correct them all in one patch then there is iWriteLength variables ,correct them in another patch then