Re: bcm2835-audio: logging mechanism

2017-03-07 Thread Greg KH
On Wed, Mar 08, 2017 at 12:52:38AM +0100, Robin Krahl wrote: > So my question is: Does it make sense to replace the audio_* and LOG_* > macros with the standard dev_* functions? Yes. > And is it okay to remove log messages like "IN" and "OUT" that are > only used to track function entries and ex

Re: patch protocol question

2017-03-07 Thread Tobin C. Harding
On Wed, Mar 08, 2017 at 12:12:50AM +0100, Peter Senna Tschudin wrote: > On Tue, Mar 7, 2017 at 10:29 PM, Tobin C. Harding wrote: > > I would like to know the correct protocol in order to make the > > maintainers job as easy as possible please. > > > > Once a patch has been reviewed and the review

bcm2835-audio: logging mechanism

2017-03-07 Thread Robin Krahl
Hi there, the TODO file for drivers/staging/vc04_services/bcm2835-audio contains the following item: > 4) Cleanup the logging mechanism. The driver should probably be using > the standard kernel logging mechanisms such as dev_info, dev_dbg, and > friends. Currently there are macros audio_debug,

Re: sizeof

2017-03-07 Thread Anuz Pratap Singh Tomar
On Tue, Mar 7, 2017 at 11:20 PM, Tobin C. Harding wrote: > Question relating to the validity/usefulness of patching calls to sizeof. > > >From Documentation/process/coding-style.rst > > The preferred form for passing a size of a struct is the following: > > .. code-block:: c > > p = kmall

sizeof

2017-03-07 Thread Tobin C. Harding
Question relating to the validity/usefulness of patching calls to sizeof. >From Documentation/process/coding-style.rst The preferred form for passing a size of a struct is the following: .. code-block:: c p = kmalloc(sizeof(*p), ...); The alternative form where struct name is spelled o

Re: patch protocol question

2017-03-07 Thread Peter Senna Tschudin
On Tue, Mar 7, 2017 at 10:29 PM, Tobin C. Harding wrote: > I would like to know the correct protocol in order to make the > maintainers job as easy as possible please. > > Once a patch has been reviewed and the review makes good points that > mean the patch is invalid/unnecessary what is the proto

patch protocol question

2017-03-07 Thread Tobin C. Harding
I would like to know the correct protocol in order to make the maintainers job as easy as possible please. Once a patch has been reviewed and the review makes good points that mean the patch is invalid/unnecessary what is the protocol from then? Assuming one replies to the reviewer with thanks an

Re: Modify efivars permisson denied

2017-03-07 Thread Lucas Tanure
Worked. I can change the value, but this didn't change how the firmware works. At least for my lenovo 700 17ISK On Mon, Mar 6, 2017 at 9:39 AM, Lucas Tanure wrote: > Hi, > > I didn't tried this yet. I will try today. > > Thanks! > > On Sun, Mar 5, 2017 at 2:20 PM, Markus Böhme > wrote: >> On 03

how to get filename of execve() system call from kernel module which install hook to syscall table to intercept original syscall in kernels before 4.2 and atter 4.2 ? X86_64

2017-03-07 Thread Lev Olshvang
Hello all, In kernels 3.X up to 4.2 execve(|) system call was for x86_64 architecture the the system call was made through some magic ( I can't say I understand it ) assembly stub in arch/x86/kernel/entry_64.S so up to kernel 4.2 it was possble to patch this assembly to install the hook, ex.

Re: how to get filename of execve() system call from kernel module which install hook to syscall table to intercept original syscall in kernels before 4.2 and atter 4.2 ? X86_64

2017-03-07 Thread valdis . kletnieks
On Tue, 07 Mar 2017 20:22:33 +0100, Greg KH said: > On Mon, Mar 06, 2017 at 10:18:26AM +0300, Lev Olshvang wrote: > Why do you want to hook a syscall? that's a very complex, and broken, > and ill-advised thing to do. Please don't do that. > > What problem are you trying to solve here that led yo

Re: how to get filename of execve() system call from kernel module which install hook to syscall table to intercept original syscall in kernels before 4.2 and atter 4.2 ? X86_64

2017-03-07 Thread Greg KH
On Mon, Mar 06, 2017 at 10:18:26AM +0300, Lev Olshvang wrote: > Hello all, > > In kernels 3.X up to 4.2 execve(|) system call was for x86_64 architecture > the the system call was made through some > magic ( I can't say I understand it ) assembly stub in > arch/x86/kernel/entry_64.S > so up t