Re: picking the first patch

2021-03-21 Thread Valdis Klētnieks
On Sun, 21 Mar 2021 12:03:36 -0400, Harsha Vardhan said: > So far I have spent a lot of time dreaming to be a kernel hacker without > doing much , 1) What Greg said.. :) 2) Go read this: https://lists.kernelnewbies.org/pipermail/kernelnewbies/2017-April/017765.html And yes, *why* you want to

RE: question about ioport_map function

2021-03-21 Thread ckim
Oh my question contains discrepancy. My real question is whether the output of ioport_map is physical or virtual. (I'm confused) I know for systems with memory mapped I/O, we can just use request_mem_region, ioremap (maps to virtual address), plain memory access for the peripheral. (the page

question about ioport_map function

2021-03-21 Thread ckim
Hello all >From what I understand, to map io ports to virtual memory, we should use request_region, ioport_map/unmap and ioread/write functions. These are for architectures having input, output machine instructions like x86, x86_64. And the return address of ioport_map is physical address. Is

Re: Help filing bugs from crash reports and repro files.

2021-03-21 Thread Greg KH
On Sun, Mar 21, 2021 at 09:53:19PM +0100, Greg KH wrote: > On Wed, Mar 17, 2021 at 12:36:58AM -0400, Machiry Aravind Kumar wrote: > > Hello all, > > > > We have modified the syzkaller a bit to be more effective at finding > > kernel bugs. > > Attached are the crashes along with a reproducer .c

Re: Help filing bugs from crash reports and repro files.

2021-03-21 Thread Greg KH
On Wed, Mar 17, 2021 at 12:36:58AM -0400, Machiry Aravind Kumar wrote: > Hello all, > > We have modified the syzkaller a bit to be more effective at finding > kernel bugs. > Attached are the crashes along with a reproducer .c file. > > Any help in figuring out the underlying bug and submitting a

Device file not appearing

2021-03-21 Thread Gregory Anders
Hi all, I'm writing a char device driver and am having trouble getting the file to appear under /dev. This isn't my first rodeo: in fact, I've written a few other drivers in the past and they have all worked as expected. This driver is based on the source code of those other drivers, so I'm

Re: picking the first patch

2021-03-21 Thread Lukas Bulwahn
On Sun, Mar 21, 2021 at 5:25 PM Harsha Vardhan wrote: > > perfect ! I will do it that way then. > > besides that, generally if you are making changes to drivers , then the > responsibility of testing is on the author of the patch right ? if you don't > have the device how would you test such

Re: picking the first patch

2021-03-21 Thread Harsha Vardhan
perfect ! I will do it that way then. besides that, generally if you are making changes to drivers , then the responsibility of testing is on the author of the patch right ? if you don't have the device how would you test such things ? I would assume other subsystems like memory will have some

Re: picking the first patch

2021-03-21 Thread Greg KH
On Sun, Mar 21, 2021 at 12:03:36PM -0400, Harsha Vardhan wrote: > Any thoughts on whether I should just do a checkpatch.pl change as my first > patch ? You should do a checkpatch.pl change as your first patch :) That way you can focus on the process more than the technical aspects of the patch

picking the first patch

2021-03-21 Thread Harsha Vardhan
Hello team , Sorry for a vague question. So far I have spent a lot of time dreaming to be a kernel hacker without doing much , but I realised its geting too late and now I want to pick my first patch to work, I have decided to address the TODO at drivers/staging/grebus/TODO : " * Make pwm.c use