Re: What's wrong with my patch?

2016-03-08 Thread Navy Cheng
Thank you for your reply :) > 29 Feb is only one week old, > your patch is in queue, just wait. > > 2016-03-08 6:31 UTC+01:00, Navy Cheng <nav...@126.com>: > > Hi, > > I have sent a patch on 29 Feb, but no reply. I want to know what's wrong > > with my patch

Re: What is the role of LIST_POISON1 and LIST_POISON2?

2016-03-04 Thread Navy Cheng
On Fri, Mar 04, 2016 at 02:07:26AM -0500, valdis.kletni...@vt.edu wrote: > On Fri, 04 Mar 2016 13:02:02 +0800, Navy Cheng said: > > Hi, > > > > When I read the code of list_del(), I find LIST_POISON1 and LIST_POISON2: > > > > static inline void

What is the role of LIST_POISON1 and LIST_POISON2?

2016-03-03 Thread Navy Cheng
Hi, When I read the code of list_del(), I find LIST_POISON1 and LIST_POISON2: static inline void list_del(struct list_head *entry) { __list_del(entry->prev, entry->next); entry->next = LIST_POISON1; entry->prev = LIST_POISON2; } Why not set entry->next and

[PATCH] staging: dgnc: Remove useless and deadly judgment

2016-02-28 Thread Navy Cheng
pci_unregister_driver() should be used once dgnc module exit. It has nothing to do with dgnc_NumBoards. Remove the judgment of dgnc_NumBoards to avoid pci_unregister_driver() is not used when dgnc_NumBoards is 0. Signed-off-by: Navy Cheng <nav...@126.com> --- drivers/staging/dgnc/dgnc_dr

Re: Is there a bug in dgnc.ko?

2016-02-24 Thread Navy Cheng
On Wed, Feb 24, 2016 at 05:33:11PM +0530, Sudip Mukherjee wrote: > On Wed, Feb 24, 2016 at 5:27 PM, Navy Cheng <nav...@126.com> wrote: > > On Tue, Feb 23, 2016 at 09:43:56PM -0800, Greg KH wrote: > >> On Wed, Feb 24, 2016 at 12:57:42PM +0800, Navy Cheng wrote: > >&

Re: Is there a bug in dgnc.ko?

2016-02-24 Thread Navy Cheng
On Wed, Feb 24, 2016 at 12:37:40AM -0500, valdis.kletni...@vt.edu wrote: > On Wed, 24 Feb 2016 12:57:42 +0800, Navy Cheng said: > > Hi, > > > > My kernel version is v4.4, and I have built drivers/staging/dgnc/dgnc.ko. > > I change to *dir*/drivers/staging/dgnc and do

Re: Is there a bug in dgnc.ko?

2016-02-24 Thread Navy Cheng
On Tue, Feb 23, 2016 at 09:43:56PM -0800, Greg KH wrote: > On Wed, Feb 24, 2016 at 12:57:42PM +0800, Navy Cheng wrote: > > Hi, > > > > My kernel version is v4.4, and I have built drivers/staging/dgnc/dgnc.ko. > > I change to *dir*/drivers/staging/dgnc and do like thi

Is there a bug in dgnc.ko?

2016-02-23 Thread Navy Cheng
Hi, My kernel version is v4.4, and I have built drivers/staging/dgnc/dgnc.ko. I change to *dir*/drivers/staging/dgnc and do like this: sudo insmod ./dgnc.ko sudo lsmod | grep dgnc sudo rmmod ./dgnc sudo insmod ./dgnc.ko After I re-insmod the dgnc module, my laptop is breakdown.

Can I send a patch about 00-INDEX?

2015-09-29 Thread Navy Cheng
Hi, I read some document about schedule in Documentation/schedule/ but I find that there are 9 files in 00-INDEX (include itself), however there are 10 files in the Documentation/schedule/* . *completoin.txt* is added in 2015 and 00-INDEX is not include it. Should I send a patch like this? Thank

Re: Newbie help

2015-08-03 Thread Navy Cheng
I'm newbie too. I just want to share my experience for 3 or 4 weeks. 1. Maybe there are no entry point for kernel code. Too much knowlege are required. Do what you want and learing a subject which block you. 2. There are so many material in Documation/. 3. http://kernelnewbies.org/ is a good

How can I locate a struct's defination?

2015-08-01 Thread Navy Cheng
Hi, I use emacs and tags to read kernel source. The tags is create by make tags in the kernel source tree. When I want to find a struct's defination, something goes wrong. For example: when I find *dentry* , the first result is: struct rchan_buf { ... struct

Re: how can I find where is the macro or function deifined

2015-07-28 Thread Navy Cheng
On Tue, Jul 28, 2015 at 08:25:04PM -0400, valdis.kletni...@vt.edu wrote: On Tue, 28 Jul 2015 23:54:36 -, Gnoleba GNOGBO said: Can you give a procedure step by step please to answer please ? http://www.lmgtfy.com/?q=ctags+vim+tutorial http://www.lmgtfy.com/?q=ctags+emacs+tutorial Hi,

Re: how can I find where is the macro or function deifined

2015-07-28 Thread Navy Cheng
On Tue, Jul 28, 2015 at 06:03:16PM +0200, Ahmed Soliman wrote: Hi; when I used libc I never memorized where each function is located beyond the basics (for example I never knew if strlen is in string.h or ctype.h or strlib.h ) I just check out the functions man pages by man strlen is their

How can I send multiple unrelated patches?

2015-07-27 Thread Navy Cheng
Hi, I know multiple related patches should be sent like this: Subject: [Patch 1/10] ... Subject: [Patch 2/10] ... . . . Subject: [Patch 10/10] ... How about the unrelated patches? How can I show the order of the unrelated patches?

Do you know the bug of EXPORT_SYMBOL()

2015-07-24 Thread Navy
Hi To my understanding, EXPORT_SYMBOL() is used to export a symbol in kernel/modules. The the address of the all sysbols is in /proc/kallsyms. Only symbols exported by EXPORT_SYMBOL() is listed its CRC information in Module.symvers. So I think the CRC is the key to export a symbol. I do an

Re: Do you know the bug of EXPORT_SYMBOL()

2015-07-24 Thread Navy
On Fri, Jul 24, 2015 at 01:48:57PM +0530, Pranay Srivastava wrote: On Fri, Jul 24, 2015 at 11:19 AM, Navy nav...@126.com wrote: Hi To my understanding, EXPORT_SYMBOL() is used to export a symbol in Why this bug is not be fixed? It's a long way from 2.6 now. can you send something about

Re: what is the use of #ifndefs

2015-07-21 Thread Navy
On Tue, Jul 21, 2015 at 11:04:15AM +0530, Amit Pandey wrote: Hi Ahmed, See the comments inline #ifndef _LINUX_LIST_H // If not defined _LINUX_LIST_H macro #define _LINUX_LIST_H // then define this macro #include linuxlist.h // and include linuxlist.h header file #endif

Re: what is the use of #ifndefs

2015-07-20 Thread Navy
On Mon, Jul 20, 2015 at 12:03:07PM +0200, Ahmed Soliman wrote: currently I started reading through the linux kernel and I started reading liunx/include/linux/list.h I understood some of the functions but still I dont know what does these lines of code do #ifndef _LINUX_LIST_H #define

What can I do if I sent a wrong patch?

2015-07-19 Thread Navy
Hello, A mistake was found after I sent the patch to mentors. What Can I do to make up the fault? ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

goto???

2015-07-17 Thread Navy
Hello, Goto is recommend in linux kernel programming, but it is despised in many other situation. There are four rationable for using goto in Documentation/CodingStyle. Do you have some viewpoints about why goto or why not goto? I'm glad to get your point. Thank you.

Can I submit a patch?

2015-07-15 Thread Navy
Hi, I have done some cleanups in /drivers/staging/dgnc. I have compiled the driver and insmod/lsmod it. As I have no dgnc divice in my laptop, I don't kown whether it works well. Can I submit the patch? Thanks. ___ Kernelnewbies mailing list

Which comments is unnessary?

2015-07-14 Thread Navy
Hi, Here is a code fragment, which comments is unnessary? I think the all the comments should be remove because the comments should show What to do rather than How to do?. Am I right? / * Unit flag definitions for

Test

2015-07-13 Thread Navy
I'm a student and it's my first time to use Mailing List. I want to see if somebody can see this mail. Thank you. ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies