[PATCHv3] staging: Check for Null allocated skb in fw_download_code

2014-08-12 Thread Nicholas Krause
additon I removed the variable, rt_status as it's easier to read this function's return value with just true or false and rt status is a unneeded variable for the bool return of this function. Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 5 +++

[PATCH] staging: Check for Null return of allocated skb in fw_download_code

2014-08-12 Thread Nicholas Krause
call nic_write_byte and cause no errors with writing the nic byte(s) of private date and then call rt_status which I changed to false in the loop with my additon of checking the allocated skb. Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 1 file

[PATCH] staging: Check for Null return of allocated skb in fw_download_code

2014-08-12 Thread Nicholas Krause
call nic_write_byte and cause no errors with writing the nic byte(s) of private date and then call rt_status which I changed to false in the loop with my additon of checking the allocated skb. Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 1 file

[PATCH] staging: Check for Null return of fw_download_code

2014-08-13 Thread Nicholas Krause
-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..0f18c6d 100644 --- a/drivers/staging

[PATCH] staging: Check for Null return of fw_download_code

2014-08-13 Thread Nicholas Krause
-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..0f18c6d 100644 --- a/drivers/staging

[PATCH] staging: Check for Null return of fw_download_code

2014-08-13 Thread Nicholas Krause
-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..0f18c6d 100644 --- a/drivers/staging

[PATCH] usb: Fix switch statement in ohci-tmio.c

2014-08-14 Thread Nicholas Krause
I am fixing the bug on at the link, https://bugzilla.kernel.org/show_bug.cgi?id=79931. This bug report states that in the function, tmio_hc_stop the switch has no needed breaks. Further more this patch fixes this bug by adding the needed breaks. Signed-off-by: Nicholas Krause --- drivers/usb

[PATCH] staging wlan-ng: Add missing a blank line after declarations

2014-09-16 Thread Nicholas Krause
Fixing trivial checkpatch warnings about missing line after declarations Signed-off-by: Nicholas Krause --- drivers/staging/wlan-ng/hfa384x.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 1f2c78c..20d146b

[PATCH] staging wlan-ng: Add missing blank lines after declarations

2014-09-16 Thread Nicholas Krause
Fixing trivial checkpatch warnings about missing line after declarations Signed-off-by: Nicholas Krause --- drivers/staging/wlan-ng/hfa384x.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 1f2c78c..20d146b

[PATCH] staging wlan-ng: Add missing blank lines after declarations

2014-09-16 Thread Nicholas Krause
Fixing trivial checkpatch warnings about missing blanks lines after declarations. Signed-off-by: Nicholas Krause --- drivers/staging/wlan-ng/hfa384x.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 1f2c78c

[PATCH] staging wlan-ng: Add missing blank lines after declarations

2014-09-16 Thread Nicholas Krause
Fixing trivial checkpatch warnings about missing blank lines after declarations. Signed-off-by: Nicholas Krause --- drivers/staging/wlan-ng/hfa384x.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 1f2c78c

[PATCH] staging: Fix spacing between function name and parentheses

2014-10-10 Thread Nicholas Krause
Fixes checkpatch coding style warning about unneeded space between function name an parentheses. Signed-off-by: Nicholas Krause --- Untested drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b

[PATCH] staging: Fix checkpatch issue with brackets in rtw_ap.c

2014-10-21 Thread Nicholas Krause
Fix checkpatch error message with opening bracket of if statement, not being on the same line as a if statement in rtw_ap.c Signed-off-by: Nicholas Krause --- drivers/staging/rtl8723au/core/rtw_ap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au

[PATCH] staging: rtl8723au: Fix brace coding style issues reported by checkpatch

2014-10-26 Thread Nicholas Krause
Fix all opening and closing braces issues reported by checkpatch. Signed-off-by: Nicholas Krause --- drivers/staging/rtl8723au/core/rtw_ap.c | 138 ++-- 1 file changed, 43 insertions(+), 95 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers

[PATCH] staging: rtl8723au: Fix brace coding style issues reported by checkpatch

2014-10-28 Thread Nicholas Krause
Fix the curley braces that do not reside on the same line because this does not follow the kernel coding style and causes checkpatch.pl warnings. Signed-off-by: Nicholas Krause --- drivers/staging/rtl8723au/core/rtw_ap.c | 138 ++-- 1 file changed, 43 insertions

[PATCH] drivers: Fix typos in rt2800lib.c and oxu210hp-hcd.c

2014-11-10 Thread Nicholas Krause
Changes a typo of fimxe to fixme in the files,rtl2800lib.c and oxu210hp-hcd.c. Signed-off-by: Nicholas Krause --- drivers/net/wireless/rt2x00/rt2800lib.c | 2 +- drivers/usb/host/oxu210hp-hcd.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless

Re: Port Newer Kernel to Android Device

2015-02-22 Thread Nicholas Krause
Validis, If that is the case , would you mind telling me how to do it. Thanks, Nick On February 22, 2015 8:04:15 AM EST, valdis.kletni...@vt.edu wrote: >On Sat, 21 Feb 2015 23:52:06 -0500, nick said: >> Greetings Fellow Kernel Developers, >> I was wondering if there is any way to port a newer

Re: Port Newer Kernel to Android Device

2015-02-22 Thread Nicholas Krause
Validis, That was my concern. How much forward porting is required. Nick On February 22, 2015 12:46:04 PM EST, valdis.kletni...@vt.edu wrote: >On Sun, 22 Feb 2015 08:40:59 -0500, Nicholas Krause said: >> Validis, >> If that is the case , would you mind telling me how to do

Re: Get local CPU id

2015-03-08 Thread Nicholas Krause
On March 8, 2015 3:06:23 PM EDT, "Matwey V. Kornilov" wrote: >Hi, > >I would like to somehow obtain local CPU core ID in the interrupt >handler function. I want to see how my interruptions are distributed >among different CPU cores under different conditions. > >How should I do that? > > I didn

Re: Get local CPU id

2015-03-08 Thread Nicholas Krause
On March 8, 2015 5:49:00 PM EDT, Maxime Ripard wrote: >On Sun, Mar 08, 2015 at 10:06:23PM +0300, Matwey V. Kornilov wrote: >> Hi, >> >> I would like to somehow obtain local CPU core ID in the interrupt >> handler function. I want to see how my interruptions are distributed >> among different C

Re: Mouse driver

2015-03-08 Thread Nicholas Krause
On March 8, 2015 5:51:58 PM EDT, Maxime Ripard wrote: >Nick, > >On Fri, Mar 06, 2015 at 11:39:21PM -0500, nick wrote: >> On 2015-03-06 11:36 PM, Ronit Halder wrote: >> > This is my semester project and Thanks. >> >> Does it have to be a input driver? If you really want to impress >> your teache

Re: Get local CPU id

2015-03-08 Thread Nicholas Krause
On March 8, 2015 6:30:47 PM EDT, valdis.kletni...@vt.edu wrote: >On Sun, 08 Mar 2015 22:49:00 +0100, Maxime Ripard said: > >> On Sun, Mar 08, 2015 at 10:06:23PM +0300, Matwey V. Kornilov wrote: > >> > I would like to somehow obtain local CPU core ID in the interrupt >> > handler function. I want

Re: Get local CPU id

2015-03-08 Thread Nicholas Krause
On March 8, 2015 8:37:23 PM EDT, Anish Kumar wrote: >You can use ftrace and such. > > > That only traces file related calls and not interrupts. I stand by either using the proc/interrupts file and updating the refresh rate to 1 second if possible. There may also debugging features that you ma

Re: Mouse driver

2015-03-08 Thread Nicholas Krause
On March 8, 2015 9:12:28 PM EDT, Ronit Halder wrote: >How to get the interrupt number for any device. The easiest way is to take a look for your device's id in lsusb and see if the interrupt number is there for your device. Nick > >On Mon, Mar 9, 2015 at 3:39 AM, Nicholas

Re: Get local CPU id

2015-03-09 Thread Nicholas Krause
On March 9, 2015 2:10:57 PM EDT, valdis.kletni...@vt.edu wrote: >On Mon, 09 Mar 2015 13:42:04 -0400, Nick Krause said: >> He can just limit the dmesg output by using console_limit I believe. > >Won't fly. > >Hint: > >How high to you have to set that limit to get through boot? > >What happens if t

Re: Difference between System.map and /proc/kallsyms

2015-03-09 Thread Nicholas Krause
On March 9, 2015 10:07:28 PM EDT, Arshad Hussain wrote: > >On 08-Mar-2015, at 11:00 pm, Jamal wrote: > >> Hi.. >> >> After reading Documentation on System.map, i understood that , >whenever >> an oops happens the following addresses will be converted to its >> function name by klogd daemon

Re: Tracing allocators of virtual memory and main memory

2015-03-11 Thread Nicholas Krause
On March 11, 2015 12:07:29 PM EDT, sahil aggarwal wrote: >Hi all > >If i want to trace the allocators of virtual memory and main memory of >process using ftrace on which functions i need to enable the probe.? > >Currently i have enabled sys_mmap,sys_brk for virtual allocations and >mm_page_alloc

RE: confusing code....whats the point of this construct ?

2015-03-11 Thread Nicholas Krause
On March 11, 2015 2:37:32 PM EDT, Jeff Haran wrote: >-Original Message- >From: kernelnewbies-boun...@kernelnewbies.org >[mailto:kernelnewbies-boun...@kernelnewbies.org] On Behalf Of >valdis.kletni...@vt.edu >Sent: Wednesday, March 11, 2015 10:00 AM >To: Nicholas Mc Guire >Cc: Bj??rn Mork

Kernel Locking Question

2015-03-11 Thread Nicholas Krause
Greetings All, After learning about kernel locking and how atomic operations are good in terms of improving CPU scalability in terms of making a critical region much smaller. I was wondering of how this would improve file system scalability and reliability if implemented in file system code

Re: Get Back Into Kernel Work

2015-03-15 Thread Nicholas Krause
On March 15, 2015 5:07:12 AM EDT, "Robert P. J. Day" wrote: >On Sun, 15 Mar 2015, nick wrote: > >> Greetings All, > >> After my terrible results before and getting banned from the list >> due to these results, I am wondering if there is any work in the USB >> or Networking Subsystem I can start

Re: Get Back Into Kernel Work

2015-03-15 Thread Nicholas Krause
On March 15, 2015 11:48:57 AM EDT, Ruben Safir wrote: >On 03/15/2015 08:55 AM, Levente Kurusa wrote: >> Hello, Nick. >> >> On Sun, Mar 15, 2015 at 12:34:33AM -0400, nick wrote: >>> Greetings All, >>> After my terrible results before and getting banned from the list >due to these results, >>> I

Re: Get Back Into Kernel Work

2015-03-15 Thread Nicholas Krause
I don't remember but my interest has always been in embedded and file systems. If the kernel has work in there areas, I am swamped with school work for the next few weeks but can start helping out afterwards. Nick On March 15, 2015 12:14:07 PM EDT, Sudip Mukherjee wrote: >> I was interested

Re: Get Back Into Kernel Work

2015-03-15 Thread Nicholas Krause
fir wrote: >> On Sun, Mar 15, 2015 at 05:16:27PM +0100, Levente Kurusa wrote: >> > On Sun, Mar 15, 2015 at 12:01:27PM -0400, Nicholas Krause wrote: >> > > >> [...] >> > > I was interested in Socs in staging as I believe there are a few >> > > w

Re: Get Back Into Kernel Work

2015-03-23 Thread Nicholas Krause
On March 23, 2015 9:51:30 AM EDT, el_es wrote: >Nicholas Krause gmail.com> writes: > >> >> I have listened to peoples feedback. Am I still missing something >> as I now do >> 1. Build test all patches >> 2. Reading the code properly >> 3.T

Function Pointer Question

2015-04-01 Thread Nicholas Krause
Greetings All, I'm a little rough with how function pointers work in C. I assumed there similar to way C++ stores virtual functions internally in the vtable for virtual functions by the compiler and checks the table at runtime. Please let me know if I'm wrong in my understanding. Thanks, Ni

Re: Function Pointer Question

2015-04-02 Thread Nicholas Krause
s is not a C mailing list, take a look >at stackoverflow or a c/c++ site or book of your choice. >If you know how a pointer works, you will find it easy to understand >how >a functionpointer works. > >On 02/04/15 05:16, Nicholas Krause wrote: >> Greetings All, >> I'm

Re: Function Pointer Question

2015-04-02 Thread Nicholas Krause
On April 2, 2015 9:13:38 AM EDT, valdis.kletni...@vt.edu wrote: >On Thu, 02 Apr 2015 06:54:42 -0400, Nicholas Krause said: > >> I looked in to it and the kernel seems to be one of the few places >where this >> is done along with in line functions. Why do we need func

Help learning from my mistakes

2015-04-03 Thread Nicholas Krause
Greetings All, I am wondering if there are any stupid mistakes in my attempts at kernel programming I am still making. Thanks, Nick -- Sent from my Android device with K-9 Mail. Please excuse my brevity. ___ Kernelnewbies mailing list Kernelnewbies

Re: Help learning from my mistakes

2015-04-04 Thread Nicholas Krause
On April 3, 2015 8:13:35 PM EDT, valdis.kletni...@vt.edu wrote: >On Fri, 03 Apr 2015 17:23:04 -0400, Nicholas Krause said: >> Greetings All, >> I am wondering if there are any stupid mistakes in my attempts at >kernel programming I am still making. > >See the find|grep co

Re: Help learning from my mistakes

2015-04-04 Thread Nicholas Krause
On April 4, 2015 3:32:06 PM EDT, "Robert P. J. Day" wrote: >On Sat, 4 Apr 2015, Nicholas Krause wrote: > >> >> >> On April 3, 2015 8:13:35 PM EDT, valdis.kletni...@vt.edu wrote: >> >On Fri, 03 Apr 2015 17:23:04 -0400, Nicholas Krause said: >> &g

Re: Help learning from my mistakes

2015-04-04 Thread Nicholas Krause
On April 4, 2015 6:53:52 PM EDT, valdis.kletni...@vt.edu wrote: >On Sat, 04 Apr 2015 15:28:23 -0400, Nicholas Krause said: > >> After reading this it seems that the issue is my lack of effort not >my abilities. > >Being able to realize that the find|xargs grep solution wa

Reading kernel code

2015-04-04 Thread Nicholas Krause
Greetings All, I am interested someone testing me to make sure I understand the memory management and networking subsystems. I am pretty certain I'm not grasping certain details fully. Thanks Alot, Nick -- Sent from my Android device with K-9 Mail. Please excuse my brevity. __

Re: Reading kernel code

2015-04-05 Thread Nicholas Krause
On April 5, 2015 10:43:56 AM EDT, valdis.kletni...@vt.edu wrote: >On Sat, 04 Apr 2015 23:30:49 -0400, Nicholas Krause said: >> Greetings All, >> I am interested someone testing me > >If you have to ask, the answer is "No, you don't understand it". > >

Re: Help learning from my mistakes

2015-04-05 Thread Nicholas Krause
On April 5, 2015 8:29:47 AM EDT, Kristof Provost wrote: >On 2015-04-05 01:15:31 (-0400), valdis.kletni...@vt.edu > wrote: >> On Sat, 04 Apr 2015 19:00:42 -0400, Nicholas Krause said: >> > are now slower by up to 3 times, >> >> So what debugging did you alre

Re: Help learning from my mistakes

2015-04-05 Thread Nicholas Krause
On April 5, 2015 3:05:18 PM EDT, Kristof Provost wrote: >On 2015-04-05 14:45:28 (-0400), Nicholas Krause >wrote: >> >> >> On April 5, 2015 8:29:47 AM EDT, Kristof Provost >wrote: >> >On 2015-04-05 01:15:31 (-0400), valdis.kletni...@vt.edu >> > wr

Re: Help learning from my mistakes

2015-04-05 Thread Nicholas Krause
On April 5, 2015 3:26:09 PM EDT, Kristof Provost wrote: >On 2015-04-05 15:15:12 (-0400), Nicholas Krause >wrote: >> The only difference I can tell is the kernel version. I was >> wondering however if anyone who has more experience in the kernel >can >> give m

Re: Out of openat flag space

2015-04-07 Thread Nicholas Krause
On April 7, 2015 1:05:42 PM EDT, David Legault wrote: >Hello, > >Now that we have O_TMPFILE and O_BENEATH added to the openat flags, >there >is no space left to add more flags since the flags variable is a 32 bit >int. How does one resolve this issue and extend this? A new syscall >with a >64bit

Re: Spoon feeding

2015-04-08 Thread Nicholas Krause
ck of effort on my part or a misunderstanding that I am putting in time but my questions are too open ended. Ni5 >On Thu, Apr 9, 2015 at 8:45 AM, Nicholas Krause >wrote: > >> Greetings All, >> After thinking for a few days I have come to the conclusion that the >> comm

Spoon feeding

2015-04-08 Thread Nicholas Krause
Greetings All, After thinking for a few days I have come to the conclusion that the communities definition of spoon feeding and my are different. If someone would like to give me the community definition so there is no more misunderstandings and time wasting that would be great. Nick -- Sen

Re: Question about assembly in set bit function for x86 architecture

2015-04-19 Thread Nicholas Krause
On April 19, 2015 5:13:20 PM EDT, Anuz Pratap Singh Tomar wrote: >On Sun, Apr 19, 2015 at 9:51 PM, nick wrote: > >> Greetings All, >> I am wondering what the below code in the asm modifier does: >> static inline void set_bit(int nr, void *addr) >> { >> asm("btsl %1,%0" : "+m" (*(u32 *

Re: Module compilation error on another machine

2015-05-03 Thread Nicholas Krause
On May 3, 2015 4:35:37 AM EDT, Harsh Jain wrote: >Hi All, > >I am trying to compile simple kernel module. It gives following error. >Same >module compiles succesfully on another 64 bit ubuntu OS.Any idea what >different in environment can cause this. Both machine are ubuntu 12.04. >On >32 ubuntu

Re: running queue processes

2015-05-03 Thread Nicholas Krause
On May 2, 2015 11:20:41 AM EDT, Mustafa Hussain wrote: >Is there a way to show processes in running queue only form terminal? > > > > >___ I don't remember the exact system call f

Re: Suggested environments for kernel development

2015-05-03 Thread Nicholas Krause
On May 3, 2015 1:44:28 PM EDT, Greg KH wrote: >On Sun, May 03, 2015 at 06:11:35PM +0100, Lewis Clark wrote: >> I would really like to know how you guys do your kernel development. >> What distro do you use and whats the process? >> >> I’m very comfortable with debian, but i’ve heard it’s not t

Re: running queue processes

2015-05-03 Thread Nicholas Krause
On May 3, 2015 9:16:27 AM EDT, Ruben Safir wrote: >On 05/03/2015 08:47 AM, Nicholas Krause wrote: >> remember there being information about this topic being in the Linux >programming interface in chapters 26 through 28. Furthermore find a >copy of this book as it's a rathe