Re: Please do not generate patches purely based on checkpatch.

2015-07-26 Thread Yogesh Chaudhari
Thanks Valdis. Seems like a d'oh moment now. Never thought of scanning through the git history for checkpatch . Good tip. Thanks and regards Yogesh On Mon, Jul 27, 2015 at 1:02 AM wrote: > On Sun, 26 Jul 2015 13:05:37 +0530, Yogesh Chaudhari said: > > > However, is there a plac

Re: Please do not generate patches purely based on checkpatch.

2015-07-26 Thread Yogesh Chaudhari
On 26 July 2015 at 03:42, Greg KH wrote: > No, that would be two different things. Do the bug fix first, and then > the cleanup on a different patch. And even then, most maintainers will > not take a cleanup patch. Stick with subsystems that do take these > types of fixes if you want/like to d

Re: Code Style issue

2014-04-05 Thread Yogesh Chaudhari
The short answer: use pr_debug instead of printk. The long answer: (This is the answer I got from stackoverflow question that I had asked for similar question I was having:) Each kernel subsystem usually has its own printk format. So when you are using network subsystem, you have to use netdev_