Re: skb_clone related query

2016-01-04 Thread pavi1729
gt;> From: kernelnewbies-boun...@kernelnewbies.org [mailto:kernelnewbies- >> boun...@kernelnewbies.org] On Behalf Of pavi1729 >> Sent: Monday, December 28, 2015 6:16 AM >> To: kernelnewbies@kernelnewbies.org >> Subject: skb_clone related query >> >> Hi, >>

skb_clone related query

2015-12-28 Thread pavi1729
Hi, Just out of curisity, I was looking at Kernel 3.14, skb_clone function in f_ncm.c http://lxr.free-electrons.com/source/drivers/usb/gadget/f_ncm.c?v=3.14#L1063 QUERY : Shouldn't a kfree_skb(skb2); happen before goto err @1070 ? Is this not a memleak ? 1068 if (!skb

Re: Does the Community use Coverity ?

2015-12-17 Thread pavi1729
..@kernelnewbies.org] On Behalf Of >>pavi1729 >>Sent: Monday, December 14, 2015 11:03 PM >>To: kernelnewbies@kernelnewbies.org; linux-fsde...@vger.kernel.org; linux- >>m...@vger.kernel.org; linux-net...@vger.kernel.org >>Subject: Does the Community use Coverity ? >>

Does the Community use Coverity ?

2015-12-14 Thread pavi1729
Hi, May I know if the community uses the Coverity tool and, if yes where can I find a repo of Coverity scans of kernels and IGNORE LIST; cause there obviously would be false positives. Cheers, Pavi ___ Kernelnewbies mailing list Kernelnewbies@kernelne

Query on freeing of new_fdt->open_fds inside src/fs/file.c

2015-12-11 Thread pavi1729
Hi, I am unable to understand how new_fdt->open_fds can be freed in __free_fdtable when its an unsigned long in files_struct ? Details: FUNCTION: dup_fd http://lxr.free-electrons.com/source/fs/file.c#L261 LINE : 282 : new_fdt->open_fds = newf->open_fds_init; files_struct : http://lxr.fr

Query on ubifs_assert

2015-07-01 Thread pavi1729
Hi, FILE: fs/ubifs/misc.h : FUNCTION : ubifs_compr_present "ubifs_compr_present" function has "ubifs_assert" which checks for the valid compression value and does a stack_dump if not. Could there be a case where the "compr_type" is corrupt; if yes, then does a stack_dump suffice? Thus if comp