Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices

2021-04-29 Thread bkkarthik
On 21/04/28 02:30PM, Jaroslav Kysela wrote: > Dne 28. 04. 21 v 14:21 Leon Romanovsky napsal(a): > > On Wed, Apr 28, 2021 at 02:04:49PM +0200, Jaroslav Kysela wrote: > >> Dne 26. 04. 21 v 19:50 bkkarthik napsal(a): > >>> On 21/04/26 08:04AM, Leon Romanovsky wrote: > On Sun, Apr 25, 2021 at 01:1

Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices

2021-04-29 Thread Jaroslav Kysela
Dne 28. 04. 21 v 14:21 Leon Romanovsky napsal(a): > On Wed, Apr 28, 2021 at 02:04:49PM +0200, Jaroslav Kysela wrote: >> Dne 26. 04. 21 v 19:50 bkkarthik napsal(a): >>> On 21/04/26 08:04AM, Leon Romanovsky wrote: On Sun, Apr 25, 2021 at 01:13:01AM +0530, Anupama K Patil wrote: > isapnp_proc

Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices

2021-04-29 Thread bkkarthik
On 21/04/28 03:21PM, Leon Romanovsky wrote: > On Wed, Apr 28, 2021 at 02:04:49PM +0200, Jaroslav Kysela wrote: > > Dne 26. 04. 21 v 19:50 bkkarthik napsal(a): > > > On 21/04/26 08:04AM, Leon Romanovsky wrote: > > >> On Sun, Apr 25, 2021 at 01:13:01AM +0530, Anupama K Patil wrote: > > >>> isapnp_pro

Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices

2021-04-29 Thread Jaroslav Kysela
Dne 26. 04. 21 v 19:50 bkkarthik napsal(a): > On 21/04/26 08:04AM, Leon Romanovsky wrote: >> On Sun, Apr 25, 2021 at 01:13:01AM +0530, Anupama K Patil wrote: >>> isapnp_proc_init() does not look at the return value from >>> isapnp_proc_attach_device(). Check for this return value in >>> isapnp_proc

Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices

2021-04-29 Thread bkkarthik
On 21/04/26 08:04AM, Leon Romanovsky wrote: > On Sun, Apr 25, 2021 at 01:13:01AM +0530, Anupama K Patil wrote: > > isapnp_proc_init() does not look at the return value from > > isapnp_proc_attach_device(). Check for this return value in > > isapnp_proc_detach_device(). > > > > Cleanup in isapnp_pr

Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices

2021-04-29 Thread Leon Romanovsky
On Thu, Apr 29, 2021 at 12:31:13AM -0400, Valdis Klētnieks wrote: > On Tue, 27 Apr 2021 07:26:27 +0300, Leon Romanovsky said: > > On Mon, Apr 26, 2021 at 11:20:32PM +0530, bkkarthik wrote: > > > These were only intended for a clean-up job, the idea of this function > > > came from how PCI handles

Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices

2021-04-28 Thread Valdis Klētnieks
On Tue, 27 Apr 2021 07:26:27 +0300, Leon Romanovsky said: > On Mon, Apr 26, 2021 at 11:20:32PM +0530, bkkarthik wrote: > > These were only intended for a clean-up job, the idea of this function came > > from how PCI handles procfs. > > Maybe those should be changed? > > Probably, the CONFIG_PROC_F

Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices

2021-04-28 Thread Leon Romanovsky
On Wed, Apr 28, 2021 at 02:04:49PM +0200, Jaroslav Kysela wrote: > Dne 26. 04. 21 v 19:50 bkkarthik napsal(a): > > On 21/04/26 08:04AM, Leon Romanovsky wrote: > >> On Sun, Apr 25, 2021 at 01:13:01AM +0530, Anupama K Patil wrote: > >>> isapnp_proc_init() does not look at the return value from > >>>

Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices

2021-04-26 Thread Leon Romanovsky
On Mon, Apr 26, 2021 at 11:20:32PM +0530, bkkarthik wrote: > On 21/04/26 08:04AM, Leon Romanovsky wrote: > > On Sun, Apr 25, 2021 at 01:13:01AM +0530, Anupama K Patil wrote: > > > isapnp_proc_init() does not look at the return value from > > > isapnp_proc_attach_device(). Check for this return valu

Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices

2021-04-26 Thread Barnabás Pőcze
Hi 2021. április 24., szombat 21:43 keltezéssel, Anupama K Patil írta: > isapnp_proc_init() does not look at the return value from > isapnp_proc_attach_device(). Check for this return value in > isapnp_proc_detach_device(). > > Cleanup in isapnp_proc_detach_device and > isapnp_proc_detach_bus()

Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices

2021-04-25 Thread Leon Romanovsky
On Sun, Apr 25, 2021 at 01:13:01AM +0530, Anupama K Patil wrote: > isapnp_proc_init() does not look at the return value from > isapnp_proc_attach_device(). Check for this return value in > isapnp_proc_detach_device(). > > Cleanup in isapnp_proc_detach_device and > isapnp_proc_detach_bus() for clea

[PATCH] drivers: pnp: proc.c: Handle errors while attaching devices

2021-04-25 Thread Anupama K Patil
isapnp_proc_init() does not look at the return value from isapnp_proc_attach_device(). Check for this return value in isapnp_proc_detach_device(). Cleanup in isapnp_proc_detach_device and isapnp_proc_detach_bus() for cleanup. Changed sprintf() to the kernel-space function scnprintf() as it return

Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices

2021-04-24 Thread Valdis Klētnieks
On Sun, 25 Apr 2021 01:13:01 +0530, Anupama K Patil said: > Changed sprintf() to the kernel-space function scnprintf() as it returns > the actual number of bytes written. > + if (!bus->procdir) { > + scnprintf(name, 16, "%02x", bus->number); > + scnprintf(name, 16, "%02x", dev