Re: [PATCH 0/7] security: apparmor: apparmorfs.c Checkpatch mods

2016-11-26 Thread Joel Fernandes
On Nov 26, 2016 1:28 PM, "Bjørn Mork" wrote: > > Greg KH writes: > > On Sat, Nov 26, 2016 at 01:02:14PM -0500, Walt Feasel wrote: > > > >> So kernelnewbies is not to be used to learn about how to fix > >> checkpatch type warning? > > > > Maybe, but really, if you have a well-formed patch, just se

Re: [PATCH 0/7] security: apparmor: apparmorfs.c Checkpatch mods

2016-11-26 Thread Bjørn Mork
Greg KH writes: > On Sat, Nov 26, 2016 at 01:02:14PM -0500, Walt Feasel wrote: > >> So kernelnewbies is not to be used to learn about how to fix >> checkpatch type warning? > > Maybe, but really, if you have a well-formed patch, just send it to the > correct maintainers, it's up to them to accept

Re: [PATCH 0/7] security: apparmor: apparmorfs.c Checkpatch mods

2016-11-26 Thread Greg KH
On Sat, Nov 26, 2016 at 01:02:14PM -0500, Walt Feasel wrote: > On Sat, Nov 26, 2016 at 06:19:22PM +0100, Greg KH wrote: > > On Sat, Nov 26, 2016 at 11:56:17AM -0500, Walt Feasel wrote: > > > On Sat, Nov 26, 2016 at 12:05:50PM +0100, Greg KH wrote: > > > > On Sat, Nov 26, 2016 at 03:43:18AM -0500, W

Re: [PATCH 0/7] security: apparmor: apparmorfs.c Checkpatch mods

2016-11-26 Thread Walt Feasel
On Sat, Nov 26, 2016 at 06:19:22PM +0100, Greg KH wrote: > On Sat, Nov 26, 2016 at 11:56:17AM -0500, Walt Feasel wrote: > > On Sat, Nov 26, 2016 at 12:05:50PM +0100, Greg KH wrote: > > > On Sat, Nov 26, 2016 at 03:43:18AM -0500, Walt Feasel wrote: > > > > Make checkpatch modifications to include: >

Re: [PATCH 0/7] security: apparmor: apparmorfs.c Checkpatch mods

2016-11-26 Thread Greg KH
On Sat, Nov 26, 2016 at 11:56:17AM -0500, Walt Feasel wrote: > On Sat, Nov 26, 2016 at 12:05:50PM +0100, Greg KH wrote: > > On Sat, Nov 26, 2016 at 03:43:18AM -0500, Walt Feasel wrote: > > > Make checkpatch modifications to include: > > > > > > Multiple blank lines > > > Blank line after declarati

Re: [PATCH 0/7] security: apparmor: apparmorfs.c Checkpatch mods

2016-11-26 Thread Walt Feasel
On Sat, Nov 26, 2016 at 12:05:50PM +0100, Greg KH wrote: > On Sat, Nov 26, 2016 at 03:43:18AM -0500, Walt Feasel wrote: > > Make checkpatch modifications to include: > > > > Multiple blank lines > > Blank line after declarations > > Space after cast > > WARN_ON vs BUG_ON > > Align parenthesis > >

Re: [PATCH 0/7] security: apparmor: apparmorfs.c Checkpatch mods

2016-11-26 Thread Greg KH
On Sat, Nov 26, 2016 at 03:43:18AM -0500, Walt Feasel wrote: > Make checkpatch modifications to include: > > Multiple blank lines > Blank line after declarations > Space after cast > WARN_ON vs BUG_ON > Align parenthesis > Comparison to NULL > Line continuations > > Walt Feasel (7): > security:

[PATCH 0/7] security: apparmor: apparmorfs.c Checkpatch mods

2016-11-26 Thread Walt Feasel
Make checkpatch modifications to include: Multiple blank lines Blank line after declarations Space after cast WARN_ON vs BUG_ON Align parenthesis Comparison to NULL Line continuations Walt Feasel (7): security: apparmor: apparmorfs.c Multiple blank lines security: apparmor: apparmorfs.c Blank