Re: [PATCH 1/1] staging: erofs: Add function comment for erofs/super.c

2019-03-13 Thread Gao Xiang
Hi Valdis, On 2019/3/13 14:41, valdis.kletni...@vt.edu wrote: > On Wed, 13 Mar 2019 08:48:26 +0800, Gao Xiang said: > (Reversing order of comments) >> "Release slab Memory" is not a very useful description for this function. > > Agreed. > >> i_callback is used to free inode structure and other

Re: [PATCH 1/1] staging: erofs: Add function comment for erofs/super.c

2019-03-13 Thread Gao Xiang
Hi Arshad, Thanks for your patch :) Apart from the comment from Greg, please check my following ideas... On 2019/3/13 2:03, arshad hussain wrote: > Re-sending. Previous patch I put in very old kernel-newbies address. > > Subject: [PATCH 1/1] staging: erofs: Add function comment for

Re: [PATCH 1/1] staging: erofs: Add function comment for erofs/super.c

2019-03-12 Thread valdis . kletnieks
On Wed, 13 Mar 2019 08:48:26 +0800, Gao Xiang said: (Reversing order of comments) > "Release slab Memory" is not a very useful description for this function. Agreed. > i_callback is used to free inode structure and other memory related to this > inode However, that's not a bad description at a

Re: [PATCH 1/1] staging: erofs: Add function comment for erofs/super.c

2019-03-12 Thread Greg KH
On Tue, Mar 12, 2019 at 11:33:47PM +0530, arshad hussain wrote: > Re-sending. Previous patch I put in very old kernel-newbies address. > > Subject: [PATCH 1/1] staging: erofs: Add function comment for > erofs/super.c You can't have a "Subject" line in the middle of t

Re: [PATCH 1/1] staging: erofs: Add function comment for erofs/super.c

2019-03-12 Thread valdis . kletnieks
On Tue, 12 Mar 2019 23:33:47 +0530, arshad hussain said: > Re-sending. Previous patch I put in very old kernel-newbies address. > > Subject: [PATCH 1/1] staging: erofs: Add function comment for > erofs/super.c > > This patch adds functions comment for file erofs/super.c

[PATCH 1/1] staging: erofs: Add function comment for erofs/super.c

2019-03-12 Thread arshad hussain
Re-sending. Previous patch I put in very old kernel-newbies address. Subject: [PATCH 1/1] staging: erofs: Add function comment for erofs/super.c This patch adds functions comment for file erofs/super.c in sphinx format. Signed-off-by: Arshad Hussain --- drivers/staging/erofs/super.c | 133