Re: Etiquette of submitting patches for fixing coding style.

2012-10-28 Thread Eugene Voronkov
On Sat, Oct 27, 2012 at 10:09 AM, Robert P. J. Day rpj...@crashcourse.cawrote: On Fri, 26 Oct 2012, Greg Freemyer wrote: fyi: Robert Day just asked for help cleaning up the Doc Book stuff. Doc Book pull comments out of the .c files and creates documentation. To clean it up, patches to

Re: Etiquette of submitting patches for fixing coding style.

2012-10-27 Thread Robert P. J. Day
On Fri, 26 Oct 2012, Greg Freemyer wrote: fyi: Robert Day just asked for help cleaning up the Doc Book stuff. Doc Book pull comments out of the .c files and creates documentation. To clean it up, patches to the source files will be required. These are more likely to be accepted. So you

Re: Etiquette of submitting patches for fixing coding style.

2012-10-26 Thread Sumeet pawnikar
On Fri, Oct 26, 2012 at 1:57 AM, Eugene Voronkov eugene.voron...@gmail.comwrote: I watched Kroah-Hartman's video[1] on submitting patches where he walks through the process of fixing coding style. I feel like this would be a good way for me to jump into the process but I need more

Re: Etiquette of submitting patches for fixing coding style.

2012-10-26 Thread Eugene Voronkov
On Fri, Oct 26, 2012 at 5:38 AM, Sumeet pawnikar sumeet4li...@gmail.comwrote: On Fri, Oct 26, 2012 at 1:57 AM, Eugene Voronkov eugene.voron...@gmail.com wrote: I watched Kroah-Hartman's video[1] on submitting patches where he walks through the process of fixing coding style. I feel like

Re: Etiquette of submitting patches for fixing coding style.

2012-10-26 Thread Graeme Russ
Hi Eugene, On Oct 27, 2012 7:18 AM, Eugene Voronkov eugene.voron...@gmail.com wrote: On Fri, Oct 26, 2012 at 5:38 AM, Sumeet pawnikar sumeet4li...@gmail.com wrote: On Fri, Oct 26, 2012 at 1:57 AM, Eugene Voronkov eugene.voron...@gmail.com wrote: I watched Kroah-Hartman's video[1] on

Re: Etiquette of submitting patches for fixing coding style.

2012-10-26 Thread Greg Freemyer
On Thu, Oct 25, 2012 at 4:27 PM, Eugene Voronkov eugene.voron...@gmail.com wrote: I watched Kroah-Hartman's video[1] on submitting patches where he walks through the process of fixing coding style. I feel like this would be a good way for me to jump into the process but I need more

Re: Etiquette of submitting patches for fixing coding style.

2012-10-26 Thread Eugene Voronkov
On Fri, Oct 26, 2012 at 5:45 PM, Greg Freemyer greg.freem...@gmail.comwrote: On Thu, Oct 25, 2012 at 4:27 PM, Eugene Voronkov eugene.voron...@gmail.com wrote: I watched Kroah-Hartman's video[1] on submitting patches where he walks through the process of fixing coding style. I feel like

Etiquette of submitting patches for fixing coding style.

2012-10-25 Thread Eugene Voronkov
I watched Kroah-Hartman's video[1] on submitting patches where he walks through the process of fixing coding style. I feel like this would be a good way for me to jump into the process but I need more information. At what point do code style patches stop being more trouble then they're worth to