Re: Question regarding strange-looking code in drivers/isdn/i4l/isdn_ppp.c

2015-02-02 Thread anish singh
On Mon, Feb 2, 2015 at 11:26 AM, Bas Peters wrote: > Hi, > > I was checking some code in drivers/isdn/isdn_pp and came across the > following: > > case PPP_VJC_COMP: > if (is->debug & 0x20) > printk(KERN_DEBUG "isdn_ppp: VJC_COMP\n"); >

Re: Question regarding strange-looking code in drivers/isdn/i4l/isdn_ppp.c

2015-02-02 Thread Henry Hallam
On Mon, Feb 2, 2015 at 11:35 AM, Greg KH wrote: > The braces afterward is for the new variable scope, it's odd looking > yes, but correct code and formatting. Specifically, without the braces there'd be a compile error at the declaration of the pkt_len and skb_old variables. Henry _

Re: Question regarding strange-looking code in drivers/isdn/i4l/isdn_ppp.c

2015-02-02 Thread Greg KH
On Mon, Feb 02, 2015 at 08:26:26PM +0100, Bas Peters wrote: > Hi, > > I was checking some code in drivers/isdn/isdn_pp and came across the > following: > > case PPP_VJC_COMP: > if (is->debug & 0x20) > printk(KERN_DEBUG "isdn_ppp: VJC_COMP\n"); >

Re: Question regarding strange-looking code in drivers/isdn/i4l/isdn_ppp.c

2015-02-02 Thread Bas Peters
ies.org] On Behalf Of Bas Peters >> Sent: Monday, February 02, 2015 11:26 AM >> To: kernelnewbies@kernelnewbies.org; i...@linux-pingi.de >> Subject: Question regarding strange-looking code in >> drivers/isdn/i4l/isdn_ppp.c >> >> Hi, >> >> I

RE: Question regarding strange-looking code in drivers/isdn/i4l/isdn_ppp.c

2015-02-02 Thread Jeff Haran
regarding strange-looking code in > drivers/isdn/i4l/isdn_ppp.c > > Hi, > > I was checking some code in drivers/isdn/isdn_pp and came across the > following: > > case PPP_VJC_COMP: > if (is->debug & 0x20) >

Question regarding strange-looking code in drivers/isdn/i4l/isdn_ppp.c

2015-02-02 Thread Bas Peters
Hi, I was checking some code in drivers/isdn/isdn_pp and came across the following: case PPP_VJC_COMP: if (is->debug & 0x20) printk(KERN_DEBUG "isdn_ppp: VJC_COMP\n"); { struct sk_buff *skb_old = skb;