Re: Submitted a first patch and no reply

2015-01-08 Thread shirish gajera
Hi, Actually on the website it's return that Pick a warning, and try to fix it. For your first patch, only pick one warning. In the future you can group multiple changes into one patch, but only if you follow the PatchPhilosophy http://kernelnewbies.org/PatchPhilosophy of breaking each patch

Re: Submitted a first patch and no reply

2015-01-08 Thread Joe Perches
On Thu, 2015-01-08 at 15:49 -0500, valdis.kletni...@vt.edu wrote: On Thu, 08 Jan 2015 12:37:15 -0800, shirish gajera said: That's hwy I just fix one warning. That means don't fix a warning about indentation *and* a warning about trailing blanks in the same patch. Also, if you're

Re: Submitted a first patch and no reply

2015-01-08 Thread Valdis . Kletnieks
On Thu, 08 Jan 2015 12:37:15 -0800, shirish gajera said: That's hwy I just fix one warning. That means don't fix a warning about indentation *and* a warning about trailing blanks in the same patch. Also, if you're fixing a style issue, you should actually *review* the code, and make sure you

Re: Submitted a first patch and no reply

2015-01-08 Thread shirish gajera
I will make necessary and try to re- submit the patch. On Thu, Jan 8, 2015 at 1:14 PM, Joe Perches j...@perches.com wrote: On Thu, 2015-01-08 at 15:49 -0500, valdis.kletni...@vt.edu wrote: On Thu, 08 Jan 2015 12:37:15 -0800, shirish gajera said: That's hwy I just fix one warning.

Submitted a first patch and no reply

2015-01-08 Thread shirish gajera
Hi, I have submitted my first patch on 12/30/2014 and I have not received any reply for next step like error or merge ect. I send the email to person that get_maintainer.pl script tells me to send. Please guide whom should I reached for this. Below is the email - This patch fixes the

Re: Submitted a first patch and no reply

2015-01-08 Thread Valdis . Kletnieks
On Thu, 08 Jan 2015 12:00:07 -0800, shirish gajera said: WARNING: Single statement macros should not use a do {} while (0) loop I have added single statement in curly braces, because it was giving me WARNING: macros should not use a trailing semicolon. Signed-off-by: Shirish Gajera