Re: driver todo's

2017-02-14 Thread Anuz Pratap Singh Tomar
On Sat, Feb 11, 2017 at 8:04 AM, srishti sharma wrote: > It was because of the documentation not being proper , as per the mail > sent by your bot , right ? I will fix those errors and re-send it . > > Thanks > > Regards > > Kernel-janitor is the right place to post minor fixes. They send a lot o

Re: driver todo's

2017-02-11 Thread srishti sharma
It was because of the documentation not being proper , as per the mail sent by your bot , right ? I will fix those errors and re-send it . Thanks Regards Srishti On Sat, Feb 11, 2017 at 12:51 PM, Greg KH wrote: > On Sat, Feb 11, 2017 at 11:50:19AM +0530, srishti sharma wrote: >> Hey , I have p

Re: driver todo's

2017-02-10 Thread Greg KH
On Sat, Feb 11, 2017 at 11:50:19AM +0530, srishti sharma wrote: > Hey , I have posted my first patch . Will I be notified if it gets accepted ? Yes, or if it rejected, like I just did :) thanks, greg k-h ___ Kernelnewbies mailing list Kernelnewbies@ke

Re: driver todo's

2017-02-10 Thread srishti sharma
Hey , I have posted my first patch . Will I be notified if it gets accepted ? Regards Srishti On Sat, Feb 4, 2017 at 1:50 PM, Greg KH wrote: > On Sat, Feb 04, 2017 at 04:20:53AM +0530, srishti sharma wrote: >> I got this warning for a structure to be defined as constant , I have >> fixed it by

Re: driver todo's

2017-02-04 Thread Greg KH
On Sat, Feb 04, 2017 at 04:20:53AM +0530, srishti sharma wrote: > I got this warning for a structure to be defined as constant , I have > fixed it by adding const , now this variable is not being used in this > file , so I was wondering if I should fix such warnings ? What if this > variable is use

Re: driver todo's

2017-02-03 Thread srishti sharma
I got this warning for a structure to be defined as constant , I have fixed it by adding const , now this variable is not being used in this file , so I was wondering if I should fix such warnings ? What if this variable is used in some other file and the developer didn't want it to be constant des

Re: driver todo's

2017-02-03 Thread Greg KH
On Sat, Feb 04, 2017 at 03:36:02AM +0530, srishti sharma wrote: > when driver has checkpatch cleanups in it's todo , does that also > including fixing warnings , should one try to fix them ? Why wouldn't you do so? ___ Kernelnewbies mailing list Kerneln

Staging Driver TODO's

2017-02-03 Thread srishti sharma
If the todo's mention checkpatch cleanups , does it mean the warnings also need to be fixed ? Should one try to fix them OR only the errors ? Regards ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman

driver todo's

2017-02-03 Thread srishti sharma
when driver has checkpatch cleanups in it's todo , does that also including fixing warnings , should one try to fix them ? ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies