Re: end_request() deprecated, which one should be used ?

2008-09-02 Thread Jens Axboe
On Tue, Sep 02 2008, Thomas Petazzoni wrote: > Le Tue, 2 Sep 2008 10:13:54 +0200, > Jens Axboe <[EMAIL PROTECTED]> a écrit : > > > They do act in the same way now, but that is because > > end_that_request_last() automatically detects whether a request needs > > to be dequeued or not. > > Ok. > >

Re: end_request() deprecated, which one should be used ?

2008-09-02 Thread Thomas Petazzoni
Le Tue, 2 Sep 2008 10:13:54 +0200, Jens Axboe <[EMAIL PROTECTED]> a écrit : > They do act in the same way now, but that is because > end_that_request_last() automatically detects whether a request needs > to be dequeued or not. Ok. > end_request() uses hard_cur_sectors, so it does indeed only ac

Re: end_request() deprecated, which one should be used ?

2008-09-02 Thread Jens Axboe
On Tue, Sep 02 2008, Thomas Petazzoni wrote: > Hi Jens, > > Le Tue, 2 Sep 2008 08:46:49 +0200, > Jens Axboe <[EMAIL PROTECTED]> a écrit : > > > end_request() is deprecated, and only that one. You can use > > end_dequeued_request() or end_queued_request() to completely end a > > dequeued or queued

Re: end_request() deprecated, which one should be used ?

2008-09-02 Thread Thomas Petazzoni
Hi Jens, Le Tue, 2 Sep 2008 08:46:49 +0200, Jens Axboe <[EMAIL PROTECTED]> a écrit : > end_request() is deprecated, and only that one. You can use > end_dequeued_request() or end_queued_request() to completely end a > dequeued or queued request. Or you can use blk_end_request() to end > nr_bytes

Re: end_request() deprecated, which one should be used ?

2008-09-01 Thread Jens Axboe
On Mon, Sep 01 2008, Thomas Petazzoni wrote: > Hi, > > The comment at the top of end_request() says: > > * This is a remnant of how older block drivers handled IO completions. > * Modern drivers typically end IO on the full request in one go, unless > * they have a residual value t

end_request() deprecated, which one should be used ?

2008-09-01 Thread Thomas Petazzoni
Hi, The comment at the top of end_request() says: * This is a remnant of how older block drivers handled IO completions. * Modern drivers typically end IO on the full request in one go, unless * they have a residual value to account for. For that case this function * isn't rea