Re: [PATCH -v2 6/8] kexec jump: fix for lockdep

2008-08-11 Thread Peter Zijlstra
On Mon, 2008-08-11 at 08:59 +0800, Huang Ying wrote: On Fri, 2008-08-08 at 12:13 +0200, Peter Zijlstra wrote: On Fri, 2008-08-08 at 14:52 +0800, Huang Ying wrote: Replace local_irq_disable() with raw_local_irq_disable() to prevent lockdep complain. Uhhm, please provide more information

Re: [PATCH -v2 6/8] kexec jump: fix for lockdep

2008-08-11 Thread Huang Ying
On Mon, 2008-08-11 at 08:09 +0200, Peter Zijlstra wrote: On Mon, 2008-08-11 at 08:59 +0800, Huang Ying wrote: On Fri, 2008-08-08 at 12:13 +0200, Peter Zijlstra wrote: On Fri, 2008-08-08 at 14:52 +0800, Huang Ying wrote: Replace local_irq_disable() with raw_local_irq_disable() to prevent

Re: [PATCH -v2 7/8] kexec jump: ftrace_enabled_save/restore

2008-08-11 Thread Steven Rostedt
On Mon, 11 Aug 2008, Huang Ying wrote: Hi, Steven, On Fri, 2008-08-08 at 10:30 -0400, Steven Rostedt wrote: [...] The only problem with this approach is what happens if the user changes the enabled in between these two calls. This would make ftrace inconsistent. I have a patch

Re: [PATCH -v2 7/8] kexec jump: ftrace_enabled_save/restore

2008-08-11 Thread Vivek Goyal
On Mon, Aug 11, 2008 at 09:22:21AM +0800, Huang Ying wrote: Hi, Steven, On Fri, 2008-08-08 at 10:30 -0400, Steven Rostedt wrote: [...] The only problem with this approach is what happens if the user changes the enabled in between these two calls. This would make ftrace inconsistent.

[patch] kexec and kdump documentation for xen

2008-08-11 Thread Simon Horman
Add guide to using the kexec and kdump facility in xen. Signed-off-by: Simon Horman [EMAIL PROTECTED] --- I the work on this document using an ia64 machine and qemu emulating x86_32. I am yet to verify it on x86_32 hardware or x86_64. Index: xen-unstable.hg/docs/misc/kexec_and_kdump.txt

Re: [PATCH -v2 7/8] kexec jump: ftrace_enabled_save/restore

2008-08-11 Thread Huang Ying
Hi, Vivek, On Mon, 2008-08-11 at 09:51 -0400, Vivek Goyal wrote: [...] So you want to use a non-locked version from optimization point of view? So that we don't end up taking and release a lock? Not from optimization point of view. machine_kexec() may be called from crash_kexec(), where it is

Re: [LTP] [RFC] [KDUMP] [PROPOSED WORK] kdump on Xen hypervisor and guests, more tests for utilities, like makedumpfile, mkdumprd, kexec etc

2008-08-11 Thread Cai Qian
Hi Subrata, From: Subrata Modak [EMAIL PROTECTED] Subject: Re: [LTP] [RFC] [KDUMP] [PROPOSED WORK] kdump on Xen hypervisor and guests, more tests for utilities, like makedumpfile, mkdumprd, kexec etc Date: Mon, 11 Aug 2008 19:02:47 +0530 Cai, Any headway in this front ? I have all test

[PATCH -v3 1/7] kexec jump: clean up #ifdef and comments

2008-08-11 Thread Huang Ying
Move if (kexec_image-preserve_context) { ... } into #ifdef CONFIG_KEXEC_JUMP to make code looks cleaner. Fix no longer correct comments of kernel_kexec(). Signed-off-by: Huang Ying [EMAIL PROTECTED] Acked-by: Vivek Goyal [EMAIL PROTECTED] --- kernel/kexec.c | 17 - 1 file

[PATCH -v3 7/7] kexec jump: fix for ftrace

2008-08-11 Thread Huang Ying
Ftrace depends on some processor state that we destroyed during kexec and restored by restore_processor_state(). So save_processor_state() and restore_processor_state() are moved into machine_kexec() and ftrace is restored after restore_processor_state(). Signed-off-by: Huang Ying [EMAIL

[PATCH -v3 0/7] kexec jump: fixes for 2.6.27

2008-08-11 Thread Huang Ying
Hi, This patchset fixes some issues of kexec jump for 2.6.27. It is based on 2.6.27-rc2 and has been tested on i386 platform. ChangeLog: v3: - Merge added file vmlinux_check_32.lds.S into vmlinux_32.lds.S. - Add comments about lock for ftrace code. v2: - Check control code size at link

[PATCH -v3 6/7] kexec jump: __ftrace_enabled_save/restore

2008-08-11 Thread Huang Ying
Add __ftrace_enabled_save/restore, used to disable ftrace for a while. Now, this is used by kexec jump, which need a version without lock, for general situation, a locked version should be used. Signed-off-by: Huang Ying [EMAIL PROTECTED] --- include/linux/ftrace.h | 21 +

[PATCH -v3 2/7] kexec jump: rename KEXEC_CONTROL_CODE_SIZE to KEXEC_CONTROL_PAGE_SIZE

2008-08-11 Thread Huang Ying
Rename KEXEC_CONTROL_CODE_SIZE to KEXEC_CONTROL_PAGE_SIZE, because control page is used for not only code on some platform. For example in kexec jump, it is used for data and stack too. Signed-off-by: Huang Ying [EMAIL PROTECTED] --- arch/arm/include/asm/kexec.h |2 +-

[PATCH -v3 4/7] kexec jump: remove duplication of kexec_restart_prepare()

2008-08-11 Thread Huang Ying
Call kernel_restart_prepare() in kernel_kexec() instead of duplicating the code. Signed-off-by: Huang Ying [EMAIL PROTECTED] Acked-by: Pavel Machek [EMAIL PROTECTED] Acked-by: Vivek Goyal [EMAIL PROTECTED] --- include/linux/reboot.h |1 + kernel/kexec.c |6 +- kernel/sys.c

[PATCH -v3 5/7] kexec jump: in sync with hibernation implementation

2008-08-11 Thread Huang Ying
Add device_pm_lock() and device_pm_unlock() in kernel_kexec() in sync with current hibernation implementation. Signed-off-by: Huang Ying [EMAIL PROTECTED] --- kernel/kexec.c |2 ++ 1 file changed, 2 insertions(+) --- a/kernel/kexec.c +++ b/kernel/kexec.c @@ -1457,6 +1457,7 @@ int

[PATCH -v3 3/7] kexec jump: check code size in control page

2008-08-11 Thread Huang Ying
Kexec/Kexec-jump require code size in control page is less than PAGE_SIZE/2. This patch add link-time checking for this. ASSERT() of ld link script is used as the link-time checking mechanism. Signed-off-by: Huang Ying [EMAIL PROTECTED] --- arch/x86/kernel/machine_kexec_32.c |2 +-