[PATCH] kexec: Fix omitting offset in extended crashkernel syntax

2009-07-13 Thread Hidetoshi Seto
Setting "crashkernel=512M-2G:64M,2G-:128M" does not work but it turns to work if it has a trailing-whitespace, like "crashkernel=512M-2G:64M,2G-:128M ". It was because of a bug in the parser, running over the cmdline. This patch adds a check of the termination. Reported-by: Jin Dongming Signe

Re: [PATCH-v2] kdump: Enable kdump if 2nd-kernel is loaded.

2009-07-13 Thread Hidetoshi Seto
Eric W. Biederman wrote: > The Documentation for sysrq-c certainly needs to be updated. No doubt about it. > If I am doing development on a system I like oops's. All of the > information and nothing goes down. I can get at /proc/kcore etc. > > In a setting where I can't be Johnny on the spot a

Re: [PATCH-v2] kdump: Enable kdump if 2nd-kernel is loaded.

2009-07-13 Thread Eric W. Biederman
"Ken'ichi Ohmichi" writes: > Hi, > > This patch is a new version by Seto-san's comment. > > > Changelog since v1: > * Remove the check code other than kexec_crash_image from kexec_should_crash() > because a kexec cannot crash if there is no image. > > > This patch enables a kdump if 2nd-kernel

Re: [PATCH-v2] kdump: Enable kdump if 2nd-kernel is loaded.

2009-07-13 Thread Hidetoshi Seto
Ken'ichi Ohmichi wrote: > Signed-off-by: Ken'ichi Ohmichi > Acked-by: Simon Horman > --- > --- a/kernel/kexec.c 2009-07-08 12:30:26.0 +0900 > +++ b/kernel/kexec.c 2009-07-13 13:49:03.0 +0900 > @@ -57,7 +57,7 @@ struct resource crashk_res = { > > int kexec_should_crash(struct

[PATCH-v2] kdump: Enable kdump if 2nd-kernel is loaded.

2009-07-13 Thread Ken'ichi Ohmichi
Hi, This patch is a new version by Seto-san's comment. Changelog since v1: * Remove the check code other than kexec_crash_image from kexec_should_crash() because a kexec cannot crash if there is no image. This patch enables a kdump if 2nd-kernel is loaded. (The patch is based on linux-2.6.3