Re: [PATCH] makedumpfile: fix off-by-one bug in page_to_pfn()

2011-11-23 Thread Atsushi Kumagai
Hi Wen, Thank you for the patch. I will check it. Thanks Kumagai On Wed, 23 Nov 2011 13:53:51 +0800 Wen Congyang wrote: > The pfn region in a mmd is [mmd->pfn_start, mmd->pfn_end). > So the max index should be mmd->pfn_end - mmd->pfn_start -1. > If index >=(not >) mmd->pfn_end - mmd->pfn_sta

Re: [PATCH v2] kdump: crashk_res init check for /sys/kernel/kexec_crash_size

2011-11-23 Thread Simon Horman
On Wed, Nov 23, 2011 at 02:18:03PM +0100, Michael Holzheu wrote: > From: Michael Holzheu > > Currently it is possible to set the crash_size via the sysfs > /sys/kernel/kexec_crash_size even if no crash kernel memory has > been defined with the "crashkernel" parameter. In this case > "crashk_res"

Re: [PATCH] percpu: add comment to per_cpu_ptr_to_phys

2011-11-23 Thread Tejun Heo
Hello, On Wed, Nov 23, 2011 at 04:45:43PM +0800, Dave Young wrote: > add comments about current per_cpu_ptr_to_phys implementation > to explain why the logic is more complicated than necessary. > > Signed-off-by: Dave Young Moved the comment into the kerneldoc comment and applied to percpu/for-

Re: [PATCH v2] kdump: crashk_res init check for /sys/kernel/kexec_crash_size

2011-11-23 Thread Cong Wang
On Wed, Nov 23, 2011 at 9:18 PM, Michael Holzheu wrote: > From: Michael Holzheu > > Currently it is possible to set the crash_size via the sysfs > /sys/kernel/kexec_crash_size even if no crash kernel memory has > been defined with the "crashkernel" parameter. In this case > "crashk_res" is not in

Re: [PATCH v2] kdump: crashk_res init check for /sys/kernel/kexec_crash_size

2011-11-23 Thread Dave Young
On 11/23/2011 09:46 PM, Michael Holzheu wrote: > Hi Dave, > > On Wed, 2011-11-23 at 21:34 +0800, Dave Young wrote: >> On 11/23/2011 09:18 PM, Michael Holzheu wrote: >> >>> From: Michael Holzheu >>> >>> Currently it is possible to set the crash_size via the sysfs >>> /sys/kernel/kexec_crash_size

Re: [PATCH v2] kdump: crashk_res init check for /sys/kernel/kexec_crash_size

2011-11-23 Thread Michael Holzheu
Hi Dave, On Wed, 2011-11-23 at 21:34 +0800, Dave Young wrote: > On 11/23/2011 09:18 PM, Michael Holzheu wrote: > > > From: Michael Holzheu > > > > Currently it is possible to set the crash_size via the sysfs > > /sys/kernel/kexec_crash_size even if no crash kernel memory has > > been defined wi

Re: [PATCH v2] kdump: crashk_res init check for /sys/kernel/kexec_crash_size

2011-11-23 Thread Dave Young
On 11/23/2011 09:18 PM, Michael Holzheu wrote: > From: Michael Holzheu > > Currently it is possible to set the crash_size via the sysfs > /sys/kernel/kexec_crash_size even if no crash kernel memory has > been defined with the "crashkernel" parameter. In this case > "crashk_res" is not initialize

[PATCH v2] kdump: crashk_res init check for /sys/kernel/kexec_crash_size

2011-11-23 Thread Michael Holzheu
From: Michael Holzheu Currently it is possible to set the crash_size via the sysfs /sys/kernel/kexec_crash_size even if no crash kernel memory has been defined with the "crashkernel" parameter. In this case "crashk_res" is not initialized and crashk_res.start = crashk_res.end = 0. Unfortunately r

Re: [PATCH] kdump: crashk_res init check for /sys/kernel/kexec_crash_size

2011-11-23 Thread Simon Horman
On Wed, Nov 23, 2011 at 11:11:08AM +0100, Michael Holzheu wrote: > From: Michael Holzheu > > Currently it is possible to set the crash_size via the sysfs > /sys/kernel/kexec_crash_size even if no crash kernel memory has > been defined with the "crashkernel" parameter. In this case > "crashk_res"

[PATCH] kdump: crashk_res init check for /sys/kernel/kexec_crash_size

2011-11-23 Thread Michael Holzheu
From: Michael Holzheu Currently it is possible to set the crash_size via the sysfs /sys/kernel/kexec_crash_size even if no crash kernel memory has been defined with the "crashkernel" parameter. In this case "crashk_res" is not initialized and crashk_res.start = crashk_res.end = 0. Unfortunately r

Re: [patch v2 for-3.2] block: initialize request_queue's numa node during allocation

2011-11-23 Thread Jens Axboe
On 2011-11-23 02:14, David Rientjes wrote: > From: Mike Snitzer > > struct request_queue is allocated with __GFP_ZERO so its "node" field is > zero before initialization. This causes an oops if node 0 is offline in > the page allocator because its zonelists are not initialized. From Dave > Y

[PATCH] percpu: add comment to per_cpu_ptr_to_phys

2011-11-23 Thread Dave Young
add comments about current per_cpu_ptr_to_phys implementation to explain why the logic is more complicated than necessary. Signed-off-by: Dave Young --- mm/percpu.c | 13 + 1 file changed, 13 insertions(+) --- linux-2.6.orig/mm/percpu.c 2011-11-22 10:18:46.0 +0800 +++ lin