Re: [PATCH v2] x86, kdump: No need to disable ioapic/lapic in crash path

2012-02-09 Thread Eric W. Biederman
The code and the testing look good, and it has long been desirable to get rid of this code and reduce the complexity of the kexec on panic path. Ingo, Peter, Thomas if one of you could pick this up that would be wonderful. Don Zickus writes: > A customer of ours noticed when their machine cra

[PATCH v2] x86, kdump: No need to disable ioapic/lapic in crash path

2012-02-09 Thread Don Zickus
A customer of ours noticed when their machine crashed, kdump did not work but hung instead. Using their firmware dumping solution they grabbed a vmcore and decoded the stacks on the cpus. What they noticed seemed to be a rare deadlock with the ioapic_lock. CPU4: machine_crash_shutdown -> mach

Re: [PATCH] x86, kdump: No need to disable ioapic in crash path

2012-02-09 Thread Don Zickus
On Wed, Feb 08, 2012 at 02:55:14PM -0800, Eric W. Biederman wrote: > > I ran lkdtm by panic'ing in the interrupt handle thus leaving device > > interrupt un-ack'd and the apic might have been un-ack'd too (jprobes > > hooked in at do_IRQ). 3 out 3 times the second kernel came up on my core2 > > qu