Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-13 Thread Don Zickus
On Mon, Feb 13, 2012 at 05:12:58PM -0500, Don Zickus wrote: > On Mon, Feb 13, 2012 at 08:52:19AM -0800, Yinghai Lu wrote: > > On Mon, Feb 13, 2012 at 7:28 AM, Don Zickus wrote: > > > On Sat, Feb 11, 2012 at 05:04:15PM -0800, Yinghai Lu wrote: > > >> > > > >> > v2: removed the disable lapic code to

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-13 Thread Don Zickus
On Mon, Feb 13, 2012 at 08:52:19AM -0800, Yinghai Lu wrote: > On Mon, Feb 13, 2012 at 7:28 AM, Don Zickus wrote: > > On Sat, Feb 11, 2012 at 05:04:15PM -0800, Yinghai Lu wrote: > >> > > >> > v2: removed the disable lapic code too > >> > >> with this commit, kdump is not working anymore on my setup

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-13 Thread Yinghai Lu
On Mon, Feb 13, 2012 at 8:51 AM, Yinghai Lu wrote: >> So I suspect we have a bug in our apic initialization somewhere, but >> apic initialization should happen after printk are enabled.  Or at least >> after early printks so the reset YH is reporting doesn't make much sense. > > will try Don's fir

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-13 Thread Yinghai Lu
On Mon, Feb 13, 2012 at 4:52 AM, Eric W. Biederman wrote: > Yinghai Lu writes: > >> On Sat, Feb 11, 2012 at 7:13 PM, Eric W. Biederman >> wrote: >>> Yinghai Lu writes: After reverting this commit, kdump is working again. So assume you need to drop this patch. >>> >>> It sounds li

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-13 Thread Don Zickus
On Sat, Feb 11, 2012 at 05:04:15PM -0800, Yinghai Lu wrote: > > > > v2: removed the disable lapic code too > > with this commit, kdump is not working anymore on my setups with > Nehalem, Westmere, sandbridge. > these setup all have VT-d enabled. Hi Yinghai, Thanks for the report. Can you attach

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-13 Thread Eric W. Biederman
Yinghai Lu writes: > On Sat, Feb 11, 2012 at 7:13 PM, Eric W. Biederman > wrote: >> Yinghai Lu writes: >>> After reverting this commit, kdump is working again. >>> >>> So assume you need to drop this patch. >> >> It sounds like there is a bug in ioapic initialization in the context of >> VT-d.