Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-22 Thread Dave Young
- Original Message - From: "Dave Young" To: "Thiago Jung Bauermann" Cc: linuxppc-...@lists.ozlabs.org, kexec@lists.infradead.org, linux-ker...@vger.kernel.org, "Eric Biederman" Sent: Thursday, June 23, 2016 10:30:52 AM Subject: Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_me

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-22 Thread Dave Young
On 06/22/16 at 08:34pm, Thiago Jung Bauermann wrote: > Am Mittwoch, 22 Juni 2016, 18:18:01 schrieb Dave Young: > > On 06/21/16 at 04:48pm, Thiago Jung Bauermann wrote: > > > +/** > > > + * kexec_locate_mem_hole - find free memory to load segment or use in > > > purgatory + * @image: kexec image

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-22 Thread Dave Young
On 06/22/16 at 08:30pm, Thiago Jung Bauermann wrote: > Am Mittwoch, 22 Juni 2016, 18:20:47 schrieb Dave Young: > > The patch looks good, but could the subject be more specific? > > > > For example just like the first sentence of the patch descriotion: > > Allow architectures to specify their own m

Re: [PATCH 0/2] Simple fix to the ARM kexec tools implementation

2016-06-22 Thread Simon Horman
On Tue, Jun 21, 2016 at 09:20:33AM +0100, Russell King - ARM Linux wrote: > On Tue, Jun 21, 2016 at 11:41:28AM +0530, Pratyush Anand wrote: > > Yes, so until we have proper header for zImage, these patches looks > > fine to me. > > If you read my last email in the "kexec failures with DEBUG_RODATA

Re: [PATCH] Remove "max" parameter comment

2016-06-22 Thread Simon Horman
On Thu, Jun 09, 2016 at 05:18:08PM +0100, Russell King wrote: > Remove the "max" parameter in the documentation for mem_regions_add() > > Signed-off-by: Russell King Thanks, applied. ___ kexec mailing list kexec@lists.infradead.org http://lists.infrad

RE: [PATCH 1/2] sadump: fix segmentation fault on sadump-related formats

2016-06-22 Thread Atsushi Kumagai
Hello HATAYAMA-san, >Kumagai-san, > >Could you review these patches? Thanks for fixing them, I've reviewed the patches. I'll merge the patches into v1.6.1. Regards, Atsushi Kumagai >On 2016/06/20 14:57, HATAYAMA Daisuke wrote: >> Currently, makedumpfile results in segmentation fault on >> sadum

Re: [PATCH v3 0/9] kexec_file_load implementation for PowerPC

2016-06-22 Thread Balbir Singh
On 23/06/16 03:02, Thiago Jung Bauermann wrote: > Hello Balbir, > Hi Thiago >>> 3. have IMA pass-on its event log (where integrity measurements are >>> >>>registered) accross kexec to the second kernel, so that the event >>>history is preserved. >> >> OK.. and this is safe? Do both the

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-22 Thread Thiago Jung Bauermann
Am Mittwoch, 22 Juni 2016, 18:18:01 schrieb Dave Young: > On 06/21/16 at 04:48pm, Thiago Jung Bauermann wrote: > > +/** > > + * kexec_locate_mem_hole - find free memory to load segment or use in > > purgatory + * @image: kexec image being updated. > > + * @size: Memory size. > > + * @align:

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-22 Thread Thiago Jung Bauermann
Am Mittwoch, 22 Juni 2016, 18:20:47 schrieb Dave Young: > The patch looks good, but could the subject be more specific? > > For example just like the first sentence of the patch descriotion: > Allow architectures to specify their own memory walking function Ok, What about this? I also changed the

[PATCH v2 1/2] refactor code parsing size based on memory range

2016-06-22 Thread Hari Bathini
Currently, crashkernel parameter supports the below syntax to parse size based on memory range: crashkernel=:[,:,...] While such parsing is implemented for crashkernel parameter, it applies to other parameters with similar syntax. So, move this code to a more generic place for code reuse.

Re: [PATCH v3 0/9] kexec_file_load implementation for PowerPC

2016-06-22 Thread Thiago Jung Bauermann
Hello Balbir, Am Mittwoch, 22 Juni 2016, 23:29:46 schrieb Balbir Singh: > On Tue, 21 Jun 2016 16:48:32 -0300 > Thiago Jung Bauermann wrote: > > This patch series implements the kexec_file_load system call on > > PowerPC. > > > > This system call moves the reading of the kernel, initrd and the >

Re: [PATCH 0/6] kexec_file: Add buffer hand-over for the next kernel

2016-06-22 Thread Thiago Jung Bauermann
Hello Dave, Thanks for your considerations on this feature. Am Mittwoch, 22 Juni 2016, 09:20:46 schrieb Dave Young: > On 06/20/16 at 10:44pm, Thiago Jung Bauermann wrote: > > This feature was implemented because the Integrity Measurement > > Architecture subsystem needs to preserve its measuremen

[PATCH 3/3] ima: add pre-calculated measurements (experimental)

2016-06-22 Thread Mimi Zohar
This patch defines a new IMA hook named ima_add_measurement_check() for including pre-calculated measurements in the IMA measurement list. Signed-off-by: Mimi Zohar --- Documentation/ABI/testing/ima_policy | 2 +- include/linux/ima.h | 12 security/integrity/ima/Kconfig

[PATCH 1/3] ima: measure other types of data

2016-06-22 Thread Mimi Zohar
In addition to files, other data (eg. boot command line) should be included in the measurement list to attest to the integrity of a running system. A new IMA hook named ima_buffer_check() calculates and includes the buffer hash in the measurement list. Callers of this hook provide the buffer, buf

Re: [PATCH v3 0/9] kexec_file_load implementation for PowerPC

2016-06-22 Thread Balbir Singh
On Tue, 21 Jun 2016 16:48:32 -0300 Thiago Jung Bauermann wrote: > Hello, > > This patch series implements the kexec_file_load system call on > PowerPC. > > This system call moves the reading of the kernel, initrd and the > device tree from the userspace kexec tool to the kernel. This is > neede

[PATCH 2/3] kexec: measure boot command line

2016-06-22 Thread Mimi Zohar
This patch defines the buffer identifier "KEXEC_CMDLINE_CHECK" for measuring the boot command line. eg: echo -n -e `cat /proc/cmdline | sed 's/^.*root=/root=/'` | sha256sum Signed-off-by: Mimi Zohar --- Documentation/ABI/testing/ima_policy | 1 + include/linux/ima.h | 1 + kern

[PATCH 0/3] support other types of measurements

2016-06-22 Thread Mimi Zohar
In addition to file measurements, other types of measurements should be included in the IMA measurement list to attest to the integrity of the running system. This patch set introduces two new types of measurements - buffer and pre-calculated digests. The first, for example, can be used to measur

Re: [PATCH 0/6] kexec_file: Add buffer hand-over for the next kernel

2016-06-22 Thread Mimi Zohar
Hi Dave, On Wed, 2016-06-22 at 09:20 +0800, Dave Young wrote: > On 06/20/16 at 10:44pm, Thiago Jung Bauermann wrote: > > Hello, > > > > This patch series implements a mechanism which allows the kernel to pass on > > a buffer to the kernel that will be kexec'd. This buffer is passed as a > > segme

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-22 Thread Dave Young
The patch looks good, but could the subject be more specific? For example just like the first sentence of the patch descriotion: Allow architectures to specify their own memory walking function On 06/21/16 at 04:48pm, Thiago Jung Bauermann wrote: > Allow architectures to specify different memory

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-22 Thread Dave Young
On 06/21/16 at 04:48pm, Thiago Jung Bauermann wrote: > kexec_locate_mem_hole will be used by the PowerPC kexec_file_load > implementation to find free memory for the purgatory stack. > > Signed-off-by: Thiago Jung Bauermann > Cc: Eric Biederman > Cc: Dave Young > Cc: kexec@lists.infradead.org >

Re: [PATCH 2/2] arm: fix kernel image size

2016-06-22 Thread Tony Lindgren
* Russell King - ARM Linux [160622 01:32]: > When CONFIG_DEBUG_RODATA is enabled, we align the text, read-only data, > data, and so on to 1MB boundaries so that we can change the permissions > of the sections to enforce the properties of the various ELF segments. > This padding massively inflates

Re: [PATCH 1/2] sadump: fix segmentation fault on sadump-related formats

2016-06-22 Thread HATAYAMA, Daisuke
Kumagai-san, Could you review these patches? On 2016/06/20 14:57, HATAYAMA Daisuke wrote: Currently, makedumpfile results in segmentation fault on sadump-related formats: # ~/makedumpfile --message-level 31 -l -d 31 -x ./vmlinux vmcore sadump: read dump device as single partition s

Re: [PATCH 2/2] arm: fix kernel image size

2016-06-22 Thread Russell King - ARM Linux
On Wed, Jun 22, 2016 at 12:36:16AM -0700, Tony Lindgren wrote: > * Russell King - ARM Linux [160621 14:54]: > > So that's 20.7MB, and the zImage was 3.6MB. You're getting an > > expansion ratio of 5.7x. > > > > To fix that, we'd need to up it to 7x, but the problem with upping > > it in this way

Re: [PATCH 2/2] arm: fix kernel image size

2016-06-22 Thread Tony Lindgren
* Russell King - ARM Linux [160621 14:54]: > So that's 20.7MB, and the zImage was 3.6MB. You're getting an > expansion ratio of 5.7x. > > To fix that, we'd need to up it to 7x, but the problem with upping > it in this way is that it increases the requirements for the > crashdump region too. We