[PATCH v2] kexec: Introduce vmcoreinfo signature verification

2017-03-16 Thread Xunlei Pang
Currently vmcoreinfo data is updated at boot time subsys_initcall(), it has the risk of being modified by some wrong code during system is running. As a result, vmcore dumped may contain the wrong vmcoreinfo. Later on, when using "crash" or "makedumpfile"(etc) utility to parse this vmcore, we

Re: kexec regression since 4.9 caused by efi

2017-03-16 Thread Dave Young
On 03/16/17 at 12:41pm, Matt Fleming wrote: > On Mon, 13 Mar, at 03:37:48PM, Dave Young wrote: > > > > Omar, could you try below patch? Looking at the efi_mem_desc_lookup, it is > > not > > correct to be used in efi_arch_mem_reserve, if it passed your test, I > > can rewrite patch log with more

Re: kexec regression since 4.9 caused by efi

2017-03-16 Thread Omar Sandoval
On Thu, Mar 16, 2017 at 12:41:32PM +, Matt Fleming wrote: > On Mon, 13 Mar, at 03:37:48PM, Dave Young wrote: > > > > Omar, could you try below patch? Looking at the efi_mem_desc_lookup, it is > > not > > correct to be used in efi_arch_mem_reserve, if it passed your test, I > > can rewrite

[PATCH][kexec-tools] ppc: Fix format warning with die()

2017-03-16 Thread Jussi Kukkonen
Enable compiling kexec-tools for ppc with -Werror=format-security. Signed-off-by: Jussi Kukkonen --- kexec/arch/ppc/kexec-elf-ppc.c| 2 +- kexec/arch/ppc/kexec-uImage-ppc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] kexec: Update vmcoreinfo after crash happened

2017-03-16 Thread Xunlei Pang
On 03/16/2017 at 08:27 PM, Baoquan He wrote: > Hi Xunlei, > > Did you really see this ever happened? Because the vmcore size estimate > feature, namely --mem-usage option of makedumpfile, depends on the > vmcoreinfo in 1st kernel, your change will break it. Hi Baoquan, I can reproduce it using a

[PATCH] kexec: Update vmcoreinfo after crash happened

2017-03-16 Thread Xunlei Pang
Currently vmcoreinfo data is updated at boot time subsys_initcall(), it has the risk of being modified by some wrong code during system is running. As a result, vmcore dumped will contain the wrong vmcoreinfo. Later on, when using "crash" utility to parse this vmcore, we probably will get

Re: [PATCH v33 00/14] add kdump support

2017-03-16 Thread David Woodhouse
On Thu, 2017-03-16 at 09:23 +0900, AKASHI Takahiro wrote: > > I double-checked but saw no warnings like these neither for v32 nor v33. > I'm afraid that you might have done something wrong in backporting, > particularly patch#5. Then I apologise for the noise. Thanks for checking. smime.p7s

[PATCH] crashdump: Remove stray get_crashkernel_region() declaration

2017-03-16 Thread Daniel Kiper
Signed-off-by: Daniel Kiper --- kexec/crashdump.h |1 - 1 file changed, 1 deletion(-) diff --git a/kexec/crashdump.h b/kexec/crashdump.h index 96219a8..86e1ef2 100644 --- a/kexec/crashdump.h +++ b/kexec/crashdump.h @@ -1,7 +1,6 @@ #ifndef CRASHDUMP_H #define