Re: [PATCH v34 04/14] arm64: kdump: reserve memory for crash dump kernel

2017-04-03 Thread David Woodhouse
> On Mon, Apr 03, 2017 at 09:18:12AM +0100, David Woodhouse wrote: >> >> You still have typos here. > > I'd like to defer to the maintainers whether we prefer MiB over MB. It is not really a matter of preference. One is correct; the other is not. While simple errors can of course be forgiven, I

Re: [PATCH v34 04/14] arm64: kdump: reserve memory for crash dump kernel

2017-04-03 Thread AKASHI Takahiro
On Mon, Apr 03, 2017 at 09:18:12AM +0100, David Woodhouse wrote: > > You still have typos here. I'd like to defer to the maintainers whether we prefer MiB over MB. Thanks, -Takahiro AKASHI ___ kexec mailing list kexec@lists.infradead.org http://lists.

Re: kexec regression since 4.9 caused by efi

2017-04-03 Thread Omar Sandoval
On Thu, Mar 16, 2017 at 10:50:48AM -0700, Omar Sandoval wrote: > On Thu, Mar 16, 2017 at 12:41:32PM +, Matt Fleming wrote: > > On Mon, 13 Mar, at 03:37:48PM, Dave Young wrote: > > > > > > Omar, could you try below patch? Looking at the efi_mem_desc_lookup, it > > > is not > > > correct to be

Re: [PATCH v34 04/14] arm64: kdump: reserve memory for crash dump kernel

2017-04-03 Thread David Woodhouse
On Tue, 2017-03-28 at 15:51 +0900, AKASHI Takahiro wrote: > > +   if (crash_base == 0) { > +   /* Current arm64 boot protocol requires 2MB alignment */ > +   crash_base = memblock_find_in_range(0, ARCH_LOW_ADDRESS_LIMIT, > +   crash_size, SZ_

Re: [PATCH v35 08/14] arm64: kdump: implement machine_crash_shutdown()

2017-04-03 Thread David Woodhouse
On Mon, 2017-04-03 at 11:24 +0900, AKASHI Takahiro wrote: > > +static void ipi_cpu_crash_stop(unsigned int cpu, struct pt_regs > *regs) > +{ > +#ifdef CONFIG_KEXEC_CORE > +   crash_save_cpu(regs, cpu); > + > +   atomic_dec(&waiting_for_crash_ipi); > + > +   local_irq_disable(); Should