Re: [PATCH v2] kexec_file: Adjust declaration of kexec_purgatory

2017-05-10 Thread Eric W. Biederman
Kees Cook writes: > Defining kexec_purgatory as a zero-length char array upsets compile > time size checking. Since this is built on a per-arch basis, define > it as an unsized char array (like is done for other similar things, > e.g. linker sections). This silences the warning generated by the f

[PATCH v2] kexec_file: Adjust declaration of kexec_purgatory

2017-05-10 Thread Kees Cook
Defining kexec_purgatory as a zero-length char array upsets compile time size checking. Since this is built on a per-arch basis, define it as an unsized char array (like is done for other similar things, e.g. linker sections). This silences the warning generated by the future CONFIG_FORTIFY_SOURCE,

Re: [PATCH] kexec_file: Adjust type of kexec_purgatory

2017-05-10 Thread Kees Cook
On Tue, May 9, 2017 at 5:15 PM, Eric W. Biederman wrote: > Kees Cook writes: >> kernel/kexec_file.c:33:13: warning: array ‘kexec_purgatory’ assumed to >> have one element >> char __weak kexec_purgatory[]; >> ^~~ > > Nor does "void *kexec_purgatory" as that says at the ad

[PATCH] Handle additional e820 memmap type strings

2017-05-10 Thread Eric DeVolder
Keep pace with changes to linux arch/x86/kernel/e820.c to function e820_type_to_string(). With this change, the following messages from kexec are eliminated (and allows kexec to load): Unknown type (Reserved) while parsing /sys/firmware/memmap/8/type. Please report this as bug. Using RANGE_RESER

RE: [Makedumpfile PATCH 0/2] Fix refiltering when kaslr enabled

2017-05-10 Thread Atsushi Kumagai
>Hi Atsushi, > >On Friday 28 April 2017 12:22 PM, Atsushi Kumagai wrote: >> Hello Pratyush, >> >> Thanks for your report, I have received this. >> I'm on vacation until Mar 8, I'll review it when I return from vacation. > >Any further comment on it? >Otherwise, I will send a v2 after accommodating