Re: [PATCH v3 0/2] kexec-tools: arm64: Enable D-cache in purgatory

2017-06-02 Thread James Morse
Hi Bhupesh, On 02/06/17 12:15, Bhupesh SHARMA wrote: > On Fri, Jun 2, 2017 at 3:25 PM, Ard Biesheuvel > wrote: >> On 2 June 2017 at 08:23, James Morse wrote: >>> On 23/05/17 06:02, Pratyush Anand wrote: It takes more that 2 minutes to verify SHA in purgatory when vmlinuz image is aroun

Re: [PATCH v3 0/2] kexec-tools: arm64: Enable D-cache in purgatory

2017-06-02 Thread Pratyush Anand
Hi James, On Friday 02 June 2017 01:53 PM, James Morse wrote: Hi Pratyush, On 23/05/17 06:02, Pratyush Anand wrote: It takes more that 2 minutes to verify SHA in purgatory when vmlinuz image is around 13MB and initramfs is around 30MB. It takes more than 20 second even when we have -O2 optimiz

Re: [PATCH v3 1/2] kexec: arm64: create identity page table to be used in purgatory

2017-06-02 Thread Pratyush Anand
Hi James, Thanks for taking out time to review the code. On Friday 02 June 2017 01:54 PM, James Morse wrote: Hi Pratyush, On 23/05/17 06:02, Pratyush Anand wrote: Purgatory sha verification is very slow when D-cache is not enabled there. We need to enable MMU as well to enable D-Cache.Therefo

Re: [PATCH v3 0/2] kexec-tools: arm64: Enable D-cache in purgatory

2017-06-02 Thread Pratyush Anand
Hi Ard, Thanks for all the inputs. On Friday 02 June 2017 05:14 PM, Ard Biesheuvel wrote: Alternatively, a SHA-256 implementation that uses movz/movk sequences instead of ldr instructions to load the round constants would already be 5x faster, given that we don't need page tables to enable the

Re: [PATCH v3 0/2] kexec-tools: arm64: Enable D-cache in purgatory

2017-06-02 Thread Ard Biesheuvel
On 2 June 2017 at 11:36, Ard Biesheuvel wrote: > On 2 June 2017 at 11:15, Bhupesh SHARMA wrote: >> Hi Ard, James >> >> On Fri, Jun 2, 2017 at 3:25 PM, Ard Biesheuvel >> wrote: >>> On 2 June 2017 at 08:23, James Morse wrote: Hi Pratyush, On 23/05/17 06:02, Pratyush Anand wrote: >>

Re: [PATCH v3 0/2] kexec-tools: arm64: Enable D-cache in purgatory

2017-06-02 Thread Ard Biesheuvel
On 2 June 2017 at 11:15, Bhupesh SHARMA wrote: > Hi Ard, James > > On Fri, Jun 2, 2017 at 3:25 PM, Ard Biesheuvel > wrote: >> On 2 June 2017 at 08:23, James Morse wrote: >>> Hi Pratyush, >>> >>> On 23/05/17 06:02, Pratyush Anand wrote: It takes more that 2 minutes to verify SHA in purgatory

Re: [PATCH v3 0/2] kexec-tools: arm64: Enable D-cache in purgatory

2017-06-02 Thread Bhupesh SHARMA
Hi Ard, James On Fri, Jun 2, 2017 at 3:25 PM, Ard Biesheuvel wrote: > On 2 June 2017 at 08:23, James Morse wrote: >> Hi Pratyush, >> >> On 23/05/17 06:02, Pratyush Anand wrote: >>> It takes more that 2 minutes to verify SHA in purgatory when vmlinuz image >>> is around 13MB and initramfs is arou

Re: [PATCH v3 0/2] kexec-tools: arm64: Enable D-cache in purgatory

2017-06-02 Thread Ard Biesheuvel
On 2 June 2017 at 08:23, James Morse wrote: > Hi Pratyush, > > On 23/05/17 06:02, Pratyush Anand wrote: >> It takes more that 2 minutes to verify SHA in purgatory when vmlinuz image >> is around 13MB and initramfs is around 30MB. It takes more than 20 second >> even when we have -O2 optimization e

Re: [PATCH v3 0/2] kexec-tools: arm64: Enable D-cache in purgatory

2017-06-02 Thread James Morse
Hi Pratyush, On 23/05/17 06:02, Pratyush Anand wrote: > It takes more that 2 minutes to verify SHA in purgatory when vmlinuz image > is around 13MB and initramfs is around 30MB. It takes more than 20 second > even when we have -O2 optimization enabled. However, if dcache is enabled > during purgat

Re: [PATCH v3 1/2] kexec: arm64: create identity page table to be used in purgatory

2017-06-02 Thread James Morse
Hi Pratyush, On 23/05/17 06:02, Pratyush Anand wrote: > Purgatory sha verification is very slow when D-cache is not enabled there. > We need to enable MMU as well to enable D-Cache.Therefore,we need to > have an identity mapped page table in purgatory. > > Since debugging is very difficult in pur