Re: [PATCH v1 5/8] hv_balloon: mark inflated pages PG_offline

Hi David, > > Mark inflated and never onlined pages PG_offline, to tell the world that > the content is stale and should not be dumped. > > Cc: "K. Y. Srinivasan" > Cc: Haiyang Zhang > Cc: Stephen Hemminger > Cc: Kairui Song > Cc: Vitaly Kuznetsov > Cc: Andrew Morton > Cc: Matthew Wilcox

Re: [PATCH v1 5/8] hv_balloon: mark inflated pages PG_offline

> >> --- > >> drivers/hv/hv_balloon.c | 14 -- > >> 1 file changed, 12 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c > >> index 211f3fe3a038..47719862e57f 100644 > >> --- a/drivers/hv/hv_balloon.c > >> +++ b/drivers/hv/hv_ballo

Re: [PATCH v1 5/8] hv_balloon: mark inflated pages PG_offline

On 20.11.18 09:45, Pankaj Gupta wrote: > > Hi David, > >> >> Mark inflated and never onlined pages PG_offline, to tell the world that >> the content is stale and should not be dumped. >> >> Cc: "K. Y. Srinivasan" >> Cc: Haiyang Zhang >> Cc: Stephen Hemminger >> Cc: Kairui Song >> Cc: Vitaly K

Re: [PATCH 1/2 v6] x86/kexec_file: add e820 entry in case e820 type string matches to io resource name

On Tue, Nov 20, 2018 at 11:37:26AM +0800, lijiang wrote: > BTW: Boris has mentioned the solution which adds the new descriptor > 'IORES_DESC_RESERVED'. > > Which solution do you prefer? Add the new I/O resource descriptor > 'IORES_DESC_RESERVED'(patch v7) > or exactly comparing a string(patch v6

Re: [PATCH 1/2 v6] x86/kexec_file: add e820 entry in case e820 type string matches to io resource name

On Thu, Nov 15, 2018 at 4:40 AM Borislav Petkov wrote: > > + Bjorn. > > On Thu, Nov 15, 2018 at 01:44:07PM +0800, lijiang wrote: > > At present, the upstream kernel does not pass the e820 reserved ranges to > > the > > second kernel, which might cause two problems: > > > > The first one is the MM

Re: [PATCH v1 7/8] PM / Hibernate: use pfn_to_online_page()

On Monday, November 19, 2018 11:16:15 AM CET David Hildenbrand wrote: > Let's use pfn_to_online_page() instead of pfn_to_page() when checking > for saveable pages to not save/restore offline memory sections. > > Cc: "Rafael J. Wysocki" > Cc: Pavel Machek > Cc: Len Brown > Cc: Andrew Morton > C

Re: [PATCH v1 8/8] PM / Hibernate: exclude all PageOffline() pages

On Monday, November 19, 2018 11:16:16 AM CET David Hildenbrand wrote: > The content of pages that are marked PG_offline is not of interest > (e.g. inflated by a balloon driver), let's skip these pages. > > Cc: "Rafael J. Wysocki" > Cc: Pavel Machek > Cc: Len Brown > Cc: Andrew Morton > Cc: Mat

Re: [PATCH v1 5/8] hv_balloon: mark inflated pages PG_offline

> > >> --- > > >> drivers/hv/hv_balloon.c | 14 -- > > >> 1 file changed, 12 insertions(+), 2 deletions(-) > > >> > > >> diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c > > >> index 211f3fe3a038..47719862e57f 100644 > > >> --- a/drivers/hv/hv_balloon.c > > >> +++ b/dri

Re: [PATCH v1 1/8] mm: balloon: update comment about isolation/migration/compaction

On Mon, Nov 19, 2018 at 11:16:09AM +0100, David Hildenbrand wrote: > Commit b1123ea6d3b3 ("mm: balloon: use general non-lru movable page > feature") reworked balloon handling to make use of the general > non-lru movable page feature. The big comment block in > balloon_compaction.h contains quite so

Re: [PATCH v1 2/8] mm: convert PG_balloon to PG_offline

On Mon, Nov 19, 2018 at 11:16:10AM +0100, David Hildenbrand wrote: > PG_balloon was introduced to implement page migration/compaction for pages > inflated in virtio-balloon. Nowadays, it is only a marker that a page is > part of virtio-balloon and therefore logically offline. > > We also want to m

Re: [PATCH v1 3/8] kexec: export PG_offline to VMCOREINFO

On Mon, Nov 19, 2018 at 11:16:11AM +0100, David Hildenbrand wrote: > Right now, pages inflated as part of a balloon driver will be dumped > by dump tools like makedumpfile. While XEN is able to check in the > crash kernel whether a certain pfn is actuall backed by memory in the > hypervisor (see xe

Re: [PATCH v1 2/8] mm: convert PG_balloon to PG_offline

> > PG_balloon was introduced to implement page migration/compaction for pages > inflated in virtio-balloon. Nowadays, it is only a marker that a page is > part of virtio-balloon and therefore logically offline. > > We also want to make use of this flag in other balloon drivers - for > inflated

Re: [PATCH v1 3/8] kexec: export PG_offline to VMCOREINFO

On 11/19/18 at 11:16am, David Hildenbrand wrote: > Right now, pages inflated as part of a balloon driver will be dumped > by dump tools like makedumpfile. While XEN is able to check in the > crash kernel whether a certain pfn is actuall backed by memory in the > hypervisor (see xen_oldmem_pfn_is_ra

Re: [PATCH v1 6/8] vmw_balloon: mark inflated pages PG_offline

Thanks for this patch! > On Nov 19, 2018, at 2:16 AM, David Hildenbrand wrote: > > Mark inflated and never onlined pages PG_offline, to tell the world that > the content is stale and should not be dumped. > > Cc: Xavier Deguillard > Cc: Nadav Amit > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman

Re: [PATCH v1 3/8] kexec: export PG_offline to VMCOREINFO

On 11/19/18 at 11:16am, David Hildenbrand wrote: > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > index 933cb3e45b98..093c9f917ed0 100644 > --- a/kernel/crash_core.c > +++ b/kernel/crash_core.c > @@ -464,6 +464,8 @@ static int __init crash_save_vmcoreinfo_init(void) > VMCOREINFO_NUM

Re: [PATCH v2] x86_64, vmcoreinfo: Append 'page_offset_base' to vmcoreinfo

Hi Kazu, On Tue, Nov 20, 2018 at 2:47 AM Kazuhito Hagio wrote: > > On 11/15/2018 4:47 PM, Bhupesh Sharma wrote: > > Adding 'page_offset_base' to the vmcoreinfo can be specially useful for > > live-debugging of a running kernel via user-space utilities > > like makedumpfile (see [1]). > > I agree.