Re: [PATCH v3] Remove the memory encryption mask to obtain the true physical address

2019-03-11 Thread lijiang
在 2019年03月12日 03:43, Kazuhito Hagio 写道: > -Original Message- [PATCH v3] Remove the memory encryption mask to obtain the true physical address >>> >>> I forgot to comment on the subject and the commit log.. >>> I'll change this to >>> >>> x86_64: Add support for AMD Secure

Re: [PATCH v3 0/7] selftests/ima: add kexec and kernel module tests

2019-03-11 Thread Petr Vorel
Hi Mimi, > Mimi Zohar (6): > selftests/ima: cleanup the kexec selftest > selftests/ima: define a set of common functions > selftests/ima: define common logging functions > kselftest/ima: define "require_root_privileges" > selftests/ima: kexec_file_load syscall test > selftests/ima:

Re: [PATCH v3 2/7] selftests/ima: define a set of common functions

2019-03-11 Thread Petr Vorel
Hi Mimi, > Define, update and move get_secureboot_mode() to a common file for use > by other tests. > Updated to check both the efivar SecureBoot-$(UUID) and > SetupMode-$(UUID), based on Dave Young's review. > Signed-off-by: Mimi Zohar > Reviewed-by: Petr Vorel > Cc: Dave Young Minor

RE: [PATCH v3] Remove the memory encryption mask to obtain the true physical address

2019-03-11 Thread Kazuhito Hagio
-Original Message- > >> [PATCH v3] Remove the memory encryption mask to obtain the true physical > >> address > > > > I forgot to comment on the subject and the commit log.. > > I'll change this to > > > > x86_64: Add support for AMD Secure Memory Encryption > > > > On 1/29/2019 9:48

Re: [PATCH 3/3] x86/ima: retry detecting secure boot mode

2019-03-11 Thread Matthew Garrett
On Mon, Mar 11, 2019 at 9:55 AM Mimi Zohar wrote: > > On Fri, 2019-03-08 at 09:51 -0800, Matthew Garrett wrote: > > Hm. And this only happens on certain firmware versions? If something's > > stepping on boot_params then we have bigger problems. > > I was seeing this problem before and after

Re: [PATCH 3/3] x86/ima: retry detecting secure boot mode

2019-03-11 Thread Mimi Zohar
On Fri, 2019-03-08 at 09:51 -0800, Matthew Garrett wrote: > On Fri, Mar 8, 2019 at 5:40 AM Mimi Zohar wrote: > > > > On Thu, 2019-03-07 at 14:50 -0800, Matthew Garrett wrote: > > > Is the issue that it gives incorrect results on the first read, or is > > > the issue that it gives incorrect

RE: [PATCH v2] makedumpfile: exclude pages that are logically offline

2019-03-11 Thread Kazuhito Hagio
-Original Message- > On 27.11.18 17:32, Kazuhito Hagio wrote: > >> Linux marks pages that are logically offline via a page flag (map count). > >> Such pages e.g. include pages infated as part of a balloon driver or > >> pages that were not actually onlined when onlining the whole section.

[PATCH v3 1/7] selftests/ima: cleanup the kexec selftest

2019-03-11 Thread Mimi Zohar
Remove the few bashisms and use the complete option name for clarity. Signed-off-by: Mimi Zohar Reviewed-by: Petr Vorel --- tools/testing/selftests/ima/test_kexec_load.sh | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

[PATCH v3 4/7] kselftest/ima: define "require_root_privileges"

2019-03-11 Thread Mimi Zohar
Many tests require root privileges. Define a common function. Suggested-by: Petr Vorel Signed-off-by: Mimi Zohar --- tools/testing/selftests/ima/ima_common_lib.sh | 7 +++ tools/testing/selftests/ima/test_kexec_load.sh | 4 +--- 2 files changed, 8 insertions(+), 3 deletions(-) diff

[PATCH v3 0/7] selftests/ima: add kexec and kernel module tests

2019-03-11 Thread Mimi Zohar
The kernel can be configured to require kexec kernel images and kernel modules are signed. An IMA policy can be specified on the boot command line or a custom IMA policy loaded requiring the kexec kernel image and kernel modules be signed. In addition, systems booted in secure boot mode with the

[PATCH v3 5/7] selftests/ima: kexec_file_load syscall test

2019-03-11 Thread Mimi Zohar
The kernel can be configured to verify PE signed kernel images, IMA kernel image signatures, both types of signatures, or none. This test verifies only properly signed kernel images are loaded into memory, based on the kernel configuration and runtime policies. Signed-off-by: Mimi Zohar

[PATCH v3 7/7] selftests/ima: Add missing '=y' to config options

2019-03-11 Thread Mimi Zohar
From: Petr Vorel so the file can be used as kernel config snippet. Signed-off-by: Petr Vorel [zo...@linux.ibm.com: remove CONFIG_KEXEC_VERIFY_SIG from config] Signed-off-by: Mimi Zohar --- tools/testing/selftests/ima/config | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff

[PATCH v3 2/7] selftests/ima: define a set of common functions

2019-03-11 Thread Mimi Zohar
Define, update and move get_secureboot_mode() to a common file for use by other tests. Updated to check both the efivar SecureBoot-$(UUID) and SetupMode-$(UUID), based on Dave Young's review. Signed-off-by: Mimi Zohar Reviewed-by: Petr Vorel Cc: Dave Young ---

[PATCH v3 3/7] selftests/ima: define common logging functions

2019-03-11 Thread Mimi Zohar
Define log_info, log_pass, log_fail, and log_skip functions. Suggested-by: Petr Vorel Signed-off-by: Mimi Zohar Reviewed-by: Petr Vorel --- tools/testing/selftests/ima/ima_common_lib.sh | 31 ++ tools/testing/selftests/ima/test_kexec_load.sh | 19 +--- 2

[PATCH v3 6/7] selftests/ima: loading kernel modules

2019-03-11 Thread Mimi Zohar
While the appended kernel module signature can be verified, when loading a kernel module via either the init_module or the finit_module syscall, verifying the IMA signature requires access to the file descriptor, which is only available via the finit_module syscall. As "modprobe" does not provide

Re: [PATCH v2 3/8] kexec: export PG_offline to VMCOREINFO

2019-03-11 Thread Dave Young
> > The patch has been merged, would you mind to send a documentation patch > > for the vmcoreinfo, which is added recently in > > Documentation/kdump/vmcoreinfo.txt > > > > A brief description about how this vmcoreinfo field is used is good to > > have. > > > > Turns out, it was already

Re: [PATCH v2 3/8] kexec: export PG_offline to VMCOREINFO

2019-03-11 Thread David Hildenbrand
On 11.03.19 10:04, Dave Young wrote: > Hi David, > On 11/22/18 at 11:06am, David Hildenbrand wrote: >> Right now, pages inflated as part of a balloon driver will be dumped >> by dump tools like makedumpfile. While XEN is able to check in the >> crash kernel whether a certain pfn is actuall backed

Re: [PATCH v2 0/2] Append new variables to vmcoreinfo (PTRS_PER_PGD for arm64 and MAX_PHYSMEM_BITS for all archs)

2019-03-11 Thread Dave Young
Hi Bhupesh, On 03/10/19 at 03:34pm, Bhupesh Sharma wrote: > Changes since v1: > > - v1 was sent out as a single patch which can be seen here: > http://lists.infradead.org/pipermail/kexec/2019-February/022411.html > > - v2 breaks the single patch into two independent patches: >

Re: [PATCH v2 3/8] kexec: export PG_offline to VMCOREINFO

2019-03-11 Thread Dave Young
Hi David, On 11/22/18 at 11:06am, David Hildenbrand wrote: > Right now, pages inflated as part of a balloon driver will be dumped > by dump tools like makedumpfile. While XEN is able to check in the > crash kernel whether a certain pfn is actuall backed by memory in the > hypervisor (see