Re: [PATCH v2] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel

2019-04-04 Thread Chao Fan
On Thu, Apr 04, 2019 at 02:41:30PM +0800, Dave Young wrote: >On 04/04/19 at 11:22am, Dave Young wrote: >> On 04/04/19 at 11:10am, Baoquan He wrote: >> > On 04/04/19 at 11:00am, Baoquan He wrote: >> > > On 04/04/19 at 10:52am, Dave Young wrote: >> > > > On 04/04/19 at 01:23am, Junichi Nomura wrote:

Re: [PATCH] x86: Always to to fill acpi_rsdp_addr in boot params

2019-04-04 Thread Dave Young
Hello Kairui On 03/28/19 at 05:49pm, Kairui Song wrote: > Since kernel commit e6e094e053af75 ("x86/acpi, x86/boot: Take RSDP address > from boot params if available"), kernel accept a acpi_rsdp_addr param in > boot_params. Sync the x86_linux_param_header to support this param. > > And previously w

Re: [PATCH v3] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel

2019-04-04 Thread Dave Young
Hi Junichi, While we are still debuggin the bug I reproduced, but for this patch I have still some comments inline. BTW, it would be good to start a new thread when you send V4 :) On 04/02/19 at 10:25am, Junichi Nomura wrote: > Commit 3a63f70bf4c3a ("x86/boot: Early parse RSDP and save it in > b

Re: [PATCH v2] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel

2019-04-04 Thread Dave Young
Hi Chao, On 04/04/19 at 03:20pm, Chao Fan wrote: > On Thu, Apr 04, 2019 at 02:41:30PM +0800, Dave Young wrote: > >On 04/04/19 at 11:22am, Dave Young wrote: > >> On 04/04/19 at 11:10am, Baoquan He wrote: > >> > On 04/04/19 at 11:00am, Baoquan He wrote: > >> > > On 04/04/19 at 10:52am, Dave Young wro

Re: [PATCH v2] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel

2019-04-04 Thread Chao Fan
On Thu, Apr 04, 2019 at 03:41:02PM +0800, Dave Young wrote: >Hi Chao, >On 04/04/19 at 03:20pm, Chao Fan wrote: >> On Thu, Apr 04, 2019 at 02:41:30PM +0800, Dave Young wrote: >> >On 04/04/19 at 11:22am, Dave Young wrote: >> >> On 04/04/19 at 11:10am, Baoquan He wrote: >> >> > On 04/04/19 at 11:00am,

[PATCH 5.0 163/246] x86/kexec: Fill in acpi_rsdp_addr from the first kernel

2019-04-04 Thread Greg Kroah-Hartman
5.0-stable review patch. If anyone has any objections, please let me know. -- [ Upstream commit ccec81e4251f5a5421e02874e394338a897056ca ] When efi=noruntime or efi=oldmap is used on the kernel command line, EFI services won't be available in the second kernel, therefore the sec

Re: [PATCH v2] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel

2019-04-04 Thread Borislav Petkov
On Thu, Apr 04, 2019 at 03:41:02PM +0800, Dave Young wrote: > It is hard to find 32bit efi hardware, I can confirm all the laptop I > have are 64bit efi. You can use 32-bit OVMF with qemu, like in the link Chao gave a couple of mails earlier. -- Regards/Gruss, Boris. Good mailing practices

Re: [PATCH v3] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel

2019-04-04 Thread Borislav Petkov
On Thu, Apr 04, 2019 at 03:32:33PM +0800, Dave Young wrote: > BTW, it would be good to start a new thread when you send V4 :) Yes please. > > + /* Get systab from boot params. */ > > + systab = (efi_system_table_64_t *) (ei->efi_systab | > > ((__u64)ei->efi_systab_hi << 32)); > > + if (!sy

Re: [PATCH v2] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel

2019-04-04 Thread Dave Young
On 04/04/19 at 02:22pm, Borislav Petkov wrote: > On Thu, Apr 04, 2019 at 03:41:02PM +0800, Dave Young wrote: > > It is hard to find 32bit efi hardware, I can confirm all the laptop I > > have are 64bit efi. > > You can use 32-bit OVMF with qemu, like in the link Chao gave a couple > of mails earli

Re: [PATCH v3] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel

2019-04-04 Thread Dave Young
On 04/04/19 at 02:24pm, Borislav Petkov wrote: > On Thu, Apr 04, 2019 at 03:32:33PM +0800, Dave Young wrote: > > BTW, it would be good to start a new thread when you send V4 :) > > Yes please. > > > > + /* Get systab from boot params. */ > > > + systab = (efi_system_table_64_t *) (ei->efi_systab

Re: [PATCH v3] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel

2019-04-04 Thread Borislav Petkov
On Thu, Apr 04, 2019 at 10:12:41PM +0800, Dave Young wrote: > The early code hang can make people confused, it is hard to > say what happens and not easy to debug. But if we return 0 then kernel > just continue to boot, and fail later because of no acpi root pointer, at > least we can have some k

Re: [PATCH 2/3] arm64: kdump: support more than one crash kernel regions

2019-04-04 Thread Mike Rapoport
Hi, On Wed, Apr 03, 2019 at 09:51:27PM +0800, Chen Zhou wrote: > Hi Mike, > > On 2019/4/3 19:29, Mike Rapoport wrote: > > On Wed, Apr 03, 2019 at 11:05:45AM +0800, Chen Zhou wrote: > >> After commit (arm64: kdump: support reserving crashkernel above 4G), > >> there may be two crash kernel regions

Re: [PATCH 1/3] arm64: kdump: support reserving crashkernel above 4G

2019-04-04 Thread Mike Rapoport
Hi, On Wed, Apr 03, 2019 at 11:05:44AM +0800, Chen Zhou wrote: > When crashkernel is reserved above 4G in memory, kernel should > reserve some amount of low memory for swiotlb and some DMA buffers. > > Kernel would try to allocate at least 256M below 4G automatically > as x86_64 if crashkernel is

Re: [PATCH] x86: Always to to fill acpi_rsdp_addr in boot params

2019-04-04 Thread Kairui Song
On Thu, Apr 4, 2019 at 3:25 PM Dave Young wrote: > > Hello Kairui > On 03/28/19 at 05:49pm, Kairui Song wrote: > > Since kernel commit e6e094e053af75 ("x86/acpi, x86/boot: Take RSDP address > > from boot params if available"), kernel accept a acpi_rsdp_addr param in > > boot_params. Sync the x86_l

Re: [PATCH v3] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel

2019-04-04 Thread Dave Young
On 04/04/19 at 04:41pm, Borislav Petkov wrote: > On Thu, Apr 04, 2019 at 10:12:41PM +0800, Dave Young wrote: > > The early code hang can make people confused, it is hard to > > say what happens and not easy to debug. But if we return 0 then kernel > > just continue to boot, and fail later because

Re: [PATCH 2/3] arm64: kdump: support more than one crash kernel regions

2019-04-04 Thread Chen Zhou
Hi Mike, On 2019/4/4 22:44, Mike Rapoport wrote: > Hi, > > On Wed, Apr 03, 2019 at 09:51:27PM +0800, Chen Zhou wrote: >> Hi Mike, >> >> On 2019/4/3 19:29, Mike Rapoport wrote: >>> On Wed, Apr 03, 2019 at 11:05:45AM +0800, Chen Zhou wrote: After commit (arm64: kdump: support reserving crashke

Re: [PATCH 1/3] arm64: kdump: support reserving crashkernel above 4G

2019-04-04 Thread Chen Zhou
Hi Mike, On 2019/4/4 22:46, Mike Rapoport wrote: > Hi, > > On Wed, Apr 03, 2019 at 11:05:44AM +0800, Chen Zhou wrote: >> When crashkernel is reserved above 4G in memory, kernel should >> reserve some amount of low memory for swiotlb and some DMA buffers. >> >> Kernel would try to allocate at le

Re: [PATCH 2/3] arm64: kdump: support more than one crash kernel regions

2019-04-04 Thread Chen Zhou
Hi Mike, On 2019/4/5 10:17, Chen Zhou wrote: > Hi Mike, > > On 2019/4/4 22:44, Mike Rapoport wrote: >> Hi, >> >> On Wed, Apr 03, 2019 at 09:51:27PM +0800, Chen Zhou wrote: >>> Hi Mike, >>> >>> On 2019/4/3 19:29, Mike Rapoport wrote: On Wed, Apr 03, 2019 at 11:05:45AM +0800, Chen Zhou wrote:

Re: [PATCH v3] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel

2019-04-04 Thread Junichi Nomura
On 4/4/19 4:32 PM, Dave Young wrote: > While we are still debuggin the bug I reproduced, but for this patch > I have still some comments inline. > > BTW, it would be good to start a new thread when you send V4 :) Sure. >> +/* Get systab from boot params. */ >> +systab = (efi_system_table