Re: [PATCH using git format-patch -C] kexec: add generic support for elf kernel images

2019-07-08 Thread Michael Ellerman
Christophe Leroy writes: > Hi Sven, > > Le 08/07/2019 à 12:06, Christophe Leroy a écrit : >> From: Sven Schnelle > > Please describe you patch. > > All the changes you are doing to the ppc64 version in order to make it > generic should be described. > > Those changes are also maybe worth

Re: [v1 0/5] allow to reserve memory for normal kexec kernel

2019-07-08 Thread Pavel Tatashin
> Something is very very wrong there. > > Last I measured memory bandwidth seriously I could touch a Gigabyte per > second easily, and that was nearly 20 years ago. Did you manage to > disable caching or have some particularly slow code that does the > reolocations. > > There is a serious cost to

Re: [v1 0/5] allow to reserve memory for normal kexec kernel

2019-07-08 Thread Eric W. Biederman
Pavel Tatashin writes: > Currently, it is only allowed to reserve memory for crash kernel, because > it is a requirement in order to be able to boot into crash kernel without > touching memory of crashed kernel is to have memory reserved. > > The second benefit for having memory reserved for

[v1 0/5] allow to reserve memory for normal kexec kernel

2019-07-08 Thread Pavel Tatashin
Currently, it is only allowed to reserve memory for crash kernel, because it is a requirement in order to be able to boot into crash kernel without touching memory of crashed kernel is to have memory reserved. The second benefit for having memory reserved for kexec kernel is that it does not

[v1 2/5] kexec: add resource for normal kexec region

2019-07-08 Thread Pavel Tatashin
crashk_res resource is used to reserve memory for crash kernel. There is also, however, a benefit to reserve memory for normal kernel to speed up reboot performance. This is because during regular kexec reboot, kernel performs relocations to the final destination of the loaded segments, and the

[v1 5/5] arm64, kexec: reserve kexeckernel region

2019-07-08 Thread Pavel Tatashin
kexeckernel= is used to reserve memory for normal kexec kernel for faster reboot. Rename reserve_crashkernel() to reserve_crash_or_kexec_kernel(), and generalize it by adding an argument that specifies what is reserved: "crashkernel=" for crash kernel region "kexeckernel=" for normal kexec region

[v1 3/5] kexec: export common crashkernel/kexeckernel parser

2019-07-08 Thread Pavel Tatashin
To reserve memory for normal kexec reboot, the new parameter: kexeckernel=size[KMG][@offset[KMG]] is used. Its syntax is the same as craskernel=, therefore they can use the same function to parse parameter settings. Rename: __parse_crashkernel() to parse_crash_or_kexec_kernel(), and make it

[v1 1/5] kexec: quiet down kexec reboot

2019-07-08 Thread Pavel Tatashin
Here is a regular kexec command sequence and output: = $ kexec --reuse-cmdline -i --load Image $ kexec -e [ 161.342002] kexec_core: Starting new kernel Welcome to Buildroot buildroot login: = Even when "quiet" kernel parameter is specified, "kexec_core: Starting new kernel" is printed.

[v1 4/5] kexec: use reserved memory for normal kexec reboot

2019-07-08 Thread Pavel Tatashin
If memory was reserved for the given segment use it directly instead of allocating on per-page bases. This will avoid relocating this segment to final destination when machine is rebooted. This is done on a per segment bases because user might decide to always load kernel segments at the given

Re: [PATCH using git format-patch -C] kexec: add generic support for elf kernel images

2019-07-08 Thread Sven Schnelle
Hi Christophe, On Mon, Jul 08, 2019 at 12:40:52PM +0200, Christophe Leroy wrote: > > From: Sven Schnelle > > Please describe you patch. > > All the changes you are doing to the ppc64 version in order to make it > generic should be described. > > Those changes are also maybe worth splitting

Re: [PATCH using git format-patch -C] kexec: add generic support for elf kernel images

2019-07-08 Thread Christophe Leroy
Hi Sven, Le 08/07/2019 à 12:06, Christophe Leroy a écrit : From: Sven Schnelle Please describe you patch. All the changes you are doing to the ppc64 version in order to make it generic should be described. Those changes are also maybe worth splitting the patch in several parts, either

Re: [PATCH] kexec: add generic support for elf kernel images

2019-07-08 Thread Christophe Leroy
Le 07/07/2019 à 21:21, Sven Schnelle a écrit : Signed-off-by: Sven Schnelle --- Please add here a description of the changes done since RFC. arch/Kconfig | 3 + arch/powerpc/Kconfig | 1 + arch/powerpc/kernel/kexec_elf_64.c | 547

[PATCH using git format-patch -C] kexec: add generic support for elf kernel images

2019-07-08 Thread Christophe Leroy
From: Sven Schnelle Signed-off-by: Sven Schnelle --- patch generated with 'git format-patch -C' in order to see the modifications done in kexec_elf.c in addition to copying it from arch/powerpc/kernel/kexec_elf_64.c arch/Kconfig | 3 +