Re: [RFC PATCH] PCI, kdump: Clear bus master bit upon shutdown in kdump kernel

2020-01-11 Thread Deepa Dinamani
> Hi, there are some previous works about this issue, reset PCI devices > in kdump kernel to stop ongoing DMA: > > [v7,0/5] Reset PCIe devices to address DMA problem on kdump with iommu > https://lore.kernel.org/patchwork/cover/343767/ > > [v2] PCI: Reset PCIe devices to stop ongoing DMA >

[PATCH 5.4 018/165] x86/efi: Update e820 with reserved EFI boot services data to fix kexec breakage

2020-01-11 Thread Greg Kroah-Hartman
From: Dave Young [ Upstream commit af164898482817a1d487964b68f3c21bae7a1beb ] Michael Weiser reported that he got this error during a kexec rebooting: esrt: Unsupported ESRT version 2904149718861218184. The ESRT memory stays in EFI boot services data, and it was reserved in kernel via

[PATCH 4.19 10/84] x86/efi: Update e820 with reserved EFI boot services data to fix kexec breakage

2020-01-11 Thread Greg Kroah-Hartman
From: Dave Young [ Upstream commit af164898482817a1d487964b68f3c21bae7a1beb ] Michael Weiser reported that he got this error during a kexec rebooting: esrt: Unsupported ESRT version 2904149718861218184. The ESRT memory stays in EFI boot services data, and it was reserved in kernel via

[PATCH 4.14 07/62] x86/efi: Update e820 with reserved EFI boot services data to fix kexec breakage

2020-01-11 Thread Greg Kroah-Hartman
From: Dave Young [ Upstream commit af164898482817a1d487964b68f3c21bae7a1beb ] Michael Weiser reported that he got this error during a kexec rebooting: esrt: Unsupported ESRT version 2904149718861218184. The ESRT memory stays in EFI boot services data, and it was reserved in kernel via

Re: [RFC PATCH] PCI, kdump: Clear bus master bit upon shutdown in kdump kernel

2020-01-11 Thread Baoquan He
On 01/10/20 at 08:45pm, Khalid Aziz wrote: > >> - if (kexec_in_progress && (pci_dev->current_state <= PCI_D3hot)) > >> + if ((kexec_in_progress || is_kdump_kernel()) && > >> + pci_dev->current_state <= PCI_D3hot) > >>

Re: [RFC PATCH] PCI, kdump: Clear bus master bit upon shutdown in kdump kernel

2020-01-11 Thread Kairui Song
On Sat, Jan 11, 2020 at 11:46 AM Khalid Aziz wrote: > > On 1/10/20 5:50 PM, Baoquan He wrote: > > On 01/10/20 at 05:18pm, Khalid Aziz wrote: > >> On 1/10/20 4:00 PM, Jerry Hoemann wrote: > >>> On Fri, Jan 10, 2020 at 03:25:36PM -0700, Khalid Aziz and Shuah Khan > >>> wrote: > On 1/10/20

Re: [RFC PATCH] PCI, kdump: Clear bus master bit upon shutdown in kdump kernel

2020-01-11 Thread Kairui Song
On Sat, Jan 11, 2020 at 8:45 AM Baoquan He wrote: > On 01/10/20 at 04:00pm, Jerry Hoemann wrote: > > > I am not understanding this failure mode either. That code in > > > pci_device_shutdown() was added originally to address this very issue. > > > The patch 4fc9bbf98fd6 ("PCI: Disable Bus Master

Re: [RFC PATCH] PCI, kdump: Clear bus master bit upon shutdown in kdump kernel

2020-01-11 Thread Kairui Song
On Sat, Jan 11, 2020 at 5:42 AM Bjorn Helgaas wrote: > > Can you help me understand the sequence of events? If I understand > correctly, the desired sequence is: > > - user kernel boots > - user kernel panics and kexecs to kdump kernel One thing imported need to be mentioned here, user