RE: [PATCH v2 1/1] Calculate offset to field 'init_uts_ns.name'

2020-09-17 Thread Alexander Egorenkov
HAGIO KAZUHITO(萩尾 一仁)writes: > Thank you for catching this and the patch. > > but do you know the kernel patch corresponding to this patch, i.e. adds > the OFFSET(init_uts_ns.name) (strictly, OFFSET(uts_namespace.name) probably) > entry to vmcoreinfo? The makedumpfile usually just read it fr

Re: [PATCH] MIPS: Loongson64: Add kexec/kdump support

2020-09-17 Thread Jinyang He
Hi, Huacai, On 09/16/2020 01:39 PM, Huacai Chen wrote: Hi, Jinyang, On Tue, Sep 15, 2020 at 10:17 PM Jinyang He wrote: On 09/16/2020 09:33 AM, Jiaxun Yang wrote: 于 2020年9月15日 GMT+08:00 下午9:07:43, Jinyang He 写到: Add loongson_kexec_prepare(), loongson_kexec_shutdown() and loongson_kexec_c

[PATCH printk 2/3] printk: move dictionary keys to dev_printk_info

2020-09-17 Thread John Ogness
Dictionaries are only used for SUBSYSTEM and DEVICE properties. The current implementation stores the property names each time they are used. This requires more space than otherwise necessary. Also, because the dictionary entries are currently considered optional, it cannot be relied upon that they

[PATCH printk 0/3] printk: move dictionaries to meta data

2020-09-17 Thread John Ogness
Hello, Here is a series to move dictionary properties (currently only SUBSYSTEM and DEVICE exist) into the meta data of a record, thus eliminating the need for the dict ring. This change affects how the dictionaries are stored, but does not affect how they are presented to userspace. The main pur

[PATCH printk 1/3] printk: move printk_info into separate array

2020-09-17 Thread John Ogness
The majority of the size of a descriptor is taken up by meta data, which is often not of interest to the ringbuffer (for example, when performing state checks). Since descriptors are often temporarily stored on the stack, keeping their size minimal will help reduce stack pressure. Rather than embe

[PATCH printk 3/3] printk: remove dict ring

2020-09-17 Thread John Ogness
Since there is no code that will ever store anything into the dict ring, remove it. If any future dictionary properties are to be added, these should be added to the struct printk_info. Signed-off-by: John Ogness --- kernel/printk/printk.c| 45 +++-- kernel/printk/printk_ringbuf

Re: [PATCH] MIPS: Loongson64: Add kexec/kdump support

2020-09-17 Thread Zhou Yanjie
Hello, 在 2020/9/17 下午8:41, Jinyang He 写道: Hi, Huacai, On 09/16/2020 01:39 PM, Huacai Chen wrote: Hi, Jinyang, On Tue, Sep 15, 2020 at 10:17 PM Jinyang He wrote: On 09/16/2020 09:33 AM, Jiaxun Yang wrote: 于 2020年9月15日 GMT+08:00 下午9:07:43, Jinyang He 写到: Add loongson_kexec_prepare(), l

Re: [PATCH] MIPS: Loongson64: Add kexec/kdump support

2020-09-17 Thread Jiaxun Yang
在 2020/9/17 20:41, Jinyang He 写道: Hi, Huacai, On 09/16/2020 01:39 PM, Huacai Chen wrote: Hi, Jinyang, On Tue, Sep 15, 2020 at 10:17 PM Jinyang He wrote: On 09/16/2020 09:33 AM, Jiaxun Yang wrote: 于 2020年9月15日 GMT+08:00 下午9:07:43, Jinyang He 写到: Add loongson_kexec_prepare(), loongson

RE: [PATCH v2 1/1] Calculate offset to field 'init_uts_ns.name'

2020-09-17 Thread Alexander Egorenkov
HAGIO KAZUHITO(萩尾 一仁)writes: > > Thank you for catching this and the patch. > > but do you know the kernel patch corresponding to this patch, i.e. adds > the OFFSET(init_uts_ns.name) (strictly, OFFSET(uts_namespace.name) probably) > entry to vmcoreinfo? The makedumpfile usually just read it f

Re: [PATCH printk 3/3] printk: remove dict ring

2020-09-17 Thread Linus Torvalds
On Thu, Sep 17, 2020 at 6:16 AM John Ogness wrote: > > Since there is no code that will ever store anything into the dict > ring, remove it. If any future dictionary properties are to be > added, these should be added to the struct printk_info. Ack. I'm very happy to see the dictionary stuff go.

[PATCH] arm64: Add purgatory printing

2020-09-17 Thread matthias . bgg
From: Matthias Brugger Add option to allow purgatory printing on arm64 hardware by passing the console name which should be used. Based on a patch by Geoff Levand. Cc: Geoff Levand Signed-off-by: Matthias Brugger --- kexec/arch/arm64/include/arch/options.h | 6 ++- kexec/arch/arm64/kexec-arm

[PATCH AUTOSEL 5.4 047/330] x86/kdump: Always reserve the low 1M when the crashkernel option is specified

2020-09-17 Thread Sasha Levin
From: Lianbo Jiang [ Upstream commit 6f599d84231fd27e42f4ca2a786a6641e8cddf00 ] On x86, purgatory() copies the first 640K of memory to a backup region because the kernel needs those first 640K for the real mode trampoline during boot, among others. However, when SME is enabled, the kernel canno

Re: [PATCH] arm64: Add purgatory printing

2020-09-17 Thread Geoff Levand
Hi Matthias, On 9/17/20 12:38 PM, matthias@kernel.org wrote: Add option to allow purgatory printing on arm64 hardware > by passing the console name which should be used. > +static uint64_t find_purgatory_sink(const char *console) > +{ > + int fd, ret; > + char folder[255], device[255]

RE: [PATCH v2 1/1] Calculate offset to field 'init_uts_ns.name'

2020-09-17 Thread 萩尾 一仁
Hi Alex, -Original Message- > HAGIO KAZUHITO(萩尾 一仁) writes: > > > > > Thank you for catching this and the patch. > > > > but do you know the kernel patch corresponding to this patch, i.e. adds > > the OFFSET(init_uts_ns.name) (strictly, OFFSET(uts_namespace.name) probably) > > entry to v

Re: [PATCH v12 3/9] x86: kdump: use macro CRASH_ADDR_LOW_MAX in functions reserve_crashkernel[_low]()

2020-09-17 Thread Dave Young
On 09/07/20 at 09:47pm, Chen Zhou wrote: > To make the functions reserve_crashkernel[_low]() as generic, > replace some hard-coded numbers with macro CRASH_ADDR_LOW_MAX. > > Signed-off-by: Chen Zhou > --- > arch/x86/kernel/setup.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(

[PATCH] Only allow to set crash_kexec_post_notifiers on boot time

2020-09-17 Thread Dave Young
crash_kexec_post_notifiers enables running various panic notifier before kdump kernel booting. This increases risks of kdump failure. It is well documented in kernel-parameters.txt. We do not suggest people to enable it together with kdump unless he/she is really sure. This is also not suggested to

Re: [PATCH v12 3/9] x86: kdump: use macro CRASH_ADDR_LOW_MAX in functions reserve_crashkernel[_low]()

2020-09-17 Thread chenzhou
Hi Dave, On 2020/9/18 11:01, Dave Young wrote: > On 09/07/20 at 09:47pm, Chen Zhou wrote: >> To make the functions reserve_crashkernel[_low]() as generic, >> replace some hard-coded numbers with macro CRASH_ADDR_LOW_MAX. >> >> Signed-off-by: Chen Zhou >> --- >> arch/x86/kernel/setup.c | 11

Re: [PATCH] arm64: Add purgatory printing

2020-09-17 Thread Bhupesh SHARMA
Hi Matthias, Thanks for the patch. Some nitpicks inline: On Fri, Sep 18, 2020 at 1:09 AM wrote: > > From: Matthias Brugger > > Add option to allow purgatory printing on arm64 hardware > by passing the console name which should be used. > Based on a patch by Geoff Levand. > > Cc: Geoff Levand >

Re: [PATCH v12 3/9] x86: kdump: use macro CRASH_ADDR_LOW_MAX in functions reserve_crashkernel[_low]()

2020-09-17 Thread Dave Young
On 09/18/20 at 11:57am, chenzhou wrote: > Hi Dave, > > > On 2020/9/18 11:01, Dave Young wrote: > > On 09/07/20 at 09:47pm, Chen Zhou wrote: > >> To make the functions reserve_crashkernel[_low]() as generic, > >> replace some hard-coded numbers with macro CRASH_ADDR_LOW_MAX. > >> > >> Signed-off-b

RE: [PATCH v5 1/3] tree-wide: Retrieve 'MAX_PHYSMEM_BITS' from vmcoreinfo (if available)

2020-09-17 Thread 萩尾 一仁
Hi Bhupesh, -Original Message- > This patch adds a common feature for archs (except arm64, for which > similar support is added via subsequent patch) to retrieve > 'MAX_PHYSMEM_BITS' from vmcoreinfo (if available). > > I recently posted a kernel patch (see [0]) which appends > 'MAX_PHYSME

Re: [PATCH printk 2/3] printk: move dictionary keys to dev_printk_info

2020-09-17 Thread Rasmus Villemoes
On 17/09/2020 15.16, John Ogness wrote: > if (dev->class) > subsys = dev->class->name; > else if (dev->bus) > subsys = dev->bus->name; > else > - return 0; > + return; > > - pos += snprintf(hdr + pos, hdrlen - pos, "SUBSYS

Re: [PATCH] MIPS: Loongson64: Add kexec/kdump support

2020-09-17 Thread Jinyang He
On 09/17/2020 09:52 PM, Zhou Yanjie wrote: Hello, 在 2020/9/17 下午8:41, Jinyang He 写道: Hi, Huacai, On 09/16/2020 01:39 PM, Huacai Chen wrote: Hi, Jinyang, On Tue, Sep 15, 2020 at 10:17 PM Jinyang He wrote: On 09/16/2020 09:33 AM, Jiaxun Yang wrote: 于 2020年9月15日 GMT+08:00 下午9:07:43, Jinya

Re: [PATCH] MIPS: Loongson64: Add kexec/kdump support

2020-09-17 Thread Jinyang He
On 09/17/2020 10:21 PM, Jiaxun Yang wrote: 在 2020/9/17 20:41, Jinyang He 写道: Hi, Huacai, On 09/16/2020 01:39 PM, Huacai Chen wrote: Hi, Jinyang, On Tue, Sep 15, 2020 at 10:17 PM Jinyang He wrote: On 09/16/2020 09:33 AM, Jiaxun Yang wrote: 于 2020年9月15日 GMT+08:00 下午9:07:43, Jinyang He