Re: [PATCH V2 4/6] mm: rename the global section array to mem_sections

2021-06-01 Thread David Hildenbrand
On 31.05.21 11:19, Dong Aisheng wrote: In order to distinguish the struct mem_section for a better code readability and align with kernel doc [1] name below, change the global mem section name to 'mem_sections' from 'mem_section'. [1] Documentation/vm/memory-model.rst "The `mem_section` objects

Re: [PATCH v2 1/5] arm64: kexec_file: Forbid non-crash kernels

2021-06-01 Thread Marc Zyngier
On Mon, 31 May 2021 20:37:49 +0100, Ard Biesheuvel wrote: > > On Mon, 31 May 2021 at 11:57, Marc Zyngier wrote: > > > > It has been reported that kexec_file doesn't really work on arm64. > > It completely ignores any of the existing reservations, which results > > in the secondary kernel being l

Re: [PATCH V2 4/6] mm: rename the global section array to mem_sections

2021-06-01 Thread Dong Aisheng
On Tue, Jun 1, 2021 at 4:22 PM David Hildenbrand wrote: > > On 31.05.21 11:19, Dong Aisheng wrote: > > In order to distinguish the struct mem_section for a better code > > readability and align with kernel doc [1] name below, change the > > global mem section name to 'mem_sections' from 'mem_secti

Re: [PATCH V2 4/6] mm: rename the global section array to mem_sections

2021-06-01 Thread David Hildenbrand
On 01.06.21 10:37, Dong Aisheng wrote: On Tue, Jun 1, 2021 at 4:22 PM David Hildenbrand wrote: On 31.05.21 11:19, Dong Aisheng wrote: In order to distinguish the struct mem_section for a better code readability and align with kernel doc [1] name below, change the global mem section name to 'm

Re: [PATCH V2 4/6] mm: rename the global section array to mem_sections

2021-06-01 Thread Dong Aisheng
On Tue, Jun 1, 2021 at 4:40 PM David Hildenbrand wrote: > > On 01.06.21 10:37, Dong Aisheng wrote: > > On Tue, Jun 1, 2021 at 4:22 PM David Hildenbrand wrote: > >> > >> On 31.05.21 11:19, Dong Aisheng wrote: > >>> In order to distinguish the struct mem_section for a better code > >>> readability

Re: [PATCH 03/18] arm64: hyp-stub: Move elx_sync into the vectors

2021-06-01 Thread Marc Zyngier
On Thu, 27 May 2021 22:23:22 +0100, Pavel Tatashin wrote: > > On Thu, May 27, 2021 at 11:54 AM Marc Zyngier wrote: > > > > On Thu, 27 May 2021 16:05:11 +0100, > > Pavel Tatashin wrote: > > > > > > The hyp-stub's elx_sync code fits in the vector. > > > > > > With this, all of the hyp-stubs behav

Re: [PATCH 04/18] arm64: kernel: add helper for booted at EL2 and not VHE

2021-06-01 Thread Marc Zyngier
On Thu, 27 May 2021 16:05:12 +0100, Pavel Tatashin wrote: > > Replace places that contain logic like this: > is_hyp_mode_available() && !is_kernel_in_hyp_mode() > > With a dedicated boolean function is_hyp_callable(). This will be needed > later in kexec in order to sooner switch back to

Re: [PATCH V2 4/6] mm: rename the global section array to mem_sections

2021-06-01 Thread Andrew Morton
On Tue, 1 Jun 2021 10:40:09 +0200 David Hildenbrand wrote: > > Thanks, i explained the reason during my last reply. > > Andrew has already picked this patch to -mm tree. > > Just because it's in Andrews tree doesn't mean it will end up upstream. ;) > > Anyhow, no really strong opinion, it's sim

Re: [PATCH v2 1/4] kprobes: Fix spelling mistakes

2021-06-01 Thread Masami Hiramatsu
On Sat, 29 May 2021 19:03:02 +0800 Zhen Lei wrote: > Fix some spelling mistakes in comments: > decrese ==> decrease > immmediately ==> immediately This looks good to me. Acked-by: Masami Hiramatsu Thanks! > > Signed-off-by: Zhen Lei > --- > include/linux/freelist.h | 2 +- > kernel/kprobe

RE: [PATCH V2 4/6] mm: rename the global section array to mem_sections

2021-06-01 Thread 萩尾 一仁
-Original Message- > On Tue, 1 Jun 2021 10:40:09 +0200 David Hildenbrand wrote: > > > > Thanks, i explained the reason during my last reply. > > > Andrew has already picked this patch to -mm tree. > > > > Just because it's in Andrews tree doesn't mean it will end up upstream. ;) > > > > A

Re: [PATCH 03/18] arm64: hyp-stub: Move elx_sync into the vectors

2021-06-01 Thread Pavel Tatashin
> > It cannot call mutate_to_vhe because #HVC_VHE_RESTART is not used > > here. But, if it had to it would not work as we cannot return to the > > old kernel text after relocation. > > OK, so you are happy with having a dangling branch pointing to > nowhere? Something in me screams that it isn't a

Re: [PATCH 04/18] arm64: kernel: add helper for booted at EL2 and not VHE

2021-06-01 Thread Pavel Tatashin
On Tue, Jun 1, 2021 at 8:38 AM Marc Zyngier wrote: > > On Thu, 27 May 2021 16:05:12 +0100, > Pavel Tatashin wrote: > > > > Replace places that contain logic like this: > > is_hyp_mode_available() && !is_kernel_in_hyp_mode() > > > > With a dedicated boolean function is_hyp_callable(). This

Re: [PATCH V2 4/6] mm: rename the global section array to mem_sections

2021-06-01 Thread Andrew Morton
On Wed, 2 Jun 2021 01:11:07 + HAGIO KAZUHITO(萩尾 一仁) wrote: > -Original Message- > > On Tue, 1 Jun 2021 10:40:09 +0200 David Hildenbrand > > wrote: > > > > > > Thanks, i explained the reason during my last reply. > > > > Andrew has already picked this patch to -mm tree. > > > > > >

Re: [PATCH V2 4/6] mm: rename the global section array to mem_sections

2021-06-01 Thread Baoquan He
On 06/02/21 at 01:11am, HAGIO KAZUHITO(萩尾 一仁) wrote: > -Original Message- > > On Tue, 1 Jun 2021 10:40:09 +0200 David Hildenbrand > > wrote: > > > > > > Thanks, i explained the reason during my last reply. > > > > Andrew has already picked this patch to -mm tree. > > > > > > Just because

RE: [PATCH V2 4/6] mm: rename the global section array to mem_sections

2021-06-01 Thread 萩尾 一仁
-Original Message- > On 06/02/21 at 01:11am, HAGIO KAZUHITO(萩尾 一仁) wrote: > > -Original Message- > > > On Tue, 1 Jun 2021 10:40:09 +0200 David Hildenbrand > > > wrote: > > > > > > > > Thanks, i explained the reason during my last reply. > > > > > Andrew has already picked this pat

Re: [PATCH V2 4/6] mm: rename the global section array to mem_sections

2021-06-01 Thread Baoquan He
On 06/02/21 at 05:02am, HAGIO KAZUHITO(萩尾 一仁) wrote: > -Original Message- > > On 06/02/21 at 01:11am, HAGIO KAZUHITO(萩尾 一仁) wrote: > > > -Original Message- > > > > On Tue, 1 Jun 2021 10:40:09 +0200 David Hildenbrand > > > > wrote: > > > > > > > > > > Thanks, i explained the reason