Re: [PATCH v2] proc/vmcore: fix clearing user buffer by properly using clear_user()

2021-11-16 Thread David Hildenbrand
On 15.11.21 23:04, Andrew Morton wrote: > On Fri, 12 Nov 2021 10:27:50 +0100 David Hildenbrand wrote: > >> To clear a user buffer we cannot simply use memset, we have to use >> clear_user(). With a virtio-mem device that registers a vmcore_cb and has >> some logically unplugged memory inside an a

Re: [PATCH v2 RESEND 2/2] s390/kexec: fix memory leak of ipl report buffer

2021-11-16 Thread Heiko Carstens
On Tue, Nov 16, 2021 at 11:31:01AM +0800, Baoquan He wrote: > unreferenced object 0x38000195000 (size 4096): > comm "kexec", pid 8548, jiffies 4294953647 (age 32443.270s) > hex dump (first 32 bytes): > 00 00 00 c8 20 00 00 00 00 00 00 c0 02 80 00 00 ... > 40 40 40 40 40 40

Re: [PATCH v2 1/2] s390/kexec: check the return value of ipl_report_finish

2021-11-16 Thread Heiko Carstens
On Tue, Nov 16, 2021 at 11:25:56AM +0800, Baoquan He wrote: > In function ipl_report_finish(), it could fail by memory allocation > failure, so check the return value to handle the case. > > Signed-off-by: Baoquan He > --- > arch/s390/include/asm/ipl.h | 2 +- > arch/s390/kernel/ipl.c

Re: [PATCH v2 1/2] s390/kexec: check the return value of ipl_report_finish

2021-11-16 Thread Baoquan He
On 11/16/21 at 12:17pm, Heiko Carstens wrote: > On Tue, Nov 16, 2021 at 11:25:56AM +0800, Baoquan He wrote: > > In function ipl_report_finish(), it could fail by memory allocation > > failure, so check the return value to handle the case. > > > > Signed-off-by: Baoquan He > > --- > > arch/s390/i