Re: [PATCH v3 0/3] Convert vmcore to use an iov_iter

2021-12-21 Thread Baoquan He
On 12/13/21 at 02:39pm, Matthew Wilcox (Oracle) wrote: > For some reason several people have been sending bad patches to fix > compiler warnings in vmcore recently. Here's how it should be done. > Compile-tested only on x86. As noted in the first patch, s390 should > take this conversion a bit fu

Re: [PATCH v3 1/3] vmcore: Convert copy_oldmem_page() to take an iov_iter

2021-12-21 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v3 3/3] vmcore: Convert read_from_oldmem() to take an iov_iter

2021-12-21 Thread Christoph Hellwig
On Mon, Dec 13, 2021 at 02:39:27PM +, Matthew Wilcox (Oracle) wrote: > Remove the read_from_oldmem() wrapper introduced earlier and convert > all the remaining callers to pass an iov_iter. Looks good, Reviewed-by: Christoph Hellwig ___ kexec maili

Re: [PATCH v3 2/3] vmcore: Convert __read_vmcore to use an iov_iter

2021-12-21 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v3 5/5] mm/slub: do not create dma-kmalloc if no managed pages in DMA zone

2021-12-21 Thread Christoph Hellwig
On Fri, Dec 17, 2021 at 11:38:27AM +, Hyeonggon Yoo wrote: > My understanding is any buffer requested from kmalloc (without > GFP_DMA/DMA32) can be used by device driver because it allocates > continuous physical memory. It doesn't mean that buffer allocated > with kmalloc is free of addressing

Re: [PATCH v17 03/10] x86: kdump: use macro CRASH_ADDR_LOW_MAX in functions reserve_crashkernel()

2021-12-21 Thread Borislav Petkov
On Fri, Dec 17, 2021 at 10:51:04AM +0800, Leizhen (ThunderTown) wrote: > [KNL, X86-64], This doc is for X86-64, not for X86-32 reserve_crashkernel() runs on both. > If there is no such restriction, we can make CRASH_ADDR_LOW_MAX equal > to (1ULL << 32) minus 1 on X86_32. Again, the 4G limit chec