Re: [PATCH v3 6/6] crash hp: Add x86 crash hotplug support

2022-01-26 Thread Baoquan He
On 01/26/22 at 11:32am, Eric DeVolder wrote: ..snip > > > > > +void arch_crash_hotplug_handler(struct kimage *image, > > > > > + unsigned int hp_action, unsigned long a, unsigned long b) > > > > > +{ > > > > > + /* > > > > > + * To accurately reflect hot un/plug changes, the

Re: [PATCH v3 0/6] crash: Kernel handling of CPU and memory hot un/plug

2022-01-26 Thread Baoquan He
Hi Eric, On 01/10/22 at 02:57pm, Eric DeVolder wrote: > When the kdump service is loaded, if a CPU or memory is hot > un/plugged, the crash elfcorehdr (for x86), which describes the CPUs > and memory in the system, must also be updated, else the resulting > vmcore is inaccurate (eg. missing

Re: [PATCH v3 6/6] crash hp: Add x86 crash hotplug support

2022-01-26 Thread Eric DeVolder
Baoquan, Thanks for looking at this! See inline response below. eric On 1/26/22 03:12, Baoquan He wrote: On 01/21/22 at 08:06am, Eric DeVolder wrote: .. arch/x86/kernel/crash.c | 138 +++- 1 file changed, 137 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v20 5/5] kdump: update Documentation about crashkernel

2022-01-26 Thread john . p . donnelly
On 1/24/22 2:47 AM, Zhen Lei wrote: From: Chen Zhou For arm64, the behavior of crashkernel=X has been changed, which tries low allocation in DMA zone and fall back to high allocation if it fails. We can also use "crashkernel=X,high" to select a high region above DMA zone, which also tries to

Re: [PATCH v20 4/5] of: fdt: Add memory for devices by DT property "linux,usable-memory-range"

2022-01-26 Thread john . p . donnelly
On 1/24/22 2:47 AM, Zhen Lei wrote: From: Chen Zhou When reserving crashkernel in high memory, some low memory is reserved for crash dump kernel devices and never mapped by the first kernel. This memory range is advertised to crash dump kernel via DT property under /chosen,

Re: [PATCH v20 3/5] arm64: kdump: reimplement crashkernel=X

2022-01-26 Thread john . p . donnelly
On 1/24/22 2:47 AM, Zhen Lei wrote: From: Chen Zhou There are following issues in arm64 kdump: 1. We use crashkernel=X to reserve crashkernel below 4G, which will fail when there is no enough low memory. 2. If reserving crashkernel above 4G, in this case, crash dump kernel will boot failure

Re: [PATCH v20 2/5] arm64: kdump: introduce some macros for crash kernel reservation

2022-01-26 Thread john . p . donnelly
On 1/24/22 2:47 AM, Zhen Lei wrote: From: Chen Zhou Introduce macro CRASH_ALIGN for alignment, macro CRASH_ADDR_LOW_MAX for upper bound of low crash memory, macro CRASH_ADDR_HIGH_MAX for upper bound of high crash memory, use macros instead. Signed-off-by: Chen Zhou Signed-off-by: Zhen Lei

Re: [PATCH v20 1/5] arm64: Use insert_resource() to simplify code

2022-01-26 Thread john . p . donnelly
On 1/24/22 2:47 AM, Zhen Lei wrote: insert_resource() traverses the subtree layer by layer from the root node until a proper location is found. Compared with request_resource(), the parent node does not need to be determined in advance. In addition, move the insertion of node 'crashk_res' into

Re: [PATCH] kexec: disable cpu hotplug until the rebooting cpu is stable

2022-01-26 Thread Valentin Schneider
On 26/01/22 10:45, Pingfan Liu wrote: > On Wed, Jan 26, 2022 at 12:29 AM Valentin Schneider > wrote: >> >> On 25/01/22 11:39, Pingfan Liu wrote: >> > The following identical code piece appears in both >> > migrate_to_reboot_cpu() and smp_shutdown_nonboot_cpus(): >> > >> > if

Re: [PATCH v2 07/12] x86/sev: Setup code to park APs in the AP Jump Table

2022-01-26 Thread Joerg Roedel
On Wed, Nov 10, 2021 at 05:37:32PM +0100, Borislav Petkov wrote: > On Mon, Sep 13, 2021 at 05:55:58PM +0200, Joerg Roedel wrote: > > extern unsigned char real_mode_blob[]; > > diff --git a/arch/x86/include/asm/sev-ap-jumptable.h > > b/arch/x86/include/asm/sev-ap-jumptable.h > > new file mode

Re: [PATCH V4] notifier/panic: Introduce panic_notifier_filter

2022-01-26 Thread Petr Mladek
On Wed 2022-01-26 11:10:39, Baoquan He wrote: > On 01/24/22 at 11:48am, Guilherme G. Piccoli wrote: > > On 24/01/2022 10:59, Baoquan He wrote: > > > [...] > > > About pre_dump, if the dump is crash dump, hope those pre_dump notifiers > > > will be executed under conditional check, e.g only if > >

Re: [PATCH V4] notifier/panic: Introduce panic_notifier_filter

2022-01-26 Thread d.hatay...@fujitsu.com
> On 01/24/22 at 11:48am, Guilherme G. Piccoli wrote: > > On 24/01/2022 10:59, Baoquan He wrote: > > > [...] > > > About pre_dump, if the dump is crash dump, hope those pre_dump notifiers > > > will be executed under conditional check, e.g only if > > > 'crash_kexec_post_notifiers' > > > is

Re: [PATCH V3] panic: Move panic_print before kmsg dumpers

2022-01-26 Thread Petr Mladek
On Mon 2022-01-24 16:57:17, Michael Kelley (LINUX) wrote: > From: Baoquan He Sent: Friday, January 21, 2022 8:34 PM > > > > On 01/21/22 at 03:00pm, Michael Kelley (LINUX) wrote: > > > From: Baoquan He Sent: Thursday, January 20, 2022 6:31 > > > PM > > > > > > > > On 01/20/22 at 06:36pm,

[PATCH 0/2] kexec-tools: mips: Modify some code

2022-01-26 Thread Tiezhu Yang
Tiezhu Yang (2): kexec-tools: mips: Add some debug info kexec-tools: mips: Concatenate --reuse-cmdline and --append kexec/arch/mips/kexec-mips.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) -- 2.1.0 ___ kexec mailing

[PATCH 2/2] kexec-tools: mips: Concatenate --reuse-cmdline and --append

2022-01-26 Thread Tiezhu Yang
Use concat_cmdline() to concatenate the --append string and the --reuse-cmdline string, otherwise only one of the two options is valid. This is similar with commit 8b42c99aa3bc ("Fix --reuse-cmdline so it is usable."). Signed-off-by: Tiezhu Yang --- kexec/arch/mips/kexec-mips.c | 8 ++-- 1

[PATCH 1/2] kexec-tools: mips: Add some debug info

2022-01-26 Thread Tiezhu Yang
Use dbgprintf() to print command_line, initrd and dtb in arch_process_options() for debugging. Signed-off-by: Tiezhu Yang --- kexec/arch/mips/kexec-mips.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/kexec/arch/mips/kexec-mips.c b/kexec/arch/mips/kexec-mips.c index

Re: [PATCH v2 03/12] x86/sev: Save and print negotiated GHCB protocol version

2022-01-26 Thread Joerg Roedel
On Wed, Nov 03, 2021 at 03:27:23PM +0100, Borislav Petkov wrote: > On Mon, Sep 13, 2021 at 05:55:54PM +0200, Joerg Roedel wrote: > > From: Joerg Roedel > > > > Save the results of the GHCB protocol negotiation into a data structure > > and print information about versions supported and used to

Re: [PATCH v3 6/6] crash hp: Add x86 crash hotplug support

2022-01-26 Thread Baoquan He
On 01/21/22 at 08:06am, Eric DeVolder wrote: .. > > > arch/x86/kernel/crash.c | 138 +++- > > > 1 file changed, 137 insertions(+), 1 deletion(-) > > > > > > diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c > > > index

Re: [PATCH v3 3/6] crash hp: definitions and prototype changes

2022-01-26 Thread Baoquan He
On 01/21/22 at 07:48am, Eric DeVolder wrote: .. > > > diff --git a/include/linux/kexec.h b/include/linux/kexec.h > > > index 0c994ae37729..068f853f1c65 100644 > > > --- a/include/linux/kexec.h > > > +++ b/include/linux/kexec.h > > > @@ -221,8 +221,9 @@ struct crash_mem { > > > extern int