Re: [PATCHv2] kexec: disable cpu hotplug until the rebooting cpu is stable

2022-01-27 Thread Pingfan Liu
On Thu, Jan 27, 2022 at 05:41:44PM +0800, Baoquan He wrote: Hi Baoquan, Thanks for reviewing, please see comment inlined > Hi Pingfan, > > On 01/27/22 at 05:02pm, Pingfan Liu wrote: > > The following identical code piece appears in both > > migrate_to_reboot_cpu() and

Re: [RFC PATCH] kdump: Add support for crashkernel=auto

2022-01-27 Thread Tiezhu Yang
On 01/27/2022 11:53 PM, Petr Tesařík wrote: Hi Tiezhu Yang, I'm afraid the whole concept is broken by design. See below. Dne 27. 01. 22 v 10:31 Tiezhu Yang napsal(a): Set the reserved memory automatically for the crash kernel based on architecture. Most code of this patch come from:

Re: [PATCH V4] notifier/panic: Introduce panic_notifier_filter

2022-01-27 Thread Guilherme G. Piccoli
On 25/01/2022 10:06, d.hatay...@fujitsu.com wrote: > > But the pre_dump cannot avoid calling multiple unnecessary handlers, right? > It's more risky than the previous idea... > I think we could have 2 kernel parameters then: crash_kernel_disable_pre_notitifers (of course we can think in some

Re: [PATCH V4] panic: Move panic_print before kmsg dumpers

2022-01-27 Thread Guilherme G. Piccoli
On 26/01/2022 02:22, Baoquan He wrote: > [...] >> if (!_crash_kexec_post_notifiers) { >> +if (kexec_crash_loaded()) >> +panic_print_sys_info(false); >> + > > Please reconsider this change. As I said in another thread, it's not > suggested when adding any

Re: [RFC PATCH] kdump: Add support for crashkernel=auto

2022-01-27 Thread Petr Tesařík
Hi Tiezhu Yang, I'm afraid the whole concept is broken by design. See below. Dne 27. 01. 22 v 10:31 Tiezhu Yang napsal(a): Set the reserved memory automatically for the crash kernel based on architecture. Most code of this patch come from:

Re: [PATCH v3 0/3] Convert vmcore to use an iov_iter

2022-01-27 Thread Baoquan He
Hi, On 01/01/22 at 12:36am, Al Viro wrote: > On Mon, Dec 13, 2021 at 02:39:24PM +, Matthew Wilcox (Oracle) wrote: > > For some reason several people have been sending bad patches to fix > > compiler warnings in vmcore recently. Here's how it should be done. > > Compile-tested only on x86.

Re: [PATCHv2] kexec: disable cpu hotplug until the rebooting cpu is stable

2022-01-27 Thread Baoquan He
Hi Pingfan, On 01/27/22 at 05:02pm, Pingfan Liu wrote: > The following identical code piece appears in both > migrate_to_reboot_cpu() and smp_shutdown_nonboot_cpus(): > > if (!cpu_online(primary_cpu)) > primary_cpu = cpumask_first(cpu_online_mask); > > This is due to a

[RFC PATCH] kdump: Add support for crashkernel=auto

2022-01-27 Thread Tiezhu Yang
Set the reserved memory automatically for the crash kernel based on architecture. Most code of this patch come from: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-8/-/tree/c8s Signed-off-by: Tiezhu Yang --- Documentation/admin-guide/kdump/kdump.rst | 13 +

[PATCHv2] kexec: disable cpu hotplug until the rebooting cpu is stable

2022-01-27 Thread Pingfan Liu
The following identical code piece appears in both migrate_to_reboot_cpu() and smp_shutdown_nonboot_cpus(): if (!cpu_online(primary_cpu)) primary_cpu = cpumask_first(cpu_online_mask); This is due to a breakage like the following: migrate_to_reboot_cpu();

Re: [PATCH v2 08/12] x86/sev: Park APs on AP Jump Table with GHCB protocol version 2

2022-01-27 Thread Joerg Roedel
On Fri, Nov 12, 2021 at 05:33:05PM +0100, Borislav Petkov wrote: > On Mon, Sep 13, 2021 at 05:55:59PM +0200, Joerg Roedel wrote: > > +"ljmpl *%0" : : > > +"m" (real_mode_header->sev_real_ap_park_asm), > > +"b" (sev_es_jump_table_pa >> 4)); > >

Re: [PATCH] kexec: disable cpu hotplug until the rebooting cpu is stable

2022-01-27 Thread Pingfan Liu
On Wed, Jan 26, 2022 at 11:06 PM Valentin Schneider wrote: > > On 26/01/22 10:45, Pingfan Liu wrote: > > On Wed, Jan 26, 2022 at 12:29 AM Valentin Schneider > > wrote: > >> > >> On 25/01/22 11:39, Pingfan Liu wrote: > >> > The following identical code piece appears in both > >> >