Re: [PATCH V6] panic: Move panic_print before kmsg dumpers

2022-02-24 Thread Sergey Senozhatsky
Correction: On (22/02/25 14:18), Sergey Senozhatsky wrote: > > > > Or just split panic_printk_sys_info() into these two functions. > > Agreed. I also tend to think that panic_printk_sys_info() is needed anyway, split

Re: [PATCH V6] panic: Move panic_print before kmsg dumpers

2022-02-24 Thread Sergey Senozhatsky
On (22/02/24 15:33), Petr Mladek wrote: > > My bad! I did not spot the `return` at the end of the new branch. > > > > + if (console_flush) { > > + if (panic_print & PANIC_PRINT_ALL_PRINTK_MSG) > > + console_flush_on_panic(CONSOLE_REPLAY_ALL); > > +

Re: Compile error ppc64le: Cannot find symbol for section 11: .text.unlikely.

2022-02-24 Thread Coiby Xu
On Fri, Dec 03, 2021 at 04:54:19PM +0100, Veronika Kabatova wrote: On Wed, Dec 1, 2021 at 3:20 AM Coiby Xu wrote: On Wed, Nov 24, 2021 at 09:47:43PM +0800, Baoquan He wrote: >On 11/24/21 at 01:47pm, Veronika Kabatova wrote: >> Hi, >> >> for a while we've been seen the following error when

Re: [PATCH V6] panic: Move panic_print before kmsg dumpers

2022-02-24 Thread Guilherme G. Piccoli
On 24/02/2022 11:33, Petr Mladek wrote: > [...] > That said, I could live with the patch as is. I leave the decision > to Andrew. Feel free to use: > > Reviewed-by: Petr Mladek > > Best Regards, > Petr Thanks a bunch Petr and Sergey for the reviews (and the tags). I also vote to keep the

Re: [PATCH V6] panic: Move panic_print before kmsg dumpers

2022-02-24 Thread Petr Mladek
On Wed 2022-02-23 01:27:35, Sergey Senozhatsky wrote: > On (22/02/22 11:10), Guilherme G. Piccoli wrote: > > On 21/02/2022 23:06, Sergey Senozhatsky wrote: > > > On (22/02/14 11:13), Guilherme G. Piccoli wrote: > > > [...] > > > By additional panic_print messages you mean that