Re: [PATCH v22 1/9] kdump: return -ENOENT if required cmdline option does not exist

2022-04-24 Thread Baoquan He
On 04/14/22 at 07:57pm, Zhen Lei wrote: > According to the current crashkernel=Y,low support in other ARCHes, it's > an optional command-line option. When it doesn't exist, kernel will try > to allocate minimum required memory below 4G automatically. > > However, __parse_crashkernel() returns '-EI

Re: [PATCH v5 RESEND 0/3] Convert vmcore to use an iov_iter

2022-04-24 Thread Baoquan He
Hi Andrew, On 04/08/22 at 05:06pm, Baoquan He wrote: > Copy the description of v3 cover letter from Willy: > === > For some reason several people have been sending bad patches to fix > compiler warnings in vmcore recently. Here's how it should be done. > Compile-tested only on x86. As noted in t

Re: [PATCH makedumpfile] Avoid false-positive mem_section validation with vmlinux

2022-04-24 Thread Pingfan Liu
On Mon, Apr 25, 2022 at 8:48 AM HAGIO KAZUHITO(萩尾 一仁) wrote: > > Hi Pingfan, > > -Original Message- > > On Wed, Apr 20, 2022 at 11:58:29PM +, HAGIO KAZUHITO(萩尾 一仁) wrote: > > > Currently get_mem_section() validates if SYMBOL(mem_section) is the > > > address > > > of the mem_section a

Re: [PATCH v22 0/9] support reserving crashkernel above 4G on arm64 kdump

2022-04-24 Thread Baoquan He
On 04/25/22 at 10:19am, Leizhen (ThunderTown) wrote: > > Hi, Catalin Marinas and Will Deacon: > Do you have time to review patches 3-4 and 6-7? These patches are a little > more > relevant to the arm64 architecture. > > Hi, Baoquan He: > Can you review patches 1 and 5 again? Yes, and I will

Re: [PATCH] kernel/crash_core.c: No judgment required

2022-04-24 Thread Baoquan He
On 12/14/21 at 05:32pm, Philipp Rudo wrote: > Hi lizhe, > > On Thu, 9 Dec 2021 19:20:03 -0800 > lizhe wrote: > > > No judgment required ck_cmdline is NULL > > its caller has alreadly judged, see __parse_crashkernel > > function > > > > Signed-off-by: lizhe > > --- > > kernel/crash_core.c | 3

Re: [PATCH sysctl-testing v2] kernel/kexec_core: move kexec_core sysctls into its own file

2022-04-24 Thread Baoquan He
On 04/24/22 at 10:57am, yingelin wrote: > This move the kernel/kexec_core.c respective sysctls to its own file. > > kernel/sysctl.c has grown to an insane mess, We move sysctls to places > where features actually belong to improve the readability and reduce > merge conflicts. At the same time, the

RE: [PATCH makedumpfile] Avoid false-positive mem_section validation with vmlinux

2022-04-24 Thread 萩尾 一仁
Hi Pingfan, -Original Message- > On Wed, Apr 20, 2022 at 11:58:29PM +, HAGIO KAZUHITO(萩尾 一仁) wrote: > > Currently get_mem_section() validates if SYMBOL(mem_section) is the address > > of the mem_section array first. But there was a report that the first > > validation wrongly returned

Re: [PATCH makedumpfile] Avoid false-positive mem_section validation with vmlinux

2022-04-24 Thread Pingfan Liu
On Wed, Apr 20, 2022 at 11:58:29PM +, HAGIO KAZUHITO(萩尾 一仁) wrote: > Currently get_mem_section() validates if SYMBOL(mem_section) is the address > of the mem_section array first. But there was a report that the first > validation wrongly returned TRUE with -x vmlinux and SPARSEMEM_EXTREME > (4