Re: [PATCH 24/30] panic: Refactor the panic path

2022-05-22 Thread Baoquan He
On 05/15/22 at 07:47pm, Guilherme G. Piccoli wrote: > On 12/05/2022 11:03, Petr Mladek wrote: .. > > OK, the question is how to make it better. Let's start with > > a clear picture of the problem: > > > > 1. panic() has basically two funtions: > > > > + show/store debug information (op

Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list

2022-05-22 Thread Guilherme G. Piccoli
On 18/05/2022 19:17, Scott Branden wrote: > Hi Guilherme, > > +Desmond > [...] I'm afraid it breaks kdump if this device is not reset beforehand - it's a doorbell write, so not high risk I think... But in case the not-reset device can be probed normally in kdump kernel, t

Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list

2022-05-22 Thread Guilherme G. Piccoli
On 19/05/2022 04:03, Petr Mladek wrote: > [...] > I would ignore it for now. If anyone would want to safe the log > then they would need to read it. They will most likely use > the existing kmsg_dump() infastructure. In fact, they should > use it to avoid a code duplication. > > Best Regards, > Pe

Re: [PATCH 24/30] panic: Refactor the panic path

2022-05-22 Thread Guilherme G. Piccoli
On 19/05/2022 20:45, Baoquan He wrote: > [...] >> I really appreciate the summary skill you have, to convert complex >> problems in very clear and concise ideas. Thanks for that, very useful! >> I agree with what was summarized above. > > I want to say the similar words to Petr's reviewing comment