Re: [PATCH] kexec: replace crash_mem_range with range

2022-06-23 Thread Baoquan He
Hi, On 06/15/22 at 07:37pm, Li Chen wrote: > Hi Baoquan, > > On Wed, 15 Jun 2022 19:03:53 -0700 Baoquan He wrote > > > On 06/14/22 at 10:04pm, Li Chen wrote: > > > From: Li Chen > > > > > > We already have struct range, so just use it. > > > > Looks good, have you tested it?

Re: [PATCHv7 11/14] x86: Disable kexec if system has unaccepted memory

2022-06-23 Thread Kirill A. Shutemov
On Thu, Jun 23, 2022 at 04:48:59PM -0500, Eric W. Biederman wrote: > Dave Hansen writes: > > > ... adding kexec folks > > > > On 6/14/22 05:02, Kirill A. Shutemov wrote: > >> On kexec, the target kernel has to know what memory has been accepted. > >> Information in EFI map is out of date and cann

Re: [PATCH v2] panic, kexec: Make __crash_kexec() NMI safe

2022-06-23 Thread Baoquan He
On 06/20/22 at 12:15pm, Valentin Schneider wrote: > Attempting to get a crash dump out of a debug PREEMPT_RT kernel via an NMI > panic() doesn't work. The cause of that lies in the PREEMPT_RT definition > of mutex_trylock(): > > if (IS_ENABLED(CONFIG_DEBUG_RT_MUTEXES) && WARN_ON_ONCE(!in_tas

Re: [PATCHv7 11/14] x86: Disable kexec if system has unaccepted memory

2022-06-23 Thread Eric W. Biederman
Dave Hansen writes: > ... adding kexec folks > > On 6/14/22 05:02, Kirill A. Shutemov wrote: >> On kexec, the target kernel has to know what memory has been accepted. >> Information in EFI map is out of date and cannot be used. >> >> boot_params.unaccepted_memory can be used to pass the bitmap b

Re: [PATCHv7 11/14] x86: Disable kexec if system has unaccepted memory

2022-06-23 Thread Dave Hansen
... adding kexec folks On 6/14/22 05:02, Kirill A. Shutemov wrote: > On kexec, the target kernel has to know what memory has been accepted. > Information in EFI map is out of date and cannot be used. > > boot_params.unaccepted_memory can be used to pass the bitmap between two > kernels on kexec,

Re: [PATCH v4] kexec-tools: mips: Pass initrd parameter via cmdline

2022-06-23 Thread Simon Horman
On Fri, Jun 10, 2022 at 04:53:52PM +0800, Hui Li wrote: > Under loongson platform, use command: > kexec -l vmlinux... --append="root=UUID=28e1..." --initrd=... > kexec -e > quick restart failed like this: > > > [3.420791] VFS

Re: [PATCH 5/5] arm64: kdump: Don't defer the reservation of crash high memory

2022-06-23 Thread Catalin Marinas
On Wed, Jun 22, 2022 at 04:35:16PM +0800, Baoquan He wrote: > On 06/21/22 at 07:04pm, Catalin Marinas wrote: > > The problem with splitting is that you can end up with two entries in > > the TLB for the same VA->PA mapping (e.g. one for a 4KB page and another > > for a 2MB block). In the lucky case

Re: [PATCH v2] panic, kexec: Make __crash_kexec() NMI safe

2022-06-23 Thread Sebastian Andrzej Siewior
On 2022-06-23 12:39:57 [+0100], Valentin Schneider wrote: > > RT-wise it would be needed for each release. > > So git tells me the Fixes: commit dates from v4.2; from [1] and [2] I get > that both current longterm stable and stable-rt trees go as far back as > v4.9, so I'm guessing if that gets pi

Re: [PATCH v2] panic, kexec: Make __crash_kexec() NMI safe

2022-06-23 Thread Valentin Schneider
On 23/06/22 11:31, Sebastian Andrzej Siewior wrote: > On 2022-06-20 12:15:20 [+0100], Valentin Schneider wrote: >> Attempting to get a crash dump out of a debug PREEMPT_RT kernel via an NMI >> panic() doesn't work. The cause of that lies in the PREEMPT_RT definition >> of mutex_trylock(): >> > … >

Re: [PATCH 5/5] arm64: kdump: Don't defer the reservation of crash high memory

2022-06-23 Thread Catalin Marinas
On Wed, Jun 22, 2022 at 08:03:21PM +0800, Kefeng Wang wrote: > On 2022/6/22 2:04, Catalin Marinas wrote: > > On Tue, Jun 21, 2022 at 02:24:01PM +0800, Kefeng Wang wrote: > > > On 2022/6/21 13:33, Baoquan He wrote: > > > > On 06/13/22 at 04:09pm, Zhen Lei wrote: > > > > > If the crashkernel has both

Re: [PATCH v2] panic, kexec: Make __crash_kexec() NMI safe

2022-06-23 Thread Sebastian Andrzej Siewior
On 2022-06-20 12:15:20 [+0100], Valentin Schneider wrote: > Attempting to get a crash dump out of a debug PREEMPT_RT kernel via an NMI > panic() doesn't work. The cause of that lies in the PREEMPT_RT definition > of mutex_trylock(): > … > Fixes: 6ce47fd961fa ("rtmutex: Warn if trylock is called f