[PATCH-RESEND] arm64/kexec: Fix missing extra range for crashkres_low.

2022-08-29 Thread Yun Levi
Like crashk_res, Calling crash_exclude_mem_range function with crashk_low_res area would need extra crash_mem range too. Add one extra crash_mem range when crashk_low_res is used. Signed-off-by: Levi Yun --- arch/arm64/kernel/machine_kexec_file.c | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [PATCH 1/3] LoongArch: Add kexec support

2022-08-29 Thread Jinyang He
On 08/30/2022 11:42 AM, Huacai Chen wrote: On Tue, Aug 30, 2022 at 11:26 AM Youling Tang wrote: Hi, Jinyang On 08/30/2022 09:53 AM, Jinyang He wrote: Hi, Youling, On 08/29/2022 12:37 PM, Youling Tang wrote: Add three new files, kexec.h, machine_kexec.c and relocate_kernel.S to the

Re: [PATCH 1/3] LoongArch: Add kexec support

2022-08-29 Thread Huacai Chen
On Tue, Aug 30, 2022 at 11:26 AM Youling Tang wrote: > > Hi, Jinyang > > On 08/30/2022 09:53 AM, Jinyang He wrote: > > Hi, Youling, > > > > > > On 08/29/2022 12:37 PM, Youling Tang wrote: > >> Add three new files, kexec.h, machine_kexec.c and relocate_kernel.S to > >> the > >> LoongArch

Re: [PATCH 1/3] LoongArch: Add kexec support

2022-08-29 Thread Youling Tang
Hi, Jinyang On 08/30/2022 09:53 AM, Jinyang He wrote: Hi, Youling, On 08/29/2022 12:37 PM, Youling Tang wrote: Add three new files, kexec.h, machine_kexec.c and relocate_kernel.S to the LoongArch architecture that add support for the kexec re-boot mechanis (CONFIG_KEXEC) on LoongArch

Re: [PATCH 0/5] arm64/mm: remap crash kernel with base pages even if rodata_full disabled

2022-08-29 Thread Baoquan He
On 08/29/22 at 05:31pm, Mike Rapoport wrote: > On Sun, Aug 28, 2022 at 04:37:29PM +0800, Baoquan He wrote: > > On 08/25/22 at 10:48am, Mike Rapoport wrote: > > .. > > > > > There were several rounds of discussion how to remap with base pages > > > > > only > > > > > the crash kernel area,

Re: [PATCH 1/3] LoongArch: Add kexec support

2022-08-29 Thread Jinyang He
Hi, Youling, On 08/29/2022 12:37 PM, Youling Tang wrote: Add three new files, kexec.h, machine_kexec.c and relocate_kernel.S to the LoongArch architecture that add support for the kexec re-boot mechanis (CONFIG_KEXEC) on LoongArch platforms. Supports loading vmlinux (vmlinux.elf) in ELF

Re: [PATCH RFC 1/2] coding-style.rst: document BUG() and WARN() rules ("do not crash the kernel")

2022-08-29 Thread Linus Torvalds
On Sun, Aug 28, 2022 at 9:49 PM John Hubbard wrote: > > ...here. I count ~1000 calls to panic() in today's kernel, to a > function in kernel/panic.c that shows no hint of being removed, nor > even deprecated. Heh. I guess we never finished the panic() removal. It's been decades, I suspect we

Re: [PATCH 0/5] arm64/mm: remap crash kernel with base pages even if rodata_full disabled

2022-08-29 Thread Mike Rapoport
On Sun, Aug 28, 2022 at 04:37:29PM +0800, Baoquan He wrote: > On 08/25/22 at 10:48am, Mike Rapoport wrote: > .. > > > > There were several rounds of discussion how to remap with base pages > > > > only > > > > the crash kernel area, the latest one here: > > > > > > > >

Re: [PATCH RFC 1/2] coding-style.rst: document BUG() and WARN() rules ("do not crash the kernel")

2022-08-29 Thread Jani Nikula
On Sun, 28 Aug 2022, Linus Torvalds wrote: > So WARN_ON_ONCE() is the thing to aim for. BUG_ON() is the thing for > "oops, I really don't know what to do, and I physically *cannot* > continue" (and that is *not* "I'm too lazy to do error handling"). Any insight for the tradeoff between

Re: [PATCH RFC 1/2] coding-style.rst: document BUG() and WARN() rules ("do not crash the kernel")

2022-08-29 Thread David Hildenbrand
On 29.08.22 05:07, Linus Torvalds wrote: > On Sun, Aug 28, 2022 at 6:56 PM Dave Young wrote: >> >>> John mentioned PANIC_ON(). >> >> I would vote for PANIC_ON(), it sounds like a good idea, because >> BUG_ON() is not obvious and, PANIC_ON() can alert the code author that >> this will cause a