On 08/30/2022 11:25 AM, Youling Tang wrote:
Hi, Jinyang
On 08/30/2022 09:53 AM, Jinyang He wrote:
Hi, Youling,
On 08/29/2022 12:37 PM, Youling Tang wrote:
Add three new files, kexec.h, machine_kexec.c and relocate_kernel.S to
the
LoongArch architecture that add support for the kexec
On 08/26/22 at 01:37pm, Eric DeVolder wrote:
> CPU and memory change notifications are received in order to
> regenerate the elfcorehdr.
>
> To support cpu hotplug, a callback is registered to capture the
> CPUHP_AP_ONLINE_DYN online and offline events via
> cpuhp_setup_state_nocalls().
>
> To
On 08/26/22 at 01:36pm, Eric DeVolder wrote:
> At the outcome of this patch set, the crash_prepare_elf64_headers()
> is utilized on both the kexec_file_load and kexec_load paths. As
> such, need to move this function out of kexec_file.c and into a
> common location crash_core.c.
>
> No
Like crashk_res, Calling crash_exclude_mem_range function with
crashk_low_res area would need extra crash_mem range too.
Add one more extra cmem slot in case of crashk_low_res is used.
Signed-off-by: Levi Yun
Fixes: 944a45abfabc ("arm64: kdump: Reimplement crashkernel=X")
Cc:
> No, I don't think the Fixes commit is right. It should fix the commit
> where crashkernel,low is introduced. Before that, no issue caused.
> So the tags should be:
>
> Fixes: 944a45abfabc ("arm64: kdump: Reimplement crashkernel=X")
> Cc: sta...@vger.kernel.org
Thanks! I'will resend the patch
On 08/31/22 at 09:38am, Yun Levi wrote:
> > Reviewed-by: Catalin Marinas
> >
> > Does this need a Fixes tag and cc stable?
> >
> > --
> > Catalin
>
> IMHO, it seems good to add two tags like:
>Fixes: 3751e728cef29 ("arm64: kexec_file: add crash dump support")
>Cc: sta...@vger.kernel.org
> Reviewed-by: Catalin Marinas
>
> Does this need a Fixes tag and cc stable?
>
> --
> Catalin
IMHO, it seems good to add two tags like:
Fixes: 3751e728cef29 ("arm64: kexec_file: add crash dump support")
Cc: sta...@vger.kernel.org
BTW, To add above two tags, should I resend the patch again
On Tue, Aug 30, 2022 at 06:28:39PM +0900, Levi Yun wrote:
> Like crashk_res, Calling crash_exclude_mem_range function with
> crashk_low_res area would need extra crash_mem range too.
>
> Add one more extra cmem range slot in case of crashk_low_res is used.
>
> Signed-off-by: Levi Yun
On 08/30/22 at 06:28pm, Levi Yun wrote:
> Like crashk_res, Calling crash_exclude_mem_range function with
> crashk_low_res area would need extra crash_mem range too.
>
> Add one more extra cmem range slot in case of crashk_low_res is used.
~~^ should be
Like crashk_res, Calling crash_exclude_mem_range function with
crashk_low_res area would need extra crash_mem range too.
Add one more extra cmem range slot in case of crashk_low_res is used.
Signed-off-by: Levi Yun
---
arch/arm64/kernel/machine_kexec_file.c | 2 +-
1 file changed, 1
> Right, excluding crashkernel region may cause memory region splitting,
> so we need extra slot for that.
>
> Meanwhile, can you fix above code comment mess? Otherwise, this looks
> good to me.
Thanks! I'll remove the comment.
> Or we can add extra 2 slots like we do in x86, it just add another
On 08/30/22 at 01:28pm, Yun Levi wrote:
> Like crashk_res, Calling crash_exclude_mem_range function with
> crashk_low_res area would need extra crash_mem range too.
> Add one extra crash_mem range when crashk_low_res is used.
>
> Signed-off-by: Levi Yun
> ---
>
12 matches
Mail list logo
