Re: [PATCH v7 06/13] x86: Add early SHA support for Secure Launch early measurements

2023-11-11 Thread James Bottomley
On Sat, 2023-11-11 at 18:19 +, Andrew Cooper wrote: > On 11/11/2023 5:44 pm, Eric Biggers wrote: > > On Fri, Nov 10, 2023 at 05:27:44PM -0500, Ross Philipson wrote: > > >  arch/x86/boot/compressed/early_sha1.c   | 12 > > >  lib/crypto/sha1.c   | 81 > > > +++

Re: [PATCH v7 06/13] x86: Add early SHA support for Secure Launch early measurements

2023-11-11 Thread Andrew Cooper
On 11/11/2023 5:44 pm, Eric Biggers wrote: > On Fri, Nov 10, 2023 at 05:27:44PM -0500, Ross Philipson wrote: >> arch/x86/boot/compressed/early_sha1.c | 12 >> lib/crypto/sha1.c | 81 + > It's surprising to still see this new use of SHA-1 after so

Re: [PATCH v7 06/13] x86: Add early SHA support for Secure Launch early measurements

2023-11-11 Thread Eric Biggers
On Fri, Nov 10, 2023 at 05:27:44PM -0500, Ross Philipson wrote: > arch/x86/boot/compressed/early_sha1.c | 12 > lib/crypto/sha1.c | 81 + It's surprising to still see this new use of SHA-1 after so many people objected to it in the v6 patchset.

Re: [PATCH v7 09/13] x86: Secure Launch SMP bringup support

2023-11-11 Thread kernel test robot
. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Ross-Philipson/x86-boot-Place-kernel_info-at-a-fixed-offset/2023-063453 base: tip/x86/