Re: [PATCH] makedumpfile add dmesg PRINTK_CALLER id support

2023-12-20 Thread 萩尾 一仁
On 2023/12/14 17:02, HAGIO KAZUHITO(萩尾 一仁) wrote: > On 2023/12/13 19:13, Edward Chron wrote: >> Submission to Project: makedumpfile >> Component: dmesg >> Files: printk.c makedumpfile.c makedumpfile.h >> Code level patch applied against: 1.7.4++ - latest code pulled from >>

Re: [PATCH v14 3/6] crash: add a new kexec flag for FDT update

2023-12-20 Thread Sourabh Jain
Hello Baoquan, While replying to this email earlier, I mistakenly pressed "Reply to List" instead of "Reply to All." Consequently, my response was sent only to powerpc mailing list. On 17/12/23 06:29, Baoquan He wrote: On 12/17/23 at 12:27am, Sourabh Jain wrote: On 16/12/23 15:11, Baoquan

[PATCH] kexec_core: fix the assignment to kimage->control_page

2023-12-20 Thread Yuntao Wang
image->control_page represents the starting address for allocating the next control page, while hole_end represents the address of the last valid byte of the currently allocated control page. Therefore, after successfully allocating a control page, image->control_page should be updated to

Re: [PATCH] crash_core: export vmemmap when CONFIG_SPARSEMEM_VMEMMAP is enabled

2023-12-20 Thread Baoquan He
On 11/27/23 at 10:07am, Huang Shijie wrote: > In memory_model.h, if CONFIG_SPARSEMEM_VMEMMAP is configed, > kernel will use vmemmap to do the __pfn_to_page/page_to_pfn, > and kernel will not use the "classic sparse" to do the > __pfn_to_page/page_to_pfn. > > So export the vmemmap when

Re: [PATCH] crash_core: export vmemmap when CONFIG_SPARSEMEM_VMEMMAP is enabled

2023-12-20 Thread Shijie Huang
Hi Baoquan, 在 2023/11/28 15:34, Baoquan He 写道: On 11/28/23 at 11:31am, Shijie Huang wrote: 在 2023/11/28 11:25, Baoquan He 写道: On 11/27/23 at 11:18am, Shijie Huang wrote: 在 2023/11/27 10:51, Baoquan He 写道: Hi, On 11/27/23 at 10:07am, Huang Shijie wrote: In memory_model.h, if

Re: [PATCH v4 5/7] kexec_file, ricv: print out debugging message if required

2023-12-20 Thread Baoquan He
On 12/20/23 at 07:46am, Andrew Morton wrote: > On Wed, 20 Dec 2023 12:22:29 +0800 Baoquan He wrote: > > > Could you help fix the typo in subject? > > > > [PATCH v4 5/7] kexec_file, ricv: print out debugging message if required > >~~~ s/ricv/riscv/ > > I made that

Re: [RFC V2] IMA Log Snapshotting Design Proposal

2023-12-20 Thread Ken Goldman
I'm still struggling with the "new root of trust" concept. Something - a user space agent, a third party, etc. - has to retain the entire log from event 0, because a new verifier needs all measurements. Therefore, the snapshot aggregate seems redundant. It has to be verified to match the

Re: [PATCH v3 5/7] ima: suspend measurements during buffer copy at kexec execute

2023-12-20 Thread Mimi Zohar
On Fri, 2023-12-15 at 17:07 -0800, Tushar Sugandhi wrote: > If the new measurements are added to the IMA log while it is being > being copied to the kexec buffer during kexec 'execute', it can miss > copying those new measurements to the kexec buffer, and the buffer can go > out of sync with TPM

Re: [PATCH v3 7/7] ima: measure kexec load and exec events as critical data

2023-12-20 Thread Mimi Zohar
On Fri, 2023-12-15 at 17:07 -0800, Tushar Sugandhi wrote: > There could be a potential mismatch between IMA measurements and TPM PCR > quotes caused by the indeterminate interval between kexec 'load' and > 'execute'. Memory allocated at kexec 'load' for IMA log buffer may run > out. It can lead

Re: [PATCH v3 6/7] ima: configure memory to log events between kexec load and execute

2023-12-20 Thread Mimi Zohar
Hi Tushar, The Subject line should include the word "extra". The use of the extra memory isn't limited to the measurements between the kexec load and exec. Additional records could be added as a result of the kexec load itself. Let's simplify the title to "ima: make the kexec extra memory

Re: [PATCH v3 2/7] ima: kexec: move ima log copy from kexec load to execute

2023-12-20 Thread Mimi Zohar
Hi Tushar, On Fri, 2023-12-15 at 17:07 -0800, Tushar Sugandhi wrote: > ima_dump_measurement_list() is called from ima_add_kexec_buffer() during > kexec 'load', which may result in loss of IMA measurements between kexec > 'load' and 'execute'. It needs to be called during kexec 'execute'. > >

Re: [PATCH v3 1/7] ima: define and call ima_alloc_kexec_file_buf

2023-12-20 Thread Mimi Zohar
On Fri, 2023-12-15 at 17:07 -0800, Tushar Sugandhi wrote: > Refactor ima_dump_measurement_list() to move the memory allocation part > to a separate function ima_alloc_kexec_file_buf() to allocate buffer of > size 'kexec_segment_size' at kexec 'load'. Make the local variables in > function

Re: [PATCH v4 5/7] kexec_file, ricv: print out debugging message if required

2023-12-20 Thread Andrew Morton
On Wed, 20 Dec 2023 12:22:29 +0800 Baoquan He wrote: > Could you help fix the typo in subject? > > [PATCH v4 5/7] kexec_file, ricv: print out debugging message if required >~~~ s/ricv/riscv/ I made that change. ___ kexec

[PATCH] x86/kexec: fix incorrect argument passed to kexec_dprintk()

2023-12-20 Thread Yuntao Wang
kexec_dprintk() expects the last argument to be kbuf.memsz, but the actual argument being passed is kbuf.bufsz. Although these two values are currently equal, it is better to pass the correct one, in case these two values become different in the future. Signed-off-by: Yuntao Wang ---