Re: [PATCH linux-next v3 01/14] kexec: split crashkernel reservation code out from crash_core.c

2024-01-27 Thread Klara Modin
Hi, On 2024-01-24 06:12, Baoquan He wrote: And also add config item CRASH_RESERVE to control its enabling of the codes. And update config items which has relationship with crashkernel reservation. And also change ifdeffery from CONFIG_CRASH_CORE to CONFIG_CRASH_RESERVE when those scopes are onl

Re: [PATCHv6 16/16] x86/acpi: Add support for CPU offlining for ACPI MADT wakeup method

2024-01-27 Thread Kirill A. Shutemov
On Fri, Jan 26, 2024 at 12:03:14PM -0800, Kuppuswamy Sathyanarayanan wrote: > > + /* Don't wait longer than a second. */ > > + timeout = USEC_PER_SEC; > > + while (READ_ONCE(acpi_mp_wake_mailbox->command) && --timeout) > > + udelay(1); > > + > > + if (!timeout) > Nit: IMO, since y

Re: [PATCHv6 16/16] x86/acpi: Add support for CPU offlining for ACPI MADT wakeup method

2024-01-27 Thread kirill.shute...@linux.intel.com
On Fri, Jan 26, 2024 at 02:21:30PM +, Huang, Kai wrote: > > +static int __init acpi_mp_setup_reset(u64 reset_vector) > > +{ > > + pgd_t *pgd; > > + struct x86_mapping_info info = { > > + .alloc_pgt_page = alloc_pgt_page, > > + .free_pgt_page = free_pgt_page, > > +