Re: [PATCH 1/1] kexec_file: fix elfcorehdr digest exclusion when CONFIG_CRASH_HOTPLUG=y

2024-08-15 Thread Petr Tesarik
On Tue, 6 Aug 2024 06:59:35 +0800 Baoquan He wrote: > On 08/05/24 at 05:07pm, Petr Tesarik wrote: > > From: Petr Tesarik > > > > Fix the condition to exclude the elfcorehdr segment from the SHA digest > > calculation. > > > > The j iterator is an index into the output sha_regions[] array, not

Re: [PATCH 1/2] makedumpfile: Add ftruncate error handling

2024-08-15 Thread 萩尾 一仁
On 2024/08/15 23:17, Stefan Wiehler wrote: > Found via -Werror: > >makedumpfile.c: In function ‘dump_dmesg’: >makedumpfile.c:5884:33: error: ignoring return value of ‘ftruncate’ > declared with attribute ‘warn_unused_result’ [-Werror=unused-result] > 5884 |

Re: [PATCH v9 14/19] tpm: Ensure tpm is in known state at startup

2024-08-15 Thread Daniel P. Smith
On 6/4/24 16:14, Jarkko Sakkinen wrote: On Fri May 31, 2024 at 4:03 AM EEST, Ross Philipson wrote: From: "Daniel P. Smith" When tis core initializes, it assumes all localities are closed. There s/tis_core/tpm_tis_core/ Ack. are cases when this may not be the case. This commit addresses t

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-08-15 Thread Thomas Gleixner
On Thu, Aug 15 2024 at 13:38, Daniel P. Smith wrote: > On 5/31/24 09:54, Eric W. Biederman wrote: >> Eric Biggers writes: >>> That paragraph is also phrased as a hypothetical, "Even if we'd prefer to >>> use >>> SHA-256-only". That implies that you do not, in fact, prefer SHA-256 only. >>> Is

Re: [PATCH v9 13/19] tpm: Protect against locality counter underflow

2024-08-15 Thread Daniel P. Smith
On 6/4/24 16:12, Jarkko Sakkinen wrote: On Fri May 31, 2024 at 4:03 AM EEST, Ross Philipson wrote: From: "Daniel P. Smith" Commit 933bfc5ad213 introduced the use of a locality counter to control when a locality request is allowed to be sent to the TPM. In the commit, the counter is indiscrimin

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-08-15 Thread Daniel P. Smith
On 5/31/24 09:54, Eric W. Biederman wrote: Eric Biggers writes: On Thu, May 30, 2024 at 06:03:18PM -0700, Ross Philipson wrote: From: "Daniel P. Smith" For better or worse, Secure Launch needs SHA-1 and SHA-256. The choice of hashes used lie with the platform firmware, not with software, an

Re: [PATCH v9 09/19] x86: Secure Launch kernel late boot stub

2024-08-15 Thread Jarkko Sakkinen
On Mon Aug 12, 2024 at 10:02 PM EEST, wrote: > On 6/4/24 3:59 PM, Jarkko Sakkinen wrote: > > On Fri May 31, 2024 at 4:03 AM EEST, Ross Philipson wrote: > >> The routine slaunch_setup is called out of the x86 specific setup_arch() > >> routine during early kernel boot. After determining what platfo

[PATCH 1/2] makedumpfile: Add ftruncate error handling

2024-08-15 Thread Stefan Wiehler
Found via -Werror: makedumpfile.c: In function ‘dump_dmesg’: makedumpfile.c:5884:33: error: ignoring return value of ‘ftruncate’ declared with attribute ‘warn_unused_result’ [-Werror=unused-result] 5884 | ftruncate(info->fd_dumpfile, 0); |

[PATCH 2/2] sadump_info: Return empty string instead of NULL

2024-08-15 Thread Stefan Wiehler
Found via -Werror: In file included from makedumpfile.h:47, from makedumpfile.c:16: makedumpfile.c: In function ‘initial’: makedumpfile.c:4546:29: error: ‘%s’ directive argument is null [-Werror=format-overflow=] 4546 | MSG("because %s is sadump

Re: [PATCHv2 3/4] x86/64/kexec: Map original relocate_kernel() in init_transition_pgtable()

2024-08-15 Thread Kirill A. Shutemov
On Thu, Aug 15, 2024 at 02:15:40PM +0800, Baoquan He wrote: > Cc Eric and kexec mailing list. > > On 08/14/24 at 03:46pm, Kirill A. Shutemov wrote: > > The init_transition_pgtable() function sets up transitional page tables. > > It ensures that the relocate_kernel() function is present in the > >