Re: [PATCH] arm64/vmcore: Add pgtable_l5_enabled information in vmcoreinfo

2024-08-27 Thread Baoquan He
On 08/27/24 at 01:24pm, Will Deacon wrote: > On Mon, Aug 26, 2024 at 02:52:02PM +0800, Kuan-Ying Lee wrote: > > Since arm64 supports 5-level page tables, we need to add this > > information to vmcoreinfo to make debug tools know if 5-level > > page table is enabled or not. > > > > Missing this inf

Re: [PATCH] x86/mm/sme: fix the kdump kernel breakage on SME system when CONFIG_IMA_KEXEC=y

2024-08-27 Thread Baoquan He
On 08/27/24 at 09:00am, Tom Lendacky wrote: > On 8/27/24 08:52, Tom Lendacky wrote: > > On 8/26/24 22:19, Baoquan He wrote: > >> On 08/26/24 at 09:24am, Tom Lendacky wrote: > >>> On 8/25/24 21:44, Baoquan He wrote: > Recently, it's reported that kdump kernel is broken during bootup on > S

[PATCH] x86/sev: Fix host kdump support for SNP

2024-08-27 Thread Ashish Kalra
From: Ashish Kalra With active SNP VMs, SNP_SHUTDOWN_EX invoked during panic notifiers causes crashkernel boot failure with the following signature: [ 563.497112] sysrq: Trigger a crash [ 563.508415] Kernel panic - not syncing: sysrq triggered crash [ 563.522002] CPU: 10 UID: 0 PID: 4661 Comm

Re: [PATCH v10 20/20] x86/efi: EFI stub DRTM launch support for Secure Launch

2024-08-27 Thread kernel test robot
herbert-crypto-2.6/master next-20240827] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-08-27 Thread Eric Biggers
On Thu, May 30, 2024 at 07:16:56PM -0700, Eric Biggers wrote: > On Thu, May 30, 2024 at 06:03:18PM -0700, Ross Philipson wrote: > > From: "Daniel P. Smith" > > > > For better or worse, Secure Launch needs SHA-1 and SHA-256. The > > choice of hashes used lie with the platform firmware, not with >

Re: [PATCH v10 20/20] x86/efi: EFI stub DRTM launch support for Secure Launch

2024-08-27 Thread ross . philipson
On 8/27/24 3:28 AM, Ard Biesheuvel wrote: On Tue, 27 Aug 2024 at 00:44, Ross Philipson wrote: This support allows the DRTM launch to be initiated after an EFI stub launch of the Linux kernel is done. This is accomplished by providing a handler to jump to when a Secure Launch is in progress. Th

Re: [PATCH] x86/mm/sme: fix the kdump kernel breakage on SME system when CONFIG_IMA_KEXEC=y

2024-08-27 Thread Tom Lendacky
On 8/27/24 08:52, Tom Lendacky wrote: > On 8/26/24 22:19, Baoquan He wrote: >> On 08/26/24 at 09:24am, Tom Lendacky wrote: >>> On 8/25/24 21:44, Baoquan He wrote: Recently, it's reported that kdump kernel is broken during bootup on SME system when CONFIG_IMA_KEXEC=y. When debugging, I not

Re: [PATCH] x86/mm/sme: fix the kdump kernel breakage on SME system when CONFIG_IMA_KEXEC=y

2024-08-27 Thread Tom Lendacky
On 8/27/24 00:41, Dave Young wrote: > On Tue, 27 Aug 2024 at 13:28, Baoquan He wrote: >> >> On 08/26/24 at 09:24am, Tom Lendacky wrote: >>> On 8/25/24 21:44, Baoquan He wrote: Recently, it's reported that kdump kernel is broken during bootup on SME system when CONFIG_IMA_KEXEC=y. When de

Re: [PATCH] x86/mm/sme: fix the kdump kernel breakage on SME system when CONFIG_IMA_KEXEC=y

2024-08-27 Thread Tom Lendacky
On 8/26/24 22:19, Baoquan He wrote: > On 08/26/24 at 09:24am, Tom Lendacky wrote: >> On 8/25/24 21:44, Baoquan He wrote: >>> Recently, it's reported that kdump kernel is broken during bootup on >>> SME system when CONFIG_IMA_KEXEC=y. When debugging, I noticed this >>> can be traced back to commit (

Re: [PATCH] arm64/vmcore: Add pgtable_l5_enabled information in vmcoreinfo

2024-08-27 Thread Will Deacon
On Mon, Aug 26, 2024 at 02:52:02PM +0800, Kuan-Ying Lee wrote: > Since arm64 supports 5-level page tables, we need to add this > information to vmcoreinfo to make debug tools know if 5-level > page table is enabled or not. > > Missing this information will break the debug tool like crash [1]. > >

Re: [PATCH v10 08/20] x86/boot: Place TXT MLE header in the kernel_info section

2024-08-27 Thread Ard Biesheuvel
On Tue, 27 Aug 2024 at 00:42, Ross Philipson wrote: > > The MLE (measured launch environment) header must be locatable by the > boot loader and TXT must be setup to do a launch with this header's > location. While the offset to the kernel_info structure does not need > to be at a fixed offset, the

Re: [PATCH v10 20/20] x86/efi: EFI stub DRTM launch support for Secure Launch

2024-08-27 Thread Ard Biesheuvel
On Tue, 27 Aug 2024 at 00:44, Ross Philipson wrote: > > This support allows the DRTM launch to be initiated after an EFI stub > launch of the Linux kernel is done. This is accomplished by providing > a handler to jump to when a Secure Launch is in progress. This has to be > called after the EFI st

Re: [PATCH] x86/mm/sme: fix the kdump kernel breakage on SME system when CONFIG_IMA_KEXEC=y

2024-08-27 Thread Baoquan He
On 08/27/24 at 01:41pm, Dave Young wrote: > On Tue, 27 Aug 2024 at 13:28, Baoquan He wrote: > > > > On 08/26/24 at 09:24am, Tom Lendacky wrote: > > > On 8/25/24 21:44, Baoquan He wrote: .. > > > > --- > > > > arch/x86/mm/ioremap.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] crash: Default to CRASH_DUMP=n when support for it is unlikely

2024-08-27 Thread Baoquan He
On 08/27/24 at 08:37am, John Paul Adrian Glaubitz wrote: > On Tue, 2024-08-27 at 14:22 +0800, Baoquan He wrote: > > About why it's enabled by default, as Michael has explained in another > > thread, distros usualy needs to enable it by default because vmcore > > dumping is a very important feature