Re: [PATCH 0/2] arm64: kexec_file_load vs memory reservations

2021-05-18 Thread Bhupesh Sharma
Hi Will, On Tue, 18 May 2021 at 17:19, Will Deacon wrote: > > [Fixing Bhupesh's email address] > > On Thu, Apr 29, 2021 at 02:35:31PM +0100, Marc Zyngier wrote: > > It recently became apparent that using kexec with kexec_file_load() on > > arm64 is pretty similar to playing Russian roulette. > >

Re: [RFC PATCH 4/4] i40e: don't open i40iw client for kdump

2021-02-25 Thread Bhupesh SHARMA
Hello Coiby, On Mon, Feb 22, 2021 at 12:40 PM Coiby Xu wrote: > > i40iw consumes huge amounts of memory. For example, on a x86_64 machine, > i40iw consumed 1.5GB for Intel Corporation Ethernet Connection X722 for > for 1GbE while "craskernel=auto" only reserved 160M. With the module > parameter

Re: [PATCH 3/3] arm64: support flipped VA and 52-bit kernel VA

2021-02-04 Thread Bhupesh SHARMA
Hi Kazu, On Thu, Feb 4, 2021 at 11:26 AM HAGIO KAZUHITO(萩尾 一仁) wrote: > > Hi Pingfan, Bhupesh, > > -Original Message- > > Except an correction in notes, the rest looks good to me. > > > > Reviewed-by: Pingfan Liu > > Thank you for reviewing and testing this, applied the patch set. >

Re: [RFC PATCH 4/4] arm64: support flipped VA and 52-bit kernel VA

2021-01-14 Thread Bhupesh SHARMA
Hi Kazu, On Thu, Jan 14, 2021 at 3:33 PM piliu wrote: > > > > On 1/14/21 4:25 PM, kazuhito.ha...@gmail.com wrote: > > From: Kazuhito Hagio > > > > Based on Bhupesh's patch and contains Pingfan's idea. > > > > Signed-off-by: Bhupesh Sharma > > S

Re: [RFC PATCH 0/3] makedumpfile: about failing on arm64 with kernel > 5.4

2020-11-22 Thread Bhupesh SHARMA
September/021488.html > > Alexander Kamensky (2): > added way to determine kernel version that vmcore is from > arm64: use kernel version from OSRELEASE to determine linear mapping > position > > Bhupesh Sharma (1): > makedumpfile/arm64: Add support for ARMv8.2-L

Re: Facing issue with va to pa conversion in arm64/makedumpfile

2020-11-20 Thread Bhupesh Sharma
Hello Akshay, As Kazu mentioned please try the patch : http://lists.infradead.org/pipermail/kexec/2020-September/021336.html and let me know your observations. I am still on my holidays but will try to check my emails from today, so will help you with any further issues. Thanks, Bhupesh On

Re: [PATCH v5 0/3] makedumpfile/arm64: Add support for ARMv8.2 extensions

2020-11-11 Thread Bhupesh Sharma
ampere-osprey. > > > 2. Prototype models which support ARMv8.2 extensions (e.g. ARMv8 FVP > > >simulation model). > > > > > > Also a preparation patch has been added in this patchset which adds a > > > common feature for archs (except arm64, for which

Re: [PATCH v13 0/8] support reserving crashkernel above 4G on arm64 kdump

2020-11-11 Thread Bhupesh SHARMA
Hi Chen, On Wed, Nov 11, 2020 at 7:05 PM chenzhou wrote: > > Hi Baoquan, Bhupesh, > > > On 2020/11/11 11:01, Baoquan He wrote: > > Hi Zhou, Bhupesh > > > > On 10/31/20 at 03:44pm, Chen Zhou wrote: > >> There are following issues in arm64 kdump: > >> 1. We use crashkernel=X to reserve crashkernel

Re: [MAKDUMPFILE PATCH] Add option to estimate the size of vmcore dump files

2020-10-13 Thread Bhupesh Sharma
Hello Julien, On Tue, Oct 13, 2020 at 3:23 PM Julien Thierry wrote: > > Hi Bhupesh, > > On 10/13/20 10:27 AM, Bhupesh Sharma wrote: > > Hello Julien, > > > > Thanks for the patch. Some nitpicks inline: > > > > On Mon, Oct 12, 2020 at 12:39 PM Julien T

Re: [MAKDUMPFILE PATCH] Add option to estimate the size of vmcore dump files

2020-10-13 Thread Bhupesh Sharma
Hello Julien, Thanks for the patch. Some nitpicks inline: On Mon, Oct 12, 2020 at 12:39 PM Julien Thierry wrote: > > A user might want to know how much space a vmcore file will take on > the system and how much space on their disk should be available to > save it during a crash. > > The option

Re: [PATCH v12 0/9] support reserving crashkernel above 4G on arm64 kdump

2020-10-07 Thread Bhupesh Sharma
Hi Catalin, On Tue, Oct 6, 2020 at 11:30 PM Catalin Marinas wrote: > > On Mon, Oct 05, 2020 at 11:12:10PM +0530, Bhupesh Sharma wrote: > > I think my earlier email with the test results on this series bounced > > off the mailing list server (for some weird reason), but I sti

Re: [PATCH v12 0/9] support reserving crashkernel above 4G on arm64 kdump

2020-10-05 Thread Bhupesh Sharma
Hi Catalin, Chen, On Mon, Oct 5, 2020 at 10:39 PM Catalin Marinas wrote: > > On Sat, Sep 12, 2020 at 06:44:29AM -0500, John Donnelly wrote: > > On 9/7/20 8:47 AM, Chen Zhou wrote: > > > Chen Zhou (9): > > >x86: kdump: move CRASH_ALIGN to 2M > > >x86: kdump: make the lower bound of crash

Re: [PATCH v4] arm64: Add purgatory printing

2020-10-02 Thread Bhupesh Sharma
ot;, _sink, > + sizeof(purgatory_sink)); > + > elf_rel_set_symbol(>rhdr, "arm64_kernel_entry", _base, > sizeof(image_base)); > > diff --git a/purgatory/arch/arm64/purgatory-arm64.c > b/purgatory/arch/arm64/purgatory-arm64.c >

Re: [PATCH] kexec/arm64: Add support for ARMv8.2 (large space addressing) 52-bit VA extensions

2020-09-28 Thread Bhupesh Sharma
Hello Simon, Thanks for your review. Please see my comments in-line: On Fri, Sep 25, 2020 at 11:37 AM Simon Horman wrote: > > Hi Bhupesh, > > thanks for your patch. > > ... > > > +static int get_vabits_actual_from_id_aa64mmfr2_el1(void) > > +{ > > + int l_vabits_actual; > > + unsigned

Re: [PATCH v2 1/1] kdump: append uts_namespace.name offset to VMCOREINFO

2020-09-24 Thread Bhupesh Sharma
> + VMCOREINFO_OFFSET(uts_namespace, name); > VMCOREINFO_SYMBOL(node_online_map); > #ifdef CONFIG_MMU > VMCOREINFO_SYMBOL_ARRAY(swapper_pg_dir); > -- > 2.26.2 Thanks for making the changes we discussed in the v1 review. Otherwise the patch looks fine to me, so: Reviewed-by: Bh

[PATCH] kexec: Fix snprintf related compilation warnings

2020-09-23 Thread Bhupesh Sharma
the gcc warnings and possible truncation would be to check the return value provided from snprintf (well there are other methods like using 'asnprintf' or using 'open_memstream' function to create the FILE object, but these are more intrusive), so this patch does the same. Cc: Simon Horman Cc: Eri

[PATCH] vmcore-dmesg/man page: Update the vmcore-dmesg man page

2020-09-22 Thread Bhupesh Sharma
The vmcore-dmesg utility has been in usage for several years, and is pretty stable now. So its useful now to modify its man page to indicate the same. Also fix some minor formatting issues. Cc: Simon Horman Cc: Eric Biederman Cc: kexec@lists.infradead.org Signed-off-by: Bhupesh Sharma

Re: [PATCH] arm64: Add purgatory printing

2020-09-18 Thread Bhupesh SHARMA
Hi Matthias, On Fri, Sep 18, 2020 at 2:01 PM Matthias Brugger wrote: > > > > On 18/09/2020 07:16, Bhupesh SHARMA wrote: > > Hi Matthias, > > > > Thanks for the patch. Some nitpicks inline: > > > > On Fri, Sep 18, 2020 at 1:09 AM wrote: > >>

Re: [PATCH] arm64: Add purgatory printing

2020-09-17 Thread Bhupesh SHARMA
Hi Matthias, Thanks for the patch. Some nitpicks inline: On Fri, Sep 18, 2020 at 1:09 AM wrote: > > From: Matthias Brugger > > Add option to allow purgatory printing on arm64 hardware > by passing the console name which should be used. > Based on a patch by Geoff Levand. > > Cc: Geoff Levand

Re: [PATCH] kexec-tools: Add some missing free() calls

2020-09-16 Thread Bhupesh SHARMA
Hi Youling, See some comments inline: On Sat, Sep 12, 2020 at 7:11 AM Youling Tang wrote: > > Add some missing free() calls. > > Signed-off-by: Youling Tang > --- > kexec/arch/i386/crashdump-x86.c| 22 +- > kexec/arch/mips/crashdump-mips.c | 5 - >

Re: [PATCH] kexec-tools: Fix a prompt message when crashkernel is not reserved

2020-09-16 Thread Bhupesh SHARMA
quot;\"crashkernel=Y@X\" parameter to kernel\n" > "Then try to loading kdump kernel\n"); > } > > -- > 2.1.0 Thanks for the patch. LGTM, so: Reviewed-by: Bhupesh Sharma - Bhupesh ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH 1/1] Calculate offset to field 'init_uts_ns.name'

2020-09-16 Thread Bhupesh SHARMA
Hi Alexander, Thanks for the patch. See some nitpicks inline: On Wed, Sep 16, 2020 at 2:39 PM Alexander Egorenkov wrote: > > The offset has changed in linux-next (v5.9.0) from 4 to 0 because > there is no more 'kref' member variable at the beginning of 'init_uts_ns'. > The change was introduced

[PATCH] kexec/arm64: Add support for ARMv8.2 (large space addressing) 52-bit VA extensions

2020-09-15 Thread Bhupesh Sharma
chitecture Reference Manual. Cc: Simon Horman Cc: kexec@lists.infradead.org Signed-off-by: Bhupesh Sharma --- kexec/arch/arm64/Makefile | 2 + kexec/arch/arm64/common-arm64.c| 332 + kexec/arch/arm64/common-arm64.h| 8 + kexec/arch/arm64/crashdu

Re: [PATCH] arm64 : fix makedumpfile failure on 5.4+ kernels

2020-09-10 Thread Bhupesh SHARMA
Hello Ioanna, Thanks for the patch. I am partially at blame here (and also for top-posting here) as this failure is caused due to the flipped VA address space support we have on arm64 architecture now with newer kernels (>= 5.4.0) due to the addition of larger VA addressing space features

Re: [PATCH] crash_dump: Remove the unused include statements

2020-09-10 Thread Bhupesh Sharma
SH_DUMP > #define ELFCORE_ADDR_MAX (-1ULL) > #define ELFCORE_ADDR_ERR (-2ULL) > -- LGTM, so: Reviewed-by: Bhupesh Sharma Thanks. ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

[PATCH v5 0/3] makedumpfile/arm64: Add support for ARMv8.2 extensions

2020-09-09 Thread Bhupesh Sharma
quot;) Cc: John Donnelly Cc: Kazuhito Hagio Cc: kexec@lists.infradead.org Bhupesh Sharma (3): tree-wide: Retrieve 'MAX_PHYSMEM_BITS' from vmcoreinfo (if available) makedumpfile/arm64: Add support for ARMv8.2-LPA (52-bit PA support) makedumpfile/arm64: Add support for ARMv8.2-LVA (52-bit kernel

[PATCH v5 1/3] tree-wide: Retrieve 'MAX_PHYSMEM_BITS' from vmcoreinfo (if available)

2020-09-09 Thread Bhupesh Sharma
' is not available in vmcoreinfo. [0]. http://lists.infradead.org/pipermail/kexec/2019-November/023960.html Cc: Kazuhito Hagio Cc: John Donnelly Cc: kexec@lists.infradead.org Signed-off-by: Bhupesh Sharma --- arch/arm.c | 8 +++- arch/ia64.c| 7 ++- arch/ppc.c | 8 +++- arch

[PATCH v5 2/3] makedumpfile/arm64: Add support for ARMv8.2-LPA (52-bit PA support)

2020-09-09 Thread Bhupesh Sharma
Signed-off-by: Bhupesh Sharma --- arch/arm64.c | 291 --- 1 file changed, 204 insertions(+), 87 deletions(-) diff --git a/arch/arm64.c b/arch/arm64.c index 54d60b440850..709e0a506916 100644 --- a/arch/arm64.c +++ b/arch/arm64.c @@ -39,72 +39,185

[PATCH v5 3/3] makedumpfile/arm64: Add support for ARMv8.2-LVA (52-bit kernel VA support)

2020-09-09 Thread Bhupesh Sharma
itialized before its first use otherwise. This patch is in accordance with ARMv8 Architecture Reference Manual Cc: Kazuhito Hagio Cc: John Donnelly Cc: kexec@lists.infradead.org Signed-off-by: Bhupesh Sharma --- arch/arm64.c | 233 ++---

Re: [PATCH] kexec: remove the 2GB size limit on initrd file

2020-09-02 Thread Bhupesh Sharma
Hi Robi, On Wed, Sep 2, 2020 at 1:05 PM Robi Buranyi wrote: > > Enable loading initrd files exceeding the INT_MAX size. Remove the > INT_MAX limit completely, and let any initrd load if it fits in the > memory. > > Signed-off-by: Robi Buranyi > --- > kernel/kexec_file.c | 4 ++-- > 1 file

Re: [PATCH] arm64/defconfig: Enable CONFIG_KEXEC_FILE

2020-07-04 Thread Bhupesh Sharma
On Fri, Jul 3, 2020 at 10:09 PM Catalin Marinas wrote: > > On Fri, Jul 03, 2020 at 12:55:03AM +0530, Bhupesh Sharma wrote: > > On Fri, May 15, 2020 at 2:44 PM Bhupesh Sharma wrote: > > > On Thu, Apr 30, 2020 at 10:05 AM Bhupesh Sharma > > > wrote: > >

Re: [PATCH 2/2] arm64: Allocate crashkernel always in ZONE_DMA

2020-07-03 Thread Bhupesh Sharma
Hi Chen, On Fri, Jul 3, 2020 at 10:54 AM chenzhou wrote: > > Hi Bhupesh, > > > On 2020/7/3 3:22, Bhupesh Sharma wrote: > > Hi Will, > > > > On Thu, Jul 2, 2020 at 1:20 PM Will Deacon wrote: > >> On Thu, Jul 02, 2020 at 03:44:20AM +0530, Bhupesh Sharm

Re: [PATCH v10 0/5] support reserving crashkernel above 4G on arm64 kdump

2020-07-03 Thread Bhupesh Sharma
Hi Chen, On Fri, Jul 3, 2020 at 9:24 AM Chen Zhou wrote: > > This patch series enable reserving crashkernel above 4G in arm64. > > There are following issues in arm64 kdump: > 1. We use crashkernel=X to reserve crashkernel below 4G, which will fail > when there is no enough low memory. > 2.

Re: [PATCH] arm64/defconfig: Enable CONFIG_KEXEC_FILE

2020-07-02 Thread Bhupesh Sharma
Hi Catalin, On Fri, May 15, 2020 at 2:44 PM Bhupesh Sharma wrote: > > Hi Arnd, > > On Thu, Apr 30, 2020 at 10:05 AM Bhupesh Sharma wrote: > > > > On Tue, Apr 28, 2020 at 3:37 PM Catalin Marinas > > wrote: > > > > > > On Tue, Apr 28

Re: [PATCH 2/2] arm64: Allocate crashkernel always in ZONE_DMA

2020-07-02 Thread Bhupesh Sharma
Hi Will, On Thu, Jul 2, 2020 at 1:20 PM Will Deacon wrote: > > On Thu, Jul 02, 2020 at 03:44:20AM +0530, Bhupesh Sharma wrote: > > commit bff3b04460a8 ("arm64: mm: reserve CMA and crashkernel in > > ZONE_DMA32") allocates crashkernel for arm64 in the ZONE_DMA32.

Re: [PATCH 1/2] mm/memcontrol: Fix OOPS inside mem_cgroup_get_nr_swap_pages()

2020-07-02 Thread Bhupesh Sharma
Hi Michal, On Thu, Jul 2, 2020 at 11:30 AM Michal Hocko wrote: > > On Thu 02-07-20 03:44:19, Bhupesh Sharma wrote: > > Prabhakar reported an OOPS inside mem_cgroup_get_nr_swap_pages() > > function in a corner case seen on some arm64 boards when kdump kernel > > runs wit

Re: [PATCH v6 0/2] Append new variables to vmcoreinfo (TCR_EL1.T1SZ for arm64 and MAX_PHYSMEM_BITS for all archs)

2020-07-02 Thread Bhupesh Sharma
On Thu, Jul 2, 2020 at 10:45 PM Catalin Marinas wrote: > > On Thu, 14 May 2020 00:22:35 +0530, Bhupesh Sharma wrote: > > Apologies for the delayed update. Its been quite some time since I > > posted the last version (v5), but I have been really caught up in some > &g

[PATCH 2/2] arm64: Allocate crashkernel always in ZONE_DMA

2020-07-01 Thread Bhupesh Sharma
orse Cc: Mark Rutland Cc: Will Deacon Cc: Catalin Marinas Cc: cgro...@vger.kernel.org Cc: linux...@kvack.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-ker...@vger.kernel.org Cc: kexec@lists.infradead.org Reported-by: Prabhakar Kushwaha Signed-off-by: Bhupesh Sharma --- arch/arm64/mm/init.

[PATCH 0/2] arm64/kdump: Fix OOPS and OOM issues in kdump kernel

2020-07-01 Thread Bhupesh Sharma
Cc: linux...@kvack.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-ker...@vger.kernel.org Cc: kexec@lists.infradead.org Reported-by: Prabhakar Kushwaha Signed-off-by: Bhupesh Sharma Bhupesh Sharma (2): mm/memcontrol: Fix OOPS inside mem_cgroup_get_nr_swap_pages() arm64: Allocate crashker

[PATCH 1/2] mm/memcontrol: Fix OOPS inside mem_cgroup_get_nr_swap_pages()

2020-07-01 Thread Bhupesh Sharma
Cc: linux...@kvack.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-ker...@vger.kernel.org Cc: kexec@lists.infradead.org Reported-by: Prabhakar Kushwaha Signed-off-by: Bhupesh Sharma --- mm/memcontrol.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/mm/memcontrol

Re: [PATCH] arm64: continue loading even if kaslr-seed is not wiped to zero

2020-06-17 Thread Bhupesh Sharma
Hi Xunlin, On Tue, Jun 16, 2020 at 9:03 AM Xulin Sun wrote: > > The commit c3f043241a866a (arm64: Add support to supply 'kaslr-seed' to > secondary kernel) > add kaslr-seed support. And consider the primary kernel reads the 'kaslr-seed' > and wipes it to 0. But in the situation,

Re: Re: [RESEND PATCH v5 2/5] arm64/crash_core: Export TCR_EL1.T1SZ in vmcoreinfo

2020-06-16 Thread Bhupesh Sharma
gt; changes are present) > When I used crash utility, following is the error: > > Thanks, > -Bharat > > > -Original Message- > From: Scott Branden [mailto:scott.bran...@broadcom.com] > Sent: Thursday, April 30, 2020 4:34 AM > To: Bhupesh Sharma; Amit Kachhap >

Re: [PATCH v6 0/2] Append new variables to vmcoreinfo (TCR_EL1.T1SZ for arm64 and MAX_PHYSMEM_BITS for all archs)

2020-06-15 Thread Bhupesh Sharma
Hello Catalin, Will, On Tue, Jun 2, 2020 at 10:54 AM Bhupesh Sharma wrote: > > Hello, > > On Thu, May 14, 2020 at 12:22 AM Bhupesh Sharma wrote: > > > > Apologies for the delayed update. Its been quite some time since I > > posted the last version (v5), but I have

Re: [PATCH] kexec: dump kmessage before machine_kexec

2020-06-08 Thread Bhupesh Sharma
machine_shutdown(); > } > > + kmsg_dump(KMSG_DUMP_SHUTDOWN); > machine_kexec(kexec_image); > > #ifdef CONFIG_KEXEC_JUMP > -- > 2.25.1 LGTM, so: Reviewed-by: Bhupesh Sharma Thanks. ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: Re: [RESEND PATCH v5 5/5] Documentation/vmcoreinfo: Add documentation for 'TCR_EL1.T1SZ'

2020-06-03 Thread Bhupesh Sharma
Hello Scott, On Thu, Jun 4, 2020 at 12:17 AM Scott Branden wrote: > > Hi Bhupesh, > > Would be great to get this patch series upstreamed? > > On 2019-12-25 10:49 a.m., Bhupesh Sharma wrote: > > Hi James, > > > > On 12/12/2019 04:02 PM, James Morse wrote:

Re: [PATCH v6 2/2] arm64/crash_core: Export TCR_EL1.T1SZ in vmcoreinfo

2020-06-03 Thread Bhupesh Sharma
Hi Kamlakant, Many thanks for having a look at the patchset. On Wed, Jun 3, 2020 at 4:50 PM Kamlakant Patel wrote: > > Hi Bhupesh, > > > -Original Message- > > From: kexec On Behalf Of Bhupesh > > Sharma > > Sent: Thursday, May 14, 20

Re: [PATCH v8 0/5] support reserving crashkernel above 4G on arm64 kdump

2020-06-03 Thread Bhupesh Sharma
2020 at 8:12 PM John Donnelly > >> wrote: > >>> > >>> > >>>> On Jun 2, 2020, at 12:38 AM, Prabhakar Kushwaha > >>>> wrote: > >>>> > >>>> On Tue, Jun 2, 2020 at 3:29 AM John Donnelly > >>>&g

Re: [PATCH v6 0/2] Append new variables to vmcoreinfo (TCR_EL1.T1SZ for arm64 and MAX_PHYSMEM_BITS for all archs)

2020-06-01 Thread Bhupesh Sharma
Hello, On Thu, May 14, 2020 at 12:22 AM Bhupesh Sharma wrote: > > Apologies for the delayed update. Its been quite some time since I > posted the last version (v5), but I have been really caught up in some > other critical issues. > > Changes since v5: >

Re: [PATCH v8 0/5] support reserving crashkernel above 4G on arm64 kdump

2020-06-01 Thread Bhupesh Sharma
Hi John, On Tue, Jun 2, 2020 at 1:01 AM John Donnelly wrote: > > Hi, > > > On 6/1/20 7:02 AM, Prabhakar Kushwaha wrote: > > Hi Chen, > > > > On Thu, May 21, 2020 at 3:05 PM Chen Zhou wrote: > >> This patch series enable reserving crashkernel above 4G in arm64. > >> > >> There are following

Re: [PATCH v7 0/4] support reserving crashkernel above 4G on arm64 kdump

2020-05-20 Thread Bhupesh Sharma
Hi John, On Wed, May 20, 2020 at 1:53 AM John Donnelly wrote: > > > > > On May 19, 2020, at 5:21 AM, Arnd Bergmann wrote: > > > > On Thu, Mar 26, 2020 at 4:10 AM Chen Zhou wrote: > >> > >> Hi all, > >> > >> Friendly ping... > > > > I was asked about this patch series, and see that you last

Re: [PATCH] arm64/defconfig: Enable CONFIG_KEXEC_FILE

2020-05-15 Thread Bhupesh Sharma
Hi Arnd, On Thu, Apr 30, 2020 at 10:05 AM Bhupesh Sharma wrote: > > On Tue, Apr 28, 2020 at 3:37 PM Catalin Marinas > wrote: > > > > On Tue, Apr 28, 2020 at 01:55:58PM +0530, Bhupesh Sharma wrote: > > > On Wed, Apr 8, 2020 at 4:17 PM Mark Rutland wrote: > &g

[PATCH v6 1/2] crash_core, vmcoreinfo: Append 'MAX_PHYSMEM_BITS' to vmcoreinfo

2020-05-13 Thread Bhupesh Sharma
-by: John Donnelly Signed-off-by: Bhupesh Sharma --- Documentation/admin-guide/kdump/vmcoreinfo.rst | 5 + kernel/crash_core.c| 1 + 2 files changed, 6 insertions(+) diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst b/Documentation/admin-guide/kdump

[PATCH v6 2/2] arm64/crash_core: Export TCR_EL1.T1SZ in vmcoreinfo

2020-05-13 Thread Bhupesh Sharma
-by: John Donnelly Signed-off-by: Bhupesh Sharma --- Documentation/admin-guide/kdump/vmcoreinfo.rst | 11 +++ arch/arm64/include/asm/pgtable-hwdef.h | 1 + arch/arm64/kernel/crash_core.c | 10 ++ 3 files changed, 22 insertions(+) diff --git a/Documentation

[PATCH v6 0/2] Append new variables to vmcoreinfo (TCR_EL1.T1SZ for arm64 and MAX_PHYSMEM_BITS for all archs)

2020-05-13 Thread Bhupesh Sharma
...@lists.infradead.org Cc: linux-ker...@vger.kernel.org Cc: linux-...@vger.kernel.org Cc: kexec@lists.infradead.org Bhupesh Sharma (2): crash_core, vmcoreinfo: Append 'MAX_PHYSMEM_BITS' to vmcoreinfo arm64/crash_core: Export TCR_EL1.T1SZ in vmcoreinfo Documentation/admin-guide/kdump/vmcoreinfo.rst | 16

[PATCH v2 2/2] net: qed: Disable SRIOV functionality inside kdump kernel

2020-05-11 Thread Bhupesh Sharma
-off-by: Bhupesh Sharma --- drivers/net/ethernet/qlogic/qed/qed_sriov.h | 10 +++--- drivers/net/ethernet/qlogic/qede/qede_main.c | 2 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_sriov.h b/drivers/net/ethernet/qlogic/qed/qed_sriov.h

[PATCH v2 1/2] net: qed*: Reduce RX and TX default ring count when running inside kdump kernel

2020-05-11 Thread Bhupesh Sharma
ed-off-by: Bhupesh Sharma --- drivers/net/ethernet/qlogic/qede/qede.h | 2 ++ drivers/net/ethernet/qlogic/qede/qede_main.c | 11 +-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qede/qede.h b/drivers/net/ethernet/qlogic/qede/qede.h

[PATCH v2 0/2] net: Optimize the qed* allocations inside kdump kernel

2020-05-11 Thread Bhupesh Sharma
X ring count in kdump kernel. [PATCH 2/2] - Disables qed SRIOV feature in kdump kernel (as it is normally not a supported kdump target for saving vmcore). [1]. Memstrack tool: https://github.com/ryncsn/memstrack Bhupesh Sharma (2): net: qed*: Reduce RX and TX defaul

Re: [EXT] [PATCH 1/2] net: qed*: Reduce RX and TX default ring count when running inside kdump kernel

2020-05-06 Thread Bhupesh Sharma
Hello Igor, On Wed, May 6, 2020 at 12:21 PM Igor Russkikh wrote: > > > > > #include > > +#include > > #include > > #include > > #include > > @@ -574,13 +575,13 @@ int qede_add_tc_flower_fltr(struct qede_dev *edev, > > __be16 proto, > > #define RX_RING_SIZE

Re: [PATCH 1/2] net: qed*: Reduce RX and TX default ring count when running inside kdump kernel

2020-05-05 Thread Bhupesh Sharma
Hi David, On Wed, May 6, 2020 at 2:54 AM David Miller wrote: > > From: Bhupesh Sharma > Date: Wed, 6 May 2020 00:34:40 +0530 > > > -#define NUM_RX_BDS_DEF ((u16)BIT(10) - 1) > > +#define NUM_RX_BDS_DEF ((is_kdump_kernel()) ? ((u16)BIT(6)

[PATCH 2/2] net: qed: Disable SRIOV functionality inside kdump kernel

2020-05-05 Thread Bhupesh Sharma
-off-by: Bhupesh Sharma --- drivers/net/ethernet/qlogic/qed/qed_sriov.h | 10 +++--- drivers/net/ethernet/qlogic/qede/qede_main.c | 2 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_sriov.h b/drivers/net/ethernet/qlogic/qed/qed_sriov.h

[PATCH 0/2] net: Optimize the qed* allocations inside kdump kernel

2020-05-05 Thread Bhupesh Sharma
ult TX and RX ring count in kdump kernel. [PATCH 2/2] - Disables qed SRIOV feature in kdump kernel (as it is normally not a supported kdump target for saving vmcore). [1]. Memstrack tool: https://github.com/ryncsn/memstrack - Bhupesh Sharma (2): net: qed*: Reduce RX

[PATCH 1/2] net: qed*: Reduce RX and TX default ring count when running inside kdump kernel

2020-05-05 Thread Bhupesh Sharma
ed-off-by: Bhupesh Sharma --- drivers/net/ethernet/qlogic/qede/qede.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qede/qede.h b/drivers/net/ethernet/qlogic/qede/qede.h index 234c6f30effb..b55ab32ef0b3 100644 --- a/drivers/net/ethernet/qlogic/qede/

Re: [PATCH] arm64/defconfig: Enable CONFIG_KEXEC_FILE

2020-04-29 Thread Bhupesh Sharma
On Tue, Apr 28, 2020 at 3:37 PM Catalin Marinas wrote: > > On Tue, Apr 28, 2020 at 01:55:58PM +0530, Bhupesh Sharma wrote: > > On Wed, Apr 8, 2020 at 4:17 PM Mark Rutland wrote: > > > On Tue, Apr 07, 2020 at 04:01:40AM +0530, Bhupesh Sharma wrote: > > > >

Re: [PATCH] arm64/defconfig: Enable CONFIG_KEXEC_FILE

2020-04-28 Thread Bhupesh Sharma
On Wed, Apr 8, 2020 at 4:17 PM Mark Rutland wrote: > > On Tue, Apr 07, 2020 at 04:01:40AM +0530, Bhupesh Sharma wrote: > > kexec_file_load() syscall interface is now supported for > > arm64 architecture as well via commits: > > 3751e728cef2 ("arm64: kexec

Re: [PATCH 1/3] kexec: Prevent removal of memory in use by a loaded kexec image

2020-04-12 Thread Bhupesh SHARMA
On Mon, Apr 13, 2020 at 1:26 AM Eric W. Biederman wrote: > > > The only benefit of kexec_file_load is that it is simple enough from a > kernel perspective that signatures can be checked. > > kexec_load in every other respect is the more capable and functional > interface. It makes no sense to

[PATCH] arm64/defconfig: Enable CONFIG_KEXEC_FILE

2020-04-06 Thread Bhupesh Sharma
config, so that user-space tools like kexec-tools can use the same as the default interface for kexec/kdump on arm64. Cc: AKASHI Takahiro Cc: Catalin Marinas Cc: James Morse Cc: Mark Rutland Cc: Will Deacon Cc: kexec@lists.infradead.org Signed-off-by: Bhupesh Sharma --- arch/arm64/configs/def

Re: [PATCH] net: ena: Add PCI shutdown handler to allow safe kexec

2020-03-24 Thread Bhupesh Sharma
on the machine. Now with this patch, I can runs hundreds of repetitive nested kexec reboots on the aws nitro machines without any failure. So, I think this is a really good patch and should be applied to stable trees as well. Please feel free to add: Tested-and-Reviewed-by: Bhupesh Sharma

Re: About kexec issues in AWS nitro instances (RH bz 1758323)

2020-03-23 Thread Bhupesh Sharma
Hi Guilherme, On Mon, Mar 23, 2020 at 8:16 PM Guilherme G. Piccoli wrote: > > On 22/03/2020 18:16, Bhupesh Sharma wrote: > > Hello Guilherme, > > > > On Fri, Mar 20, 2020 at 9:10 PM Guilherme G. Piccoli > > wrote: > > > > Thanks for writing agai

Re: About kexec issues in AWS nitro instances (RH bz 1758323)

2020-03-22 Thread Bhupesh Sharma
Hello Guilherme, On Fri, Mar 20, 2020 at 9:10 PM Guilherme G. Piccoli wrote: Thanks for writing again. I was caught up in trying several other suggestions/code-snippets to further debug this. I tried several combinations - turning iommu off, turning off swiotlb in the kexec kernel and testing

Re: [PATCH makedumpfile] Align PMD_SECTION_MASK with PHYS_MASK

2020-03-17 Thread Bhupesh Sharma
On Wed, Mar 18, 2020 at 2:35 AM Michal Suchánek wrote: > > On Wed, Mar 18, 2020 at 01:49:05AM +0530, Bhupesh Sharma wrote: > > On Wed, Mar 18, 2020 at 1:05 AM Michal Suchánek wrote: > > > > > > On Tue, Mar 17, 2020 at 02:14:22PM +, HAGIO KAZUHITO(萩

Re: [PATCH makedumpfile] Align PMD_SECTION_MASK with PHYS_MASK

2020-03-17 Thread Bhupesh Sharma
On Wed, Mar 18, 2020 at 1:05 AM Michal Suchánek wrote: > > On Tue, Mar 17, 2020 at 02:14:22PM +, HAGIO KAZUHITO(萩尾 一仁) wrote: > > Hi Michal, > > > > Thank you for the patch. > > > > > -Original Message- > > > Reportedly on some arm64 systems makedumpfile loops forever exhausting > > >

Re: QUESTION : dracut debugging for kdump

2020-03-09 Thread Bhupesh Sharma
On Tue, Mar 10, 2020 at 1:18 AM John Donnelly wrote: > > > > > On Mar 9, 2020, at 1:51 PM, Bhupesh Sharma wrote: > > > > Hi John, > > > > On Mon, Mar 9, 2020 at 10:38 PM John Donnelly > > wrote: > >> > >> Hi kexec/kdump team.

Re: QUESTION : dracut debugging for kdump

2020-03-09 Thread Bhupesh Sharma
Hi John, On Mon, Mar 9, 2020 at 10:38 PM John Donnelly wrote: > > Hi kexec/kdump team. > > I am not sure if this is the appropriate dlist to ask . If not , I > apologize . > > > I am having difficulties mounting a iSCSI target under kdump . We have had several known issues with iSCSI

Re: About kexec issues in AWS nitro instances (RH bz 1758323)

2020-03-04 Thread Bhupesh Sharma
Hi, On Mon, Mar 2, 2020 at 1:39 PM Dave Young wrote: > > On 03/02/20 at 12:20am, Bhupesh Sharma wrote: > > Hi Guilherme, > > > > On Sat, Feb 29, 2020 at 10:37 PM Guilherme G. Piccoli > > wrote: > > > > > > Hi Bhupesh and Dave (and everybody

Re: About kexec issues in AWS nitro instances (RH bz 1758323)

2020-03-01 Thread Bhupesh Sharma
Hi Guilherme, On Sat, Feb 29, 2020 at 10:37 PM Guilherme G. Piccoli wrote: > > Hi Bhupesh and Dave (and everybody CC'ed here), I'm Guilherme Piccoli > and I'm working in the same issue observed in RH bugzilla 1758323 [0] - > or at least, it seems to be the the same heh Ok. > The reported issue

Re: [PATCH v2] kexec: support parsing the string "Reserved" to get the correct e820 reserved region

2020-02-23 Thread Bhupesh Sharma
) == 0) { > type = RANGE_RAM; > } > - else if (memcmp(str, "reserved\n", 9) == 0) { > + else if (strncasecmp(str, "reserved\n", 9) == 0) { > type = RANGE_RESERVED; >

Re: [RESEND PATCH v5 2/5] arm64/crash_core: Export TCR_EL1.T1SZ in vmcoreinfo

2020-02-23 Thread Bhupesh Sharma
Hi Amit, On Fri, Feb 21, 2020 at 2:36 PM Amit Kachhap wrote: > > Hi Bhupesh, > > On 1/13/20 5:44 PM, Bhupesh Sharma wrote: > > Hi James, > > > > On 01/11/2020 12:30 AM, Dave Anderson wrote: > >> > >> - Original Message - > >>>

Re: [PATCH] kexec: support parsing the string "Reserved" to get the correct e820 reserved region

2020-02-12 Thread Bhupesh Sharma
Hi Lianbo, Thanks for the patch. On Wed, Feb 12, 2020 at 6:27 PM Lianbo Jiang wrote: > > When loading kernel and initramfs for kexec, kexec-tools could get the > e820 reserved region from "/proc/iomem" in order to rebuild the e820 > ranges for kexec kernel, but there may be the string

Re: [RFC] printing the final constructed kernel command line

2020-01-13 Thread Bhupesh Sharma
On 01/07/2020 03:40 AM, Eric DeVolder wrote: Bhupesh, I'm finding myself slammed with other tasks, if you'd like to kick start this patch, then please feel free! eric Ok Eric, Let me try to send patches to fix the same. Thanks, Bhupesh On 12/23/19 12:50 AM, Bhupesh Sharma wrote: On Thu

Re: [RESEND PATCH v5 2/5] arm64/crash_core: Export TCR_EL1.T1SZ in vmcoreinfo

2020-01-13 Thread Bhupesh Sharma
Hi James, On 01/11/2020 12:30 AM, Dave Anderson wrote: - Original Message - Hi Bhupesh, On 25/12/2019 19:01, Bhupesh Sharma wrote: On 12/12/2019 04:02 PM, James Morse wrote: On 29/11/2019 19:59, Bhupesh Sharma wrote: vabits_actual variable on arm64 indicates the actual VA space

Re: [RESEND PATCH v5 2/5] arm64/crash_core: Export TCR_EL1.T1SZ in vmcoreinfo

2019-12-25 Thread Bhupesh Sharma
Hi James, On 12/12/2019 04:02 PM, James Morse wrote: Hi Bhupesh, On 29/11/2019 19:59, Bhupesh Sharma wrote: vabits_actual variable on arm64 indicates the actual VA space size, and allows a single binary to support both 48-bit and 52-bit VA spaces. If the ARMv8.2-LVA optional feature

Re: [RESEND PATCH v5 5/5] Documentation/vmcoreinfo: Add documentation for 'TCR_EL1.T1SZ'

2019-12-25 Thread Bhupesh Sharma
Hi James, On 12/12/2019 04:02 PM, James Morse wrote: Hi Bhupesh, I am sorry this review mail skipped my attention due to holidays and focus on other urgent issues. On 29/11/2019 19:59, Bhupesh Sharma wrote: Add documentation for TCR_EL1.T1SZ variable being added to vmcoreinfo

Re: [PATCH v3 0/3] arm64: handle "reserved" entries in /proc/iomem

2019-12-22 Thread Bhupesh Sharma
Thanks for the patches Masa, On Wed, Dec 18, 2019 at 10:13 PM Masayoshi Mizuma wrote: > > In recent arm64 kernels, /proc/iomem has an extended file format like: > > 4000-5871 : System RAM >4180-426a : Kernel code >426b-42aa : reserved >42ab-42c64fff :

Re: [RFC] printing the final constructed kernel command line

2019-12-22 Thread Bhupesh Sharma
I never got the time to complete the same. I will try to find out some time over this week to consolidate these features and send an RFC patch. I will Cc you to the same. Hopefully that should do the trick. Thanks, Bhupesh > On 12/19/19 7:34 AM, Bhupesh Sharma wrote: > > Hi Eric, > &

Re: [RFC] printing the final constructed kernel command line

2019-12-19 Thread Bhupesh Sharma
On 12/19/2019 12:46 AM, John Donnelly wrote: On Dec 18, 2019, at 1:00 PM, Eric DeVolder wrote: Thanks Bhupesh for the feedback, responses below! eric On 12/17/19 1:59 PM, Bhupesh Sharma wrote: Hi Eric, On 12/17/2019 02:02 AM, Eric DeVolder wrote: The --command-line, --append, and --reuse

Re: [RFC] printing the final constructed kernel command line

2019-12-19 Thread Bhupesh Sharma
Hi Eric, On 12/19/2019 12:30 AM, Eric DeVolder wrote: Thanks Bhupesh for the feedback, responses below! eric On 12/17/19 1:59 PM, Bhupesh Sharma wrote: Hi Eric, On 12/17/2019 02:02 AM, Eric DeVolder wrote: The --command-line, --append, and --reuse-cmdline options to kexec can be used

Re: [RFC] printing the final constructed kernel command line

2019-12-17 Thread Bhupesh Sharma
Hi Eric, On 12/17/2019 02:02 AM, Eric DeVolder wrote: The --command-line, --append, and --reuse-cmdline options to kexec can be used in combination to craft a kernel command line for a kernel loaded via kexec. In addition, the kexec tool may also manipulate further the command line, eg.

Re: [PATCH v5 0/5] Append new variables to vmcoreinfo (TCR_EL1.T1SZ for arm64 and MAX_PHYSMEM_BITS for all archs)

2019-12-15 Thread Bhupesh Sharma
Hi Boris, On Sat, Dec 14, 2019 at 5:57 PM Borislav Petkov wrote: > > On Fri, Nov 29, 2019 at 01:53:36AM +0530, Bhupesh Sharma wrote: > > Bhupesh Sharma (5): > > crash_core, vmcoreinfo: Append 'MAX_PHYSMEM_BITS' to vmcoreinfo > > arm64/crash_core: Export TC

Re: [PATCH v2 2/3] arm64: kexec: allocate memory space avoiding reserved regions

2019-12-15 Thread Bhupesh Sharma
Thanks Masa, On Sat, Dec 14, 2019 at 1:34 AM Masayoshi Mizuma wrote: > > some nits as below: > > On Fri, Jan 11, 2019 at 06:59:45PM +0900, AKASHI Takahiro wrote: > > On UEFI/ACPI-only system, some memory regions, including but not limited > > to UEFI memory map and ACPI tables, must be preserved

Re: [PATCH v4 4/4] makedumpfile: Mark --mem-usage option unsupported for arm64

2019-12-05 Thread Bhupesh Sharma
same in future > > kernel/makedumpfile versions. > > > > Cc: John Donnelly > > Cc: Kazuhito Hagio > > Cc: kexec@lists.infradead.org > > Signed-off-by: Bhupesh Sharma > > --- > > makedumpfile.c | 5 + > > 1 file changed, 5 insertions(+)

Re: [PATCH v4 2/4] makedumpfile/arm64: Add support for ARMv8.2-LPA (52-bit PA support)

2019-12-05 Thread Bhupesh Sharma
t; > vmcoreinfo for arm64 (see [0]). > > > > This patch is in accordance with ARMv8 Architecture Reference Manual > > version D.a > > > > [0]. http://lists.infradead.org/pipermail/kexec/2019-November/023960.html > > > > Cc

Re: [PATCH v4 1/4] tree-wide: Retrieve 'MAX_PHYSMEM_BITS' from vmcoreinfo (if available)

2019-12-05 Thread Bhupesh Sharma
rg/pipermail/kexec/2019-November/023960.html > > > > Cc: Kazuhito Hagio > > Cc: John Donnelly > > Cc: kexec@lists.infradead.org > > Signed-off-by: Bhupesh Sharma > > --- > > arch/arm.c | 8 +++- > > arch/ia64.c| 7 ++- > >

Re: [PATCH v4 3/4] makedumpfile/arm64: Add support for ARMv8.2-LVA (52-bit kernel VA support)

2019-12-05 Thread Bhupesh Sharma
tion will not work > > > properly for arm64 (a subsequent patch in this series will address the > > > same) and there is a discussion on-going with the arm64 maintainers to > > > find a way-out for the same (via standard kernel symbols like _stext). > > > >

Re: [PATCH v2 3/3] arm64: kexec_file: add crash dump support

2019-12-04 Thread Bhupesh Sharma
On 11/14/2019 10:45 AM, AKASHI Takahiro wrote: Enabling crash dump (kdump) includes * prepare contents of ELF header of a core dump file, /proc/vmcore, using crash_prepare_elf64_headers(), and * add two device tree properties, "linux,usable-memory-range" and "linux,elfcorehdr", which

Re: [PATCH v2 1/3] libfdt: define UINT32_MAX in libfdt_env.h

2019-12-04 Thread Bhupesh Sharma
Hi Akashi, On 11/14/2019 10:45 AM, AKASHI Takahiro wrote: In the implementation of kexec_file_load-based kdump for arm64, fdt_appendprop_addrrange() will be used, but fdt_addresses.c will fail to compile due to missing UINT32_MAX. So just define it in libfdt_env.h. Signed-off-by: AKASHI

Re: [PATCH v2 0/3] arm64: kexec_file: add kdump

2019-12-04 Thread Bhupesh Sharma
d-Reviewed-by: Bhupesh Sharma Thanks, Bhupesh AKASHI Takahiro (3): libfdt: define UINT32_MAX in libfdt_env.h libfdt: include fdt_addresses.c arm64: kexec_file: add crash dump support arch/arm64/include/asm/kexec.h | 4 + arch/arm64/kernel/kexec_image.c| 4 - arch/ar

Re: [PATCH] efi/memreserve: register reservations as 'reserved' in /proc/iomem

2019-12-04 Thread Bhupesh SHARMA
Hello Masa, (+Cc Simon) On Thu, Dec 5, 2019 at 12:27 AM Masayoshi Mizuma wrote: > > On Wed, Dec 04, 2019 at 06:17:59PM +, James Morse wrote: > > Hi Masa, > > > > On 04/12/2019 17:17, Masayoshi Mizuma wrote: > > > Thank you for sending the patch, but unfortunately it doesn't work for > > >

Re: [PATCH v5 0/5] Append new variables to vmcoreinfo (TCR_EL1.T1SZ for arm64 and MAX_PHYSMEM_BITS for all archs)

2019-11-29 Thread Bhupesh Sharma
Hi Will, On Fri, Nov 29, 2019 at 3:54 PM Will Deacon wrote: > > On Fri, Nov 29, 2019 at 01:53:36AM +0530, Bhupesh Sharma wrote: > > Changes since v4: > > > > - v4 can be seen here: > > http://lists.infradead.org/pipermail/kexec/2019-Novemb

[RESEND PATCH v5 5/5] Documentation/vmcoreinfo: Add documentation for 'TCR_EL1.T1SZ'

2019-11-29 Thread Bhupesh Sharma
Cc: Ard Biesheuvel Cc: Dave Anderson Cc: Kazuhito Hagio Cc: linux-arm-ker...@lists.infradead.org Cc: linux-ker...@vger.kernel.org Cc: kexec@lists.infradead.org Signed-off-by: Bhupesh Sharma --- Documentation/admin-guide/kdump/vmcoreinfo.rst | 6 ++ 1 file changed, 6 insertions(+) diff

[RESEND PATCH v5 3/5] Documentation/arm64: Fix a simple typo in memory.rst

2019-11-29 Thread Bhupesh Sharma
Fix a simple typo in arm64/memory.rst Cc: Jonathan Corbet Cc: James Morse Cc: Mark Rutland Cc: Will Deacon Cc: Steve Capper Cc: Catalin Marinas Cc: Ard Biesheuvel Cc: linux-...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Bhupesh

  1   2   3   4   5   >