Re: [PATCH v5 1/6] elf: Define note name macros

2025-01-15 Thread Dave Martin
NT_LOONGARCH_HW_WATCH0xa06 /* LoongArch hardware > watchpoint registers */ > > -/* Note types with note name "GNU" */ > -#define NT_GNU_PROPERTY_TYPE_0 5 > - > /* Note header in a PT_NOTE section */ > typedef struct elf32_note { >Elf32_Word n_namesz; /* Name size */ Reviewed-by: Dave Martin Cheers ---Dave

Re: [PATCH v4 4/6] crash: Use note name macros

2025-01-14 Thread Dave Martin
On Sat, Jan 11, 2025 at 02:48:47PM +0900, Akihiko Odaki wrote: > Use note name macros to match with the userspace's expectation. > > Signed-off-by: Akihiko Odaki > Acked-by: Baoquan He Reviewed-by: Dave Martin > --- > fs/proc/kcore.c | 12 ++

Re: [PATCH v4 5/6] s390/crash: Use note name macros

2025-01-14 Thread Dave Martin
Hi, On Sat, Jan 11, 2025 at 02:48:48PM +0900, Akihiko Odaki wrote: > Use note name macros to match with the userspace's expectation. > > Signed-off-by: Akihiko Odaki > Acked-by: Heiko Carstens Reviewed-by: Dave Martin (I'm not in a position to test this, though.) >

Re: [PATCH v4 6/6] crash: Remove KEXEC_CORE_NOTE_NAME

2025-01-14 Thread Dave Martin
Hi, On Sat, Jan 11, 2025 at 02:48:49PM +0900, Akihiko Odaki wrote: > KEXEC_CORE_NOTE_NAME is no longer used. > > Signed-off-by: Akihiko Odaki > Acked-by: Baoquan He Reviewed-by: Dave Martin > --- > include/linux/kexec.h | 2 -- > include/linux/vmcore_info.h | 1

Re: [PATCH v4 3/6] powerpc: Use note name macros

2025-01-14 Thread Dave Martin
ypes are not taken from elf.h anyway, I think this is probably out of scope for this series. I haven't tried to understand fully what that code is doing. Anyway: Reviewed-by: Dave Martin > > Acked-by: Baoquan He > Signed-off-by: Akihiko Odaki > --- > arch/powerpc/kerne

Re: [PATCH v4 1/6] elf: Define note name macros

2025-01-14 Thread Dave Martin
> watchpoint registers */ > > -/* Note types with note name "GNU" */ > +/* Note used in other file types. */ For this, it may make sense to be vaguer, e.g. /* Other notes */ (We don't dump NT_GNU_PROPERTY_TYPE_0 in coredumps, but I don't think it would be nonsensical to do so.) > +#define NN_GNU_PROPERTY_TYPE_0 "GNU" > #define NT_GNU_PROPERTY_TYPE_0 5 [...] With or without those changes, Reviewed-by: Dave Martin

Re: [PATCH v4 2/6] binfmt_elf: Use note name macros

2025-01-14 Thread Dave Martin
On Sat, Jan 11, 2025 at 02:48:45PM +0900, Akihiko Odaki wrote: > Use note name macros to match with the userspace's expectation. > > Signed-off-by: Akihiko Odaki > Acked-by: Baoquan He Reviewed-by: Dave Martin > --- > fs/binfmt_elf.c | 21 ++--- &

Re: [PATCH v3 5/6] s390/crash: Use note name macros

2025-01-09 Thread Dave Martin
Hi, On Thu, Jan 09, 2025 at 02:29:19PM +0900, Akihiko Odaki wrote: > On 2025/01/08 22:50, Dave Martin wrote: > > On Wed, Jan 08, 2025 at 01:53:51PM +0900, Akihiko Odaki wrote: > > > On 2025/01/08 1:17, Dave Martin wrote: > > > > Hi, > > > > > &

Re: [PATCH v3 5/6] s390/crash: Use note name macros

2025-01-08 Thread Dave Martin
On Wed, Jan 08, 2025 at 01:53:51PM +0900, Akihiko Odaki wrote: > On 2025/01/08 1:17, Dave Martin wrote: > > Hi, > > > > On Tue, Jan 07, 2025 at 09:45:56PM +0900, Akihiko Odaki wrote: > > > Use note name macros to match with the userspace's expectation. > &

Re: [PATCH v3 2/6] binfmt_elf: Use note name macros

2025-01-08 Thread Dave Martin
Hi, On Wed, Jan 08, 2025 at 01:34:24PM +0900, Akihiko Odaki wrote: > On 2025/01/08 1:18, Dave Martin wrote: > > On Tue, Jan 07, 2025 at 09:45:53PM +0900, Akihiko Odaki wrote: > > > Use note name macros to match with the userspace's expectation. > > > > Als

Re: [PATCH v3 5/6] s390/crash: Use note name macros

2025-01-07 Thread Dave Martin
Hi, On Tue, Jan 07, 2025 at 09:45:56PM +0900, Akihiko Odaki wrote: > Use note name macros to match with the userspace's expectation. > > Signed-off-by: Akihiko Odaki > --- > arch/s390/kernel/crash_dump.c | 62 > --- > 1 file changed, 23 insertions(+), 39

Re: [PATCH v3 2/6] binfmt_elf: Use note name macros

2025-01-07 Thread Dave Martin
On Tue, Jan 07, 2025 at 09:45:53PM +0900, Akihiko Odaki wrote: > Use note name macros to match with the userspace's expectation. Also (and more importantly) get rid of duplicated knowledge about the mapping of note types to note names, so that elf.h is the authoritative source of this information?

Re: [PATCH v2 1/5] elf: Define note name macros

2025-01-06 Thread Dave Martin
Hi all, On Mon, Jan 06, 2025 at 08:48:05AM -0800, Kees Cook wrote: > On Sat, Jan 04, 2025 at 11:38:34PM +0900, Akihiko Odaki wrote: > > elf.h had a comment saying: > > > Notes used in ET_CORE. Architectures export some of the arch register > > > sets using the corresponding note types via the PTRA

Re: [PATCH v2 0/5] elf: Define note name macros

2025-01-06 Thread Dave Martin
Hi, On Sat, Jan 04, 2025 at 11:38:33PM +0900, Akihiko Odaki wrote: > elf.h had a comment saying: > > Notes used in ET_CORE. Architectures export some of the arch register > > sets using the corresponding note types via the PTRACE_GETREGSET and > > PTRACE_SETREGSET requests. > > The note name for t

Re: [PATCH v2 5/5] crash: Remove KEXEC_CORE_NOTE_NAME

2025-01-06 Thread Dave Martin
Hi, On Sat, Jan 04, 2025 at 11:38:38PM +0900, Akihiko Odaki wrote: > Now KEXEC_CORE_NOTE_NAME is only used at one place and it does not seem > to provide any value anymore. Replace the remaining usage with the > literal and remove the macro. > > Signed-off-by: Akihiko Odaki > --- > arch/s390/ke

Re: [PATCH v2 1/5] elf: Define note name macros

2025-01-06 Thread Dave Martin
On Sat, Jan 04, 2025 at 11:38:34PM +0900, Akihiko Odaki wrote: > elf.h had a comment saying: > > Notes used in ET_CORE. Architectures export some of the arch register > > sets using the corresponding note types via the PTRACE_GETREGSET and > > PTRACE_SETREGSET requests. > > The note name for these

Re: [PATCH v15 03/20] arm64: Convert hcalls to use HVC immediate value

2016-03-19 Thread Dave Martin
On Tue, Mar 15, 2016 at 11:15:10AM -0700, Geoff Levand wrote: > Hi, > > On Tue, 2016-03-15 at 13:50 +0000, Dave Martin wrote: > > On Mon, Mar 14, 2016 at 05:48:00PM +, Geoff Levand wrote: > > > The existing arm64 hcall implementations are limited in that they only >

Re: [PATCH v15 03/20] arm64: Convert hcalls to use HVC immediate value

2016-03-15 Thread Dave Martin
Hi On Mon, Mar 14, 2016 at 05:48:00PM +, Geoff Levand wrote: > The existing arm64 hcall implementations are limited in that they only > allow for two distinct hcalls; with the x0 register either zero or not > zero. Also, the API of the hyp-stub exception vector routines and the > KVM exceptio

Re: [PATCH 04/19] arm64: Cleanup SCTLR flags

2016-01-19 Thread Dave Martin
so as to avoid any future surprises? > > Yes, that's one of the numerous instances of the same problem - I think > Dave Martin also has some fixes in that area. > > I'll definitely take patches! Yep, we have a similar problem with CPTR_EL2, patch to follow at some point.